[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

2022-09-02 Thread Konstantin Varlamov via Phabricator via cfe-commits
var-const added a comment. Out of curiosity, would it be possible to do a benchmark to see how adding `_LIBCPP_NODEBUG` to `std::invoke` would compare to using builtins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llv

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

2022-02-02 Thread Konstantin Varlamov via Phabricator via cfe-commits
var-const added a comment. @Quuxplusone Now that it's landed, do we still need `__workaround_52970` in libc++? (see https://github.com/llvm/llvm-project/blob/167b623a6af26802af47f455aaa3806faaa9da9e/libcxx/include/__concepts/class_or_enum.h#L28-L30) Repository: rG LLVM Github Monorepo CHANG