[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

2023-05-12 Thread Kyrill Briantsev via Phabricator via cfe-commits
awson added a comment. Now, this #include #include auto drop1(const std::vector& s){ return s | std::views::drop(1); } when compiled against gcc's-13.1 libstdc++ spits: boro.cpp:5:11: error: invalid operands to binary expression ('const std::vector' and '_Partial<_Drop,

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-01-08 Thread Kyrill Briantsev via Phabricator via cfe-commits
awson added a comment. It's weird that cl.exe command-line compiler reports version 19.10.24629 and lives in the 14.10.24629 directory (only first 2 digits are different). Moreover, in their explanation blogpost

[PATCH] D28220: provide Win32 native threading

2017-01-03 Thread Kyrill Briantsev via Phabricator via cfe-commits
awson added a comment. You don't need #define VC_EXTRA_LEAN since: 1. VC_EXTRA_LEAN is a mistype, only VC_EXTRALEAN has some meaning in Windows ecosystem; 2. VC_EXTRALEAN is used *only* in MFC headers which obviously aren't used in clang codebase. Thus it would be better to remove this