https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/94791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@h-vetinari This one still looks like a real issue:
https://buildkite.com/llvm-project/github-pull-requests/builds/74912#01903ca1-8089-4388-afdb-b65d400e6315
The rest looks good indeed.
https://github.com/llvm/llvm-project/pull/96171
_
ldionne wrote:
I'm sorry to be the bearer of bad news, but it looks like Android is failing
with this patch:
https://buildkite.com/llvm-project/libcxx-ci/builds/35981#01905269-56a0-4314-a350-0b99ece37e89
This is kinda weird, it fails due to the ABI list changing. I checked other
recent execut
Author: Louis Dionne
Date: 2024-06-26T15:44:28-05:00
New Revision: eeb931641ae735faa25283ddb2465318302e864f
URL:
https://github.com/llvm/llvm-project/commit/eeb931641ae735faa25283ddb2465318302e864f
DIFF:
https://github.com/llvm/llvm-project/commit/eeb931641ae735faa25283ddb2465318302e864f.diff
Author: Louis Dionne
Date: 2022-08-03T15:40:27-04:00
New Revision: c5ccb78ade8136134e0ca9dde64de97f913f0f8c
URL:
https://github.com/llvm/llvm-project/commit/c5ccb78ade8136134e0ca9dde64de97f913f0f8c
DIFF:
https://github.com/llvm/llvm-project/commit/c5ccb78ade8136134e0ca9dde64de97f913f0f8c.diff
Author: Louis Dionne
Date: 2022-08-16T09:27:18-04:00
New Revision: 65d83ba34378b8e740c5203fe46a9c50d2aeb862
URL:
https://github.com/llvm/llvm-project/commit/65d83ba34378b8e740c5203fe46a9c50d2aeb862
DIFF:
https://github.com/llvm/llvm-project/commit/65d83ba34378b8e740c5203fe46a9c50d2aeb862.diff
Author: Louis Dionne
Date: 2022-08-23T17:02:51-04:00
New Revision: 7dfcf9342b5af794aadd4ca81490090fe7ca6a45
URL:
https://github.com/llvm/llvm-project/commit/7dfcf9342b5af794aadd4ca81490090fe7ca6a45
DIFF:
https://github.com/llvm/llvm-project/commit/7dfcf9342b5af794aadd4ca81490090fe7ca6a45.diff
Author: Louis Dionne
Date: 2022-08-24T08:50:52-04:00
New Revision: 3e84cdbee467f97026f1ad421abcaf9b862c1ff4
URL:
https://github.com/llvm/llvm-project/commit/3e84cdbee467f97026f1ad421abcaf9b862c1ff4
DIFF:
https://github.com/llvm/llvm-project/commit/3e84cdbee467f97026f1ad421abcaf9b862c1ff4.diff
Author: Louis Dionne
Date: 2022-08-24T09:13:29-04:00
New Revision: b1320f7c9b907d39c8ceca9b91d66046441f1ae3
URL:
https://github.com/llvm/llvm-project/commit/b1320f7c9b907d39c8ceca9b91d66046441f1ae3
DIFF:
https://github.com/llvm/llvm-project/commit/b1320f7c9b907d39c8ceca9b91d66046441f1ae3.diff
Author: Ryan Prichard
Date: 2022-09-07T22:18:09-04:00
New Revision: 6332a00d696d37942f2743851c86f1d4493968f0
URL:
https://github.com/llvm/llvm-project/commit/6332a00d696d37942f2743851c86f1d4493968f0
DIFF:
https://github.com/llvm/llvm-project/commit/6332a00d696d37942f2743851c86f1d4493968f0.diff
Author: Louis Dionne
Date: 2022-11-16T15:25:32-05:00
New Revision: 9621b1776a1b3d16735b3c5da31585ad64a018df
URL:
https://github.com/llvm/llvm-project/commit/9621b1776a1b3d16735b3c5da31585ad64a018df
DIFF:
https://github.com/llvm/llvm-project/commit/9621b1776a1b3d16735b3c5da31585ad64a018df.diff
Author: Louis Dionne
Date: 2022-10-11T15:18:22-04:00
New Revision: f8409af354c1398ebf4ece67a315c94ba19714b5
URL:
https://github.com/llvm/llvm-project/commit/f8409af354c1398ebf4ece67a315c94ba19714b5
DIFF:
https://github.com/llvm/llvm-project/commit/f8409af354c1398ebf4ece67a315c94ba19714b5.diff
Author: Louis Dionne
Date: 2022-12-19T16:11:39-05:00
New Revision: 6540f32db09cf6b367812642fbd91d44cbb6638d
URL:
https://github.com/llvm/llvm-project/commit/6540f32db09cf6b367812642fbd91d44cbb6638d
DIFF:
https://github.com/llvm/llvm-project/commit/6540f32db09cf6b367812642fbd91d44cbb6638d.diff
Author: Louis Dionne
Date: 2022-12-20T19:56:28-05:00
New Revision: 52aab0e4b4a5d6728f4bb9c7b3340133f585fc15
URL:
https://github.com/llvm/llvm-project/commit/52aab0e4b4a5d6728f4bb9c7b3340133f585fc15
DIFF:
https://github.com/llvm/llvm-project/commit/52aab0e4b4a5d6728f4bb9c7b3340133f585fc15.diff
ldionne wrote:
I think when the @llvm/pr-subscribers-libcxx group was pinged 2 weeks ago, most
of us didn't have the right GH notifications set up yet and we didn't see it.
Looking now.
https://github.com/llvm/llvm-project/pull/65246
___
cfe-commits
ldionne wrote:
Note that you should probably rebase your patch onto `main` and force-push to
update the PR. The CI for Clang now runs on Windows from GH PRs as well (it
used not to when you submitted the patch, I think).
https://github.com/llvm/llvm-project/pull/65246
_
ldionne wrote:
Ok so after scratching my head a bit, I'm actually not certain of how to
proceed with this. I can't find a way to implement `__libcpp_datasizeof` in
libc++ that doesn't involve `offsetof`, so our only option would be to silence
the warning. We could do it like (if we end up doin
ldionne wrote:
> Thank you for your review! Here are some comments and my thoughts.
>
> > Note that you should probably rebase your patch onto main and force-push to
> > update the PR
>
> Does it mean that I can rebase and force-push since (it should be avoided in
> normal case but) this is a
https://github.com/ldionne commented:
Is there a reason why *all* configurations shouldn't be doing this?
https://github.com/llvm/llvm-project/pull/67201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@mordante I'm not certain what's going on here, I get
```
[...]/clang_modules_include.gen.py/__std_clang_module.compile.pass.mm:22:2:
error: import of module 'std' imported non C++20 importable modules
22 | @import std;
| ^
1 error generated.
```
Can you assist? It onl
ldionne wrote:
You could add it to all the `.cfg.in` files (I think we agree that it's what
makes sense in theory) and then see whether the flags change in the
configurations tested in the CI.
https://github.com/llvm/llvm-project/pull/67201
___
cfe-c
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -314,5 +317,14 @@ def getStdFlag(cfg, std):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
+name="executor",
+type=str,
+default=f"{sys.executable}
{Path(__file__).resolve().parent.parent.parent
@@ -314,5 +317,14 @@ def getStdFlag(cfg, std):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
+name="executor",
+type=str,
+default=f"{sys.executable}
{Path(__file__).resolve().parent.parent.parent
ldionne wrote:
> > @arichardson
>
> Sorry about that! It looks like the cmake file quoting needs to be updated.
> Alternatively I could revert the part of this change that deprecates the
> executor variable.
Let's not un-deprecate the executor variables -- it's really great that we're
removin
ldionne wrote:
I just want to slide in to say that I *really* like this patch from the point
of view of `std::string`'s implementation. Our `__default_init()` method and
the `if (is_constant_evaluated())` were pretty awful, and I think it's great to
remove them.
I agree it could cause a porta
ldionne wrote:
@kasuga-fj Ok, let's take the diff I posted earlier in the comments and silence
the warning in libc++ then. Once you do that, the libc++ test suite shouldn't
fail with your patch anymore so your CI should be green. Then libc++ will be
out of your way and it's up to the Clang fol
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
This seems to be a bit stuck. I checked out the patch locally and that was
helpful to understand some of the issues. I think the final patch should be:
```
commit c667f036c4228b9cf0172c311537ab96ef61fcf5
Author: PandaNinjas
Date: Wed Sep 13 17:38:17 2023 -0700
[libc++] Pr
ldionne wrote:
This seems to be a bit stuck. I checked out the patch locally and that was
helpful to understand some of the issues. I think the final patch should be:
```
commit c667f036c4228b9cf0172c311537ab96ef61fcf5
Author: PandaNinjas
Date: Wed Sep 13 17:38:17 2023 -0700
[libc++] Pr
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/67691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/67691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/67691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,20 @@
+
+macro(serialize_lit_param param value)
+ string(APPEND SERIALIZED_LIT_PARAMS "config.${param} = ${value}\n")
ldionne wrote:
This looks reasonable, but could we avoid using the global variable
`SERIALIZED_LIT_PARAMS` here? We should thread it
ldionne wrote:
> Previous CI failures due to `offsetof` warnings have been resolved. Thank you
> for your cooperation! The current CI error (libcxx-ci Benchmark) does not
> seem to be caused by this patch (other PRs seem to be failing in the same
> one), so I'll wait until it's fixed.
The CI
Author: Reagan Bohan
Date: 2023-09-12T14:00:03-04:00
New Revision: 3f6818bf444f902a64a7604e67b92cf8c98b3f56
URL:
https://github.com/llvm/llvm-project/commit/3f6818bf444f902a64a7604e67b92cf8c98b3f56
DIFF:
https://github.com/llvm/llvm-project/commit/3f6818bf444f902a64a7604e67b92cf8c98b3f56.diff
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66265:
This shouldn't be necessary if we set the SDKROOT environment variable properly
when we run the test suite, as it is expected on Apple platforms. To set the
SDKROOT environment variable properly, we have to use
https://github.com/ldionne review_requested
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne review_requested
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne review_requested
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne labeled
https://github.com/llvm/llvm-project/pull/65517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
The direction we've been taking with these config files is to keep the base
config setup as simple as possible and avoid the proliferation of options that
are not fundamentally tied to the test suite. These kinds of options should
instead be hardcoded in a suitable `.cfg.in` fil
ldionne wrote:
Your `.cfg.in` files can use CMake variables themselves! In fact you can even
add new parameters that are only valid for that configuration of the library,
for example see
https://github.com/llvm/llvm-project/blob/main/libcxx/test/configs/apple-libc%2B%2B-backdeployment.cfg.in#L
ldionne wrote:
There shouldn't be any changes under libcxxabi. Those changes are not necessary.
https://github.com/llvm/llvm-project/pull/66295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
@@ -2,6 +2,24 @@
@SERIALIZED_LIT_PARAMS@
+# Workaround for https://gitlab.kitware.com/cmake/cmake/-/issues/19180.
+#
+# On Apple platforms, CMake resolves the compiler to the final binary using
+# `$(xcrun --find `). Unfortunately, running this compiler as-is
+# doesn't work
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/66265:
>From c325c0ba95e6d6abe7ff1a371853051bab0510af Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 13 Sep 2023 13:30:30 -0400
Subject: [PATCH] [runtimes] Remove explicit -isysroot from the testing
configurat
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/66265:
>From dfca35edb3eb6c0cd2e7d3292f854dcd9bdc6cb7 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 13 Sep 2023 13:30:30 -0400
Subject: [PATCH] [runtimes] Remove explicit -isysroot from the testing
configurat
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66509
Instead of using the BuildKite jobs, use GitHub actions to detect clang-format
violations and trailing whitespace in PRs.
Fixes #66468
>From 46330c22414ed8722e85ff349f502d4e5a1bac5d Mon Sep 17 00:00:00 2001
Fro
ldionne wrote:
@tru Sounds good! I gave you https://github.com/llvm/llvm-project/issues/66468
too.
https://github.com/llvm/llvm-project/pull/66509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
ldionne wrote:
I guess I'll close this and reopen when I have something that actually works
for handling trailing whitespace.
https://github.com/llvm/llvm-project/pull/66509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/66509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
ldionne wrote:
You're right, sorry for the noise. It supports a custom comparator, not a
custom projection. I
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
ldionne wrote:
You're right, sorry for the noise. It supports a custom comparator, not a
custom projection. I
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
ldionne wrote:
What a tricky change! The ones that seem simple are sometimes the ones that end
up being the most involved :)
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
ldionne wrote:
What a tricky change! The ones that seem simple are sometimes the ones that end
up being the most involved :)
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -108,7 +108,33 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
Author: Louis Dionne
Date: 2023-09-15T17:26:16-04:00
New Revision: a52560c8dd804104041e3cde4d9b9b89bf22f81e
URL:
https://github.com/llvm/llvm-project/commit/a52560c8dd804104041e3cde4d9b9b89bf22f81e
DIFF:
https://github.com/llvm/llvm-project/commit/a52560c8dd804104041e3cde4d9b9b89bf22f81e.diff
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66649
Fixes #66468
>From df20b6321bf9332571fc4e45ae370793876f7773 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 18 Sep 2023 09:58:29 -0400
Subject: [PATCH] [clang] Improve CI output when trailing whitespace i
ldionne wrote:
@asl This should make it a bit more explicit. I see this now when running
locally:
```
+ echo '*** Checking for trailing whitespace left in Clang source files ***'
*** Checking for trailing whitespace left in Clang source files ***
+ grep -rnI '[[:blank:]]$' clang/lib clang/inclu
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> Any idea why the CI is failing? It mentions line 86 not being constexpr
> because of assert, but it doesn't seem like I've done anything which should
> affect that...
I looked into it a bit and I think the CI is failing because of the
`std::forward` problem. The assertion on
ldionne wrote:
> Any idea why the CI is failing? It mentions line 86 not being constexpr
> because of assert, but it doesn't seem like I've done anything which should
> affect that...
I looked into it a bit and I think the CI is failing because of the
`std::forward` problem. The assertion on
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66801
This reverts commit aa60b2687, which was a temporary workaround.
This was originally https://reviews.llvm.org/D158694.
>From 7683064a0b9aa7d76cf6fcbd8c804ad897c4b625 Mon Sep 17 00:00:00 2001
From: Louis Dionne
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/66649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
501 - 600 of 749 matches
Mail list logo
