[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

2017-12-21 Thread Luis Héctor Chávez via Phabricator via cfe-commits
lhchavez added inline comments. Comment at: include/__mutex_base:65 void unlock() _NOEXCEPT _LIBCPP_THREAD_SAFETY_ANNOTATION(release_capability()); +#ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS +const mutex& operator!() const { return *this; }

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

2017-12-21 Thread Luis Héctor Chávez via Phabricator via cfe-commits
lhchavez created this revision. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. This adds clang negative thread safery assertion support to std::mutex, as documented in: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html Fixes #34951. Repository: rCXX libc++

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

2016-12-13 Thread Luis Héctor Chávez via Phabricator via cfe-commits
lhchavez marked 3 inline comments as done. lhchavez added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:870 +} +// 'default' can appear in a Java 8 declaration. Parse it as such. +break; djasper wrote: > Is there a test case that

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

2016-12-13 Thread Luis Héctor Chávez via Phabricator via cfe-commits
lhchavez updated this revision to Diff 81280. lhchavez added a comment. Addressed feedback https://reviews.llvm.org/D27377 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJava.cpp Index: unittests/Format/FormatTestJava.cpp

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

2016-12-09 Thread Luis Héctor Chávez via Phabricator via cfe-commits
lhchavez added a comment. Gentle ping? https://reviews.llvm.org/D27377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

2016-12-02 Thread Luis Héctor Chávez via Phabricator via cfe-commits
lhchavez created this revision. lhchavez added a reviewer: djasper. lhchavez added subscribers: srhines, cfe-commits. Herald added a subscriber: klimek. Java 8 introduced the use of using the 'default' keyword as modifier in interface method declarations[1]. Previously it was being parsed as