[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2519013 , @curdeius wrote: > Fixed! Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 __

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2518402 , @HazardyKnusperkeks wrote: > I did not re-accept this, because of the script change. I'm okay with it, but > I never looked really at the script. I think it should be changed afterwards > to error or warn aga

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2518259 , @curdeius wrote: > Do you have commit access? Since this is my first contribution to LLVM ever, probably not. > If no, please write your Name Surname that should be used for > the commit. Lukas Barth Than

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. If I understand the LLVM mailing list correctly, everything in the repo by the 26th will still go into LLVM 12, right? Any chance we could get this in by then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added inline comments. Comment at: clang/docs/tools/dump_format_style.py:194 +# is used. +pass elif state == State.InEnumMemberComment: curdeius wrote: > Just a nit, maybe we should have a warning at least? Not sure. After this commit

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 318193. tinloaf added a comment. Fix error introduced by rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 318182. tinloaf added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Of course there was another merge conflict in the release notes. Mental note to self: Put release note changes in separate commit. Repository: rG LLV

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf accepted this revision. tinloaf added a comment. Fixed the last spelling issues in the documentation. If the automated checks pass, this is ready for takeoff from my side. Thanks for your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 318181. tinloaf marked an inline comment as done. tinloaf added a comment. Fix spelling issues in doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files: clang/doc

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 3 inline comments as done. tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:87 - /// \brief If ``true``, aligns consecutive C/C++ preprocessor macros. + /// Styles for alignment of consecutive tokens. Tokens can be assignment sign

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2509045 , @HazardyKnusperkeks wrote: > How is it going? I would like to add some new alignment options and it would > be stupid not to do it on top of this. Sorry, much to do work-wise currently. I'll get to the last d

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 317166. tinloaf added a comment. Fixed documentation for the `AlignConsecutive*` options. I have used the suggested approach: Remove all documentation from `AlignConsecutiveStyle` and instead put the documentation of the possible values and what they do in t

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 316068. tinloaf added a comment. Fixed formatting issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Re

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2489140 , @HazardyKnusperkeks wrote: > Apart from my inline comment and the pre merge check this is superb. (I will > not accept it, until we have reached a conclusion for the documentation.) Regarding the pre-merge ch

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 315665. tinloaf added a comment. Fix merge conflict in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files: clang/docs/ClangFormatStyleOptions.rs

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 3 inline comments as done. tinloaf added a comment. This is now an all-in-one revision, including bit fields, assignments, declarations and macros. I did not reproduce the full "across empty lines, across comments, across empty lines *and* comments" test suite for all four of the

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2477860 , @HazardyKnusperkeks wrote: > In D93986#2477474 , @tinloaf wrote: > >> In D93986#2477383 , @MyDeveloperDay >> wrote: >> >>> Idea

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 315664. tinloaf marked an inline comment as done. tinloaf added a comment. - Unify the type of the options for `AlignConsecutive`{`BitFields`, `Declarations`, `Assignments`, `Macros`} - Implement across-alignment for bit fields, declarations, assignments and

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 2 inline comments as done. tinloaf added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments** (``AlignConsecutiveAssign

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:117 +/// int b= 23; +/// +/// int ccc = 23; HazardyKnusperkeks wrote: > You are adding a Tab here, or do I misinterpret this? Shouldn't that be fixed > by clang-f

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2477383 , @MyDeveloperDay wrote: > Ideally we should add a comment to the release notes, (which you could do via > a separate NFC commit if you wanted) Thank, I'll do that. But before that, I will create a revision tha

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314377. tinloaf marked 3 inline comments as done. tinloaf added a comment. Fix bogus default case reported by clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 5 inline comments as done. tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:130 +/// \endcode +ACA_AcrossComments + }; MyDeveloperDay wrote: > tinloaf wrote: > > MyDeveloperDay wrote: > > > Is there a case for

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314361. tinloaf added a comment. Address reviewer comments, noteworthy changes: - Add an option to span alignment only across comments, not across newlines - Factor out spanning options to `AlignTokens` to an enum Repository: rG LLVM Github Monorepo CH

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked an inline comment as done. tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:130 +/// \endcode +ACA_AcrossComments + }; MyDeveloperDay wrote: > Is there a case for aligning over empty lines and comments? > > `

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked an inline comment as done. tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:110 + + /// Styles for alignment of consecutive assignments + enum AlignConsecutiveAssignmentsStyle { MyDeveloperDay wrote: > you need to pr

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314293. tinloaf marked 3 inline comments as done. tinloaf added a comment. Address MyDeveloperDay's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Fil

[PATCH] D93986: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314284. tinloaf added a comment. Fix formatting issue resulting from ancient clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files: clang/docs/ClangForm

[PATCH] D93986: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. Two remarks, first: I made the change only for AlignConsecutiveAssignments, but I think it should be consistent for AlignConsecutiveMacros, AlignConsecutiveBitFields and AlignConsecutiveDeclarations, as well. If this change is accepted, I will make corresponding changes

[PATCH] D93986: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf created this revision. tinloaf added reviewers: MyDeveloperDay, djasper. tinloaf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, empty lines and comments break alignment of assignments on consecutive lines. This makes th

[PATCH] D93985: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314277. tinloaf added a comment. [format] Add the possibility to align assignments spanning empty lines or comments Currently, empty lines and comments break alignment of assignments on consecutive lines. This makes the AlignConsecutiveAssignments option an

[PATCH] D93985: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 314276. tinloaf added a comment. Fix bogus include of iostream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93985/new/ https://reviews.llvm.org/D93985 Files: clang/lib/Format/WhitespaceManager.cpp Index:

[PATCH] D93985: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. One remark: I made the change only for AlignConsecutiveAssignments, but I think it should be consistent for AlignConsecutiveMacros, AlignConsecutiveBitFields and AlignConsecutiveDeclarations, as well. If this change is accepted, I will make corresponding changes to the

[PATCH] D93985: [format] Add the possibility to align assignments spanning empty lines or comments

tinloaf created this revision. tinloaf added reviewers: MyDeveloperDay, djasper. tinloaf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, empty lines and comments break alignment of assignments on consecutive lines. This makes th