Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-05 Thread Luke Zarko via cfe-commits
zarko updated this revision to Diff 36529. zarko added a comment. Copy a dependency from a test Makefile to its CMakeLists. http://reviews.llvm.org/D13318 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/Tooling/CMakeLists.txt unittests/Tooling/ToolingTest.cpp

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-05 Thread Luke Zarko via cfe-commits
zarko added a comment. I'd tested with the Makefile; it looks like CMakeLists for the unit tests isn't linking `${LLVM_TARGETS_TO_BUILD}`. I've updated the diff. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-01 Thread Luke Zarko via cfe-commits
zarko marked an inline comment as done. zarko added a comment. Thanks; would someone with commit access land this? echristo: for a more concrete example, imagine a source code indexer that collects up dependencies. This is a Clang tool that gets called by the build system for each translation

[PATCH] D13318: Add a utility function to add target information to a command line

2015-09-30 Thread Luke Zarko via cfe-commits
zarko created this revision. zarko added reviewers: rnk, echristo, klimek. zarko added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, klimek. This diff adds `addTargetAndModeForProgramName`, a utility function that will add appropriate `-target foo` and

Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

2015-09-25 Thread Luke Zarko via cfe-commits
zarko added a comment. Great! I don't have commit access; would someone who does please land this? Repository: rL LLVM http://reviews.llvm.org/D12982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

2015-09-21 Thread Luke Zarko via cfe-commits
zarko added a comment. This should be a straight move, unless there is something I don't understand about the semantics of `llvm::InitializeAllTargets();` that would make moving it earlier in `main` a bad idea. Repository: rL LLVM http://reviews.llvm.org/D12982