pepsiman wrote:
`createReplacementsForHeaders()` is applying a cleanup without checking the
`Cleanup` flag.
But clang-apply-replacements always sets `Cleanup` to `true` anyway.
The change looks good to me, but it might be working around a bug elsewhere.
https://github.com/llvm/llvm-project/pull
Author: Malcolm Parsons
Date: 2021-05-12T17:20:15+01:00
New Revision: 5389a05836e74e3acab6dbda7e80ea43e3bc6304
URL:
https://github.com/llvm/llvm-project/commit/5389a05836e74e3acab6dbda7e80ea43e3bc6304
DIFF:
https://github.com/llvm/llvm-project/commit/5389a05836e74e3acab6dbda7e80ea43e3bc6304.dif
Author: Chris Warner
Date: 2020-12-20T11:22:41Z
New Revision: 35f2c3a8b41fd3b6ef88d013a7c3ed9478b765e4
URL:
https://github.com/llvm/llvm-project/commit/35f2c3a8b41fd3b6ef88d013a7c3ed9478b765e4
DIFF:
https://github.com/llvm/llvm-project/commit/35f2c3a8b41fd3b6ef88d013a7c3ed9478b765e4.diff
LOG:
Author: Malcolm Parsons
Date: 2020-01-14T15:19:37Z
New Revision: 9738c757bd9bc2fdca935f2b4e356f1d5e5f3682
URL:
https://github.com/llvm/llvm-project/commit/9738c757bd9bc2fdca935f2b4e356f1d5e5f3682
DIFF:
https://github.com/llvm/llvm-project/commit/9738c757bd9bc2fdca935f2b4e356f1d5e5f3682.diff
LO
Author: Malcolm Parsons
Date: 2020-01-14T10:05:12Z
New Revision: 45924eb4671692b3fa9fd52fe39c81ec0647a848
URL:
https://github.com/llvm/llvm-project/commit/45924eb4671692b3fa9fd52fe39c81ec0647a848
DIFF:
https://github.com/llvm/llvm-project/commit/45924eb4671692b3fa9fd52fe39c81ec0647a848.diff
LO
Author: malcolm.parsons
Date: Fri Feb 8 11:44:42 2019
New Revision: 353554
URL: http://llvm.org/viewvc/llvm-project?rev=353554&view=rev
Log:
[clang-tidy] Don't use assignment for value-initialized enums
Summary:
The modernize-use-default-member-init check crashes when trying to
create an assignm
Author: malcolm.parsons
Date: Mon Feb 4 13:09:31 2019
New Revision: 353092
URL: http://llvm.org/viewvc/llvm-project?rev=353092&view=rev
Log:
[clang-tidy] Handle unions with existing default-member-init
Summary:
clang-tidy's modernize-use-default-member-init was crashing for unions
with an existi
Author: malcolm.parsons
Date: Tue Nov 27 08:23:39 2018
New Revision: 347671
URL: http://llvm.org/viewvc/llvm-project?rev=347671&view=rev
Log:
[clang-tidy] Ignore bool -> single bit bitfield conversion in
readability-implicit-bool-conversion
Summary: There is no ambiguity / information loss in th
On Mon, 16 Jul 2018 at 10:57, Benjamin Kramer via cfe-commits
wrote:
> - auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; //
> expected-warning{{lambda capture 'i' is not required to be captured for this
> use}}
> + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i)
Author: malcolm.parsons
Date: Wed May 2 07:26:12 2018
New Revision: 331361
URL: http://llvm.org/viewvc/llvm-project?rev=331361&view=rev
Log:
[analyzer] Fix filename in cross-file HTML report
Summary:
The filename is currently taken from the start of the path, while the
line and column are taken
Author: malcolm.parsons
Date: Mon Apr 16 01:31:08 2018
New Revision: 330112
URL: http://llvm.org/viewvc/llvm-project?rev=330112&view=rev
Log:
Clean carriage returns from lib/ and include/. NFC.
Summary:
Clean carriage returns from lib/ and include/. NFC.
(I have to make this change locally in ord
On Sat, 14 Apr 2018, 14:16 Kim Gräsman, wrote:
> That would be a nice outcome of all the "run-tools-on-llvm" changes if any
> problems were filed as bugs on the tools. We have a number of them filed on
> iwyu, and they make for nice, concrete bugs to troubleshoot even if we
> don't always know ho
On Sat, 14 Apr 2018, 04:22 Richard Trieu via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> I was tracking down a similar issue to the lldb issue before noticing the
> change was reverted. The bad change that lead to it is:
>
> // Load pending declaration chains.
> -for (unsigned I
Author: malcolm.parsons
Date: Thu Apr 12 07:48:48 2018
New Revision: 329914
URL: http://llvm.org/viewvc/llvm-project?rev=329914&view=rev
Log:
Diagnose cases of "return x" that should be "return std::move(x)" for efficiency
Summary:
This patch adds two new diagnostics, which are off by default:
*
Author: malcolm.parsons
Date: Wed Apr 11 07:39:17 2018
New Revision: 329813
URL: http://llvm.org/viewvc/llvm-project?rev=329813&view=rev
Log:
[clang-apply-replacements] Convert tooling::Replacements to
tooling::AtomicChange for conflict resolving of changes, code cleanup, and code
formatting.
S
Author: malcolm.parsons
Date: Wed Jan 24 02:26:09 2018
New Revision: 323316
URL: http://llvm.org/viewvc/llvm-project?rev=323316&view=rev
Log:
Fix typos of occurred and occurrence
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cfe/trunk/include/clang/Analysis/CloneDetection.h
cfe
Author: malcolm.parsons
Date: Tue Jan 23 09:13:57 2018
New Revision: 323227
URL: http://llvm.org/viewvc/llvm-project?rev=323227&view=rev
Log:
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if
using C++2a
Summary:
C++2a allows bitfields to have default member initializers
Author: malcolm.parsons
Date: Tue Jan 23 07:32:42 2018
New Revision: 323208
URL: http://llvm.org/viewvc/llvm-project?rev=323208&view=rev
Log:
[clang-tidy] Handle bitfields in modernize-use-default-member-init if using
C++2a
Summary:
C++2a allows bitfields to have default member initializers.
Add
Author: malcolm.parsons
Date: Mon Dec 11 10:00:36 2017
New Revision: 320396
URL: http://llvm.org/viewvc/llvm-project?rev=320396&view=rev
Log:
[Sema] Fix crash in unused-lambda-capture warning for VLAs
Summary:
Clang was crashing when diagnosing an unused-lambda-capture for a VLA because
From.getV
Author: malcolm.parsons
Date: Tue Nov 28 06:57:47 2017
New Revision: 319174
URL: http://llvm.org/viewvc/llvm-project?rev=319174&view=rev
Log:
[clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw
Summary:
The readability-else-after-return check was not warning about
an else after
Author: malcolm.parsons
Date: Wed Nov 22 02:47:35 2017
New Revision: 318827
URL: http://llvm.org/viewvc/llvm-project?rev=318827&view=rev
Log:
[Docs] Update list of languages clang-format can format
Modified:
cfe/trunk/docs/ClangFormat.rst
Modified: cfe/trunk/docs/ClangFormat.rst
URL:
http:/
On 16 August 2017 at 02:49, Richard Smith via cfe-commits
wrote:
> + /// \brief \c true if a defaulted destructor for this class would be
> deleted.
> + bool defaultedDestructorIsDeleted() const {
> +return !data().DefaultedDestructorIsDeleted;
> + }
Is the ! intentional?
--
Malcolm Pa
Author: malcolm.parsons
Date: Tue Aug 1 02:53:55 2017
New Revision: 309667
URL: http://llvm.org/viewvc/llvm-project?rev=309667&view=rev
Log:
[ASTMatchers] Allow forField to match indirect fields.
This is needed for PR32966.
Reviewed by alexfh.
Modified:
cfe/trunk/include/clang/ASTMatchers/
Author: malcolm.parsons
Date: Tue Aug 1 02:54:05 2017
New Revision: 309668
URL: http://llvm.org/viewvc/llvm-project?rev=309668&view=rev
Log:
[clang-tidy] Handle anonymous structs/unions in member init checks.
Use getAnyMember() instead of getMember() to avoid crash on anonymous
structs/unions.
D
Author: malcolm.parsons
Date: Mon May 8 11:43:29 2017
New Revision: 302440
URL: http://llvm.org/viewvc/llvm-project?rev=302440&view=rev
Log:
[AST] Fix copy&paste error in comment. NFC.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
http://llv
On 3 March 2017 at 12:42, Piotr Padlewski via cfe-commits
wrote:
> w.emplace_back(std::make_pair(21L, 37L);
Unbalanced ().
--
Malcolm Parsons
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: malcolm.parsons
Date: Wed Mar 1 04:23:38 2017
New Revision: 296602
URL: http://llvm.org/viewvc/llvm-project?rev=296602&view=rev
Log:
[Sema] Improve side effect checking for unused-lambda-capture warning
Summary:
Don't warn about unused lambda captures that involve copying a
value of a ty
Author: malcolm.parsons
Date: Wed Feb 15 10:32:55 2017
New Revision: 295192
URL: http://llvm.org/viewvc/llvm-project?rev=295192&view=rev
Log:
[clang-tidy] Don't delay parsing of templates in test for
misc-unconventional-assign-operator
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-
Author: malcolm.parsons
Date: Wed Feb 15 08:01:41 2017
New Revision: 295176
URL: http://llvm.org/viewvc/llvm-project?rev=295176&view=rev
Log:
[clang-tidy] Don't warn about call to unresolved operator*
Summary:
The misc-unconventional-assign-operator check had a false positive
warning when the 'op
Author: malcolm.parsons
Date: Mon Jan 23 07:18:08 2017
New Revision: 292786
URL: http://llvm.org/viewvc/llvm-project?rev=292786&view=rev
Log:
[clang-tidy] Ignore implicit functions in performance-unnecessary-value-param
Summary:
The performance-unnecessary-value-param check mangled inherited
cons
On 20 January 2017 at 21:32, Nico Weber wrote:
> This warns about code like
>
> constexpr int foo = 4;
> [&foo]() { use(foo); }
>
> That's correct, but removing &foo then makes MSVC complain about this code
> like "error C3493: 'foo' cannot be implicitly captured because no default
> capture m
Author: malcolm.parsons
Date: Fri Jan 20 03:54:26 2017
New Revision: 292595
URL: http://llvm.org/viewvc/llvm-project?rev=292595&view=rev
Log:
Fix documentation typo.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trun
Author: malcolm.parsons
Date: Thu Jan 19 11:19:22 2017
New Revision: 292498
URL: http://llvm.org/viewvc/llvm-project?rev=292498&view=rev
Log:
[Sema] Reword unused lambda capture warning
Summary:
The warning doesn't know why the variable was looked up but not
odr-used, so reword it to not claim th
Author: malcolm.parsons
Date: Thu Jan 19 07:38:19 2017
New Revision: 292484
URL: http://llvm.org/viewvc/llvm-project?rev=292484&view=rev
Log:
[docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing
Summary:
Docs for clang::Decl and clang::TemplateSpecializationType have
not been generated since LLV
On 19 January 2017 at 13:16, Aaron Ballman wrote:
> I wasn't thinking about that kind of odr-unuse when reviewing your
> patch, so I am starting to think that perhaps it's not worth
> distinguishing unevaluated contexts or not in the diagnostic. :-( If
> we could do it, then great (we seem to be a
On 19 January 2017 at 12:49, Aaron Ballman wrote:
> You are correct, it is not an odr use. MSVC is wrong to require the capture.
Should the warning be rephrased?
--
Malcolm Parsons
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: malcolm.parsons
Date: Thu Jan 19 03:27:45 2017
New Revision: 292477
URL: http://llvm.org/viewvc/llvm-project?rev=292477&view=rev
Log:
[docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing
Summary:
Docs for clang::Decl and clang::TemplateSpecializationType have
not been generated since LLV
On 19 January 2017 at 03:47, Aaron Ballman wrote:
> It is not used in an unevaluated context -- that is a bug.
It is an evaluated expression, but is it odr-used?
C++14 [basic.def.odr] p3:
A variable x whose name appears as a potentially-evaluated expression
ex is odr-used by ex unless applying
Author: malcolm.parsons
Date: Fri Jan 13 13:02:50 2017
New Revision: 291941
URL: http://llvm.org/viewvc/llvm-project?rev=291941&view=rev
Log:
Remove unused lambda captures. NFC
Modified:
clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Modified: clang-tools-extra/trunk/unittes
Author: malcolm.parsons
Date: Fri Jan 13 12:56:04 2017
New Revision: 291940
URL: http://llvm.org/viewvc/llvm-project?rev=291940&view=rev
Log:
Remove unused lambda captures. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.c
Author: malcolm.parsons
Date: Fri Jan 13 12:55:32 2017
New Revision: 291939
URL: http://llvm.org/viewvc/llvm-project?rev=291939&view=rev
Log:
Remove unused lambda captures. NFC
Modified:
cfe/trunk/docs/ReleaseNotes.rst
cfe/trunk/lib/AST/CXXInheritance.cpp
cfe/trunk/lib/AST/MicrosoftMa
Author: malcolm.parsons
Date: Fri Jan 13 09:01:06 2017
New Revision: 291905
URL: http://llvm.org/viewvc/llvm-project?rev=291905&view=rev
Log:
[Sema] Add warning for unused lambda captures
Summary:
Warn when a lambda explicitly captures something that is not used in its body.
The warning is part
Author: malcolm.parsons
Date: Thu Jan 12 13:20:35 2017
New Revision: 291796
URL: http://llvm.org/viewvc/llvm-project?rev=291796&view=rev
Log:
[clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value
Summary:
rL270567 excluded trivially copyable types from being moved by
mode
Author: malcolm.parsons
Date: Thu Jan 12 10:11:28 2017
New Revision: 291771
URL: http://llvm.org/viewvc/llvm-project?rev=291771&view=rev
Log:
Tracking exception specification source locations
Summary:
We do not currently track the source locations for exception specifications such
that their sour
Author: malcolm.parsons
Date: Wed Jan 11 05:23:22 2017
New Revision: 291667
URL: http://llvm.org/viewvc/llvm-project?rev=291667&view=rev
Log:
Remove repeated word in comment (NFC)
Modified:
cfe/trunk/lib/Parse/ParseExprCXX.cpp
Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp
URL:
http://llvm.
Author: malcolm.parsons
Date: Wed Jan 4 11:33:55 2017
New Revision: 290972
URL: http://llvm.org/viewvc/llvm-project?rev=290972&view=rev
Log:
[clang-tidy] Ignore default arguments in modernize-default-member-init
Summary:
Default member initializers cannot refer to constructor parameters, but
mo
Author: malcolm.parsons
Date: Tue Jan 3 06:10:44 2017
New Revision: 290883
URL: http://llvm.org/viewvc/llvm-project?rev=290883&view=rev
Log:
[clang-tidy] Handle constructors in performance-unnecessary-value-param
Summary:
modernize-pass-by-value doesn't warn about value parameters that
cannot be
Author: malcolm.parsons
Date: Tue Dec 27 16:14:40 2016
New Revision: 290633
URL: http://llvm.org/viewvc/llvm-project?rev=290633&view=rev
Log:
[clang-tidy] Make 2 checks register matchers for C++ only.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseEqualsDeleteCheck.cpp
clang-to
Author: malcolm.parsons
Date: Tue Dec 27 16:01:37 2016
New Revision: 290630
URL: http://llvm.org/viewvc/llvm-project?rev=290630&view=rev
Log:
[clang-tidy] Replace dead link in modernize-pass-by-value doc
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-pass-by-value.rst
Mod
Author: malcolm.parsons
Date: Sat Dec 24 08:30:29 2016
New Revision: 290493
URL: http://llvm.org/viewvc/llvm-project?rev=290493&view=rev
Log:
[clang-tidy] Remove local hasInClassInitializer matcher. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
Modi
Author: malcolm.parsons
Date: Sat Dec 24 07:35:14 2016
New Revision: 290492
URL: http://llvm.org/viewvc/llvm-project?rev=290492&view=rev
Log:
[ASTMatchers] Add hasInClassInitializer traversal matcher for FieldDecl.
Summary:
I needed to know whether a FieldDecl had an in-class
initializer for D264
Author: malcolm.parsons
Date: Sat Dec 24 07:22:26 2016
New Revision: 290491
URL: http://llvm.org/viewvc/llvm-project?rev=290491&view=rev
Log:
[ASTMatchers] Fix doc for hasBitWidth
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modi
Author: malcolm.parsons
Date: Tue Dec 20 16:57:21 2016
New Revision: 290210
URL: http://llvm.org/viewvc/llvm-project?rev=290210&view=rev
Log:
Comment out char16_t and char32_t tests
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-default-member-init-assignment.cpp
clang-
On 20 December 2016 at 22:32, Aaron Ballman wrote:
> On Tue, Dec 20, 2016 at 4:26 PM, Malcolm Parsons via cfe-commits
> wrote:
>> Author: malcolm.parsons
>> Date: Tue Dec 20 15:26:07 2016
>> New Revision: 290202
>>
>> URL: http://llvm.org/viewvc/llvm-project?r
Author: malcolm.parsons
Date: Tue Dec 20 15:26:07 2016
New Revision: 290202
URL: http://llvm.org/viewvc/llvm-project?rev=290202&view=rev
Log:
[clang-tidy] Add modernize-use-default-member-init check
Summary: Fixes PR18858
Reviewers: alexfh, hokein, aaron.ballman
Subscribers: JDevlieghere, Eugen
Author: malcolm.parsons
Date: Sat Dec 17 14:23:14 2016
New Revision: 290051
URL: http://llvm.org/viewvc/llvm-project?rev=290051&view=rev
Log:
[clang-tidy] Remove duplicated check from move-constructor-init
Summary:
An addition to the move-constructor-init check was duplicating the
modernize-pass-
Author: malcolm.parsons
Date: Thu Dec 15 04:19:56 2016
New Revision: 289797
URL: http://llvm.org/viewvc/llvm-project?rev=289797&view=rev
Log:
[clang-tidy] Enhance modernize-use-auto to templated function casts
Summary:
Use auto when declaring variables that are initialized by calling a templated
Author: malcolm.parsons
Date: Tue Dec 13 02:04:11 2016
New Revision: 289524
URL: http://llvm.org/viewvc/llvm-project?rev=289524&view=rev
Log:
[clang-tidy] Add check for redundant function pointer dereferences
Reviewers: alexfh, aaron.ballman, hokein
Subscribers: mgorny, JDevlieghere, cfe-commits
Author: malcolm.parsons
Date: Thu Dec 8 05:46:22 2016
New Revision: 289042
URL: http://llvm.org/viewvc/llvm-project?rev=289042&view=rev
Log:
[ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType
Summary: Needed for https://reviews.llvm.org/D27166
Reviewers: sbenza, bkramer,
Author: malcolm.parsons
Date: Wed Dec 7 14:38:20 2016
New Revision: 288976
URL: http://llvm.org/viewvc/llvm-project?rev=288976&view=rev
Log:
[RecursiveASTVisitor] Improve post-order traversal unit test
Modified:
cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp
Modified: cfe/trunk/unittests/A
On 7 December 2016 at 17:56, Richard Smith wrote:
> On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits"
> wrote:
>
> Author: malcolm.parsons
> Date: Wed Dec 7 11:39:04 2016
> New Revision: 288923
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288923&
Author: malcolm.parsons
Date: Wed Dec 7 11:39:04 2016
New Revision: 288923
URL: http://llvm.org/viewvc/llvm-project?rev=288923&view=rev
Log:
[RecursiveASTVisitor] Fix post-order traversal of UnaryOperator
Reviewers: aaron.ballman, klimek, doug.gregor, teemperor, rsmith
Subscribers: cfe-commits
On 2 December 2016 at 17:13, Michael Sharpe via cfe-commits
wrote:
> The attached patch fixes a couple of incorrect uses of std::move as revealed
> by clang-tidy.
LGTM.
Committed as r288813.
--
Malcolm Parsons
___
cfe-commits mailing list
cfe-commits
Author: malcolm.parsons
Date: Tue Dec 6 08:49:18 2016
New Revision: 288813
URL: http://llvm.org/viewvc/llvm-project?rev=288813&view=rev
Log:
Fix two clang-tidy misc-move-forwarding-reference warnings
Patch by Michael Sharpe.
Modified:
cfe/trunk/lib/AST/Type.cpp
cfe/trunk/lib/CodeGen/CGB
On 2 December 2016 at 10:29, Mads Ravn wrote:
> alexfh suggested that fixits seemed easy to implement. I am having a few
> doubts as to how I would make fixits for case 1 & 2. How important would it
> be to implement fixits at this point?
Add a FIXME comment if they're difficult.
--
Malcolm Par
On 2 December 2016 at 09:50, Mads Ravn wrote:
>> Comment at: test/clang-tidy/misc-string-compare.cpp:9
>> + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: do not use compare to test
>> equality of strings; use the string equality operator instead
>> [misc-string-compare]
> What do you mean by this co
On 1 Dec 2016 8:37 p.m., "Mads Ravn" wrote:
> I see the idea for the fixit clearly for case 3 & 4. Just erase
.compare(str2) and replace 0 with str2. I have a quick question though:
Given the declRefExpr().bind("str2"), how do I read the name of it in
clang-tidy? Or should I just bind 0 as well an
Author: malcolm.parsons
Date: Thu Dec 1 11:38:54 2016
New Revision: 288384
URL: http://llvm.org/viewvc/llvm-project?rev=288384&view=rev
Log:
Add a blank line to make sphinx happy.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-default.rst
Modified:
clang-tools-extra
Author: malcolm.parsons
Date: Thu Dec 1 11:24:42 2016
New Revision: 288375
URL: http://llvm.org/viewvc/llvm-project?rev=288375&view=rev
Log:
[clang-tidy] Rename modernize-use-default to modernize-use-equals-default
Reviewers: angelgarcia, aaron.ballman, alexfh
Subscribers: JDevlieghere, Prazek,
On 1 December 2016 at 16:42, Mads Ravn wrote:
> I have now implemented your suggestions - all but the fixit one. If I have
> added bindings for str1 and str2 in ast matcher, how would I go about
> creating a replacement for the entire implicitCastExpr or binaryOperator? I
> can't find any example
On 30 November 2016 at 17:18, Mads Ravn wrote:
> So remove the ifStmt from the third and fourth case?
I was thinking all cases.
Can the first case be restricted to casts to bool?
If not, keep the cast to int case with an ifStmt and add a cast to bool case.
Does it matter whether the cast is impli
Author: malcolm.parsons
Date: Mon Nov 28 05:11:34 2016
New Revision: 288025
URL: http://llvm.org/viewvc/llvm-project?rev=288025&view=rev
Log:
[Sema] Set range end of constructors and destructors in template instantiations
Summary:
clang-tidy checks frequently use source ranges of functions.
The s
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26137#602591, @Alpha wrote:
> This shouldn't affect diagnostics without fixes. If there is no fix, there
> won't be anything to export, and the diagnostic just behaves normally.
That's a shame; I need a machine readable report of al
malcolm.parsons updated this revision to Diff 78867.
malcolm.parsons added a comment.
Mention in release notes.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveConstructorInitCheck.h
clang-tidy/mo
malcolm.parsons added a comment.
What happens to diagnostics without fixes? e.g. from the
readability-function-size check.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
malcolm.parsons updated this revision to Diff 78663.
malcolm.parsons added a comment.
Use llvm_unreachable.
Ignore template instantiations.
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefau
malcolm.parsons added a comment.
Does `Sema::CheckLiteralOperatorDeclaration` need to check
`StringLiteralParser::isValidUDSuffix`?
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
malcolm.parsons updated this revision to Diff 78522.
malcolm.parsons added a comment.
Add test.
https://reviews.llvm.org/D26849
Files:
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/Misc/ast-dump-decl.cpp
Index: test/Misc/ast-dump-decl.cpp
==
malcolm.parsons added a comment.
This file doesn't exist in clang.
Did you mean to report this to swift-clang?
Repository:
rL LLVM
https://reviews.llvm.org/D26847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, rsmith.
malcolm.parsons added a subscriber: cfe-commits.
clang-tidy checks frequently use source ranges of functions.
The source range of constructors and destructors in template instantiations
is currently a si
malcolm.parsons added a comment.
@mclow.lists is working on this in https://reviews.llvm.org/D26667.
The review comments from that apply here too.
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: malcolm.parsons
Date: Thu Nov 17 15:00:09 2016
New Revision: 287258
URL: http://llvm.org/viewvc/llvm-project?rev=287258&view=rev
Log:
Fixes for r287241. Use placement new. Apply clang-format.
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/lib/Sema/DeclSpec.cpp
cfe/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287241: Use unique_ptr for cached tokens for default
arguments in C++. (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26435?vs=78375&id=78380#toc
Repository:
rL LLV
Author: malcolm.parsons
Date: Thu Nov 17 11:52:58 2016
New Revision: 287241
URL: http://llvm.org/viewvc/llvm-project?rev=287241&view=rev
Log:
Use unique_ptr for cached tokens for default arguments in C++.
Summary:
This changes pointers to cached tokens for default arguments in C++ from raw
point
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
malcolm.parsons updated this revision to Diff 78363.
malcolm.parsons added a comment.
Remove doubled spaces
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
clang-ti
Author: malcolm.parsons
Date: Thu Nov 17 08:26:45 2016
New Revision: 287226
URL: http://llvm.org/viewvc/llvm-project?rev=287226&view=rev
Log:
[docs] Remove doubled spaces
Reviewers: aaron.ballman
Subscribers: nemanjai, cfe-commits
Differential Revision: https://reviews.llvm.org/D26798
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287226: [docs] Remove doubled spaces (authored by
malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26798?vs=78361&id=78362#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26798
malcolm.parsons created this revision.
malcolm.parsons added a reviewer: aaron.ballman.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
https://reviews.llvm.org/D26798
Files:
docs/ModularizeUsage.rst
docs/clang-tidy/checks/cppcoreguidelines-pro-type-cstyl
malcolm.parsons added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-default-member-init.rst:7
+This check converts a default constructor's member initializers into default
+member initializers. Other member initializers that match the default
+member initiali
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287221: [clang-tidy] Ignore template instantiations in
modernize-use-equals-delete check (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26751?vs=78202&id=78344#toc
Re
Author: malcolm.parsons
Date: Thu Nov 17 05:40:02 2016
New Revision: 287221
URL: http://llvm.org/viewvc/llvm-project?rev=287221&view=rev
Log:
[clang-tidy] Ignore template instantiations in modernize-use-equals-delete check
Summary: Template instantiations were causing misplaced fixits.
Reviewers
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:37
unless(anyOf(hasBody(stmt()), isDefaulted(), isDeleted(),
+ ast_matchers::isTemplateInstantiation(),
// Ensure that all met
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287215: [clang-tidy] Changes to modernize-use-default check
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26741?vs=78164&id=78328#toc
Repository:
rL LLVM
https://
Author: malcolm.parsons
Date: Thu Nov 17 03:14:04 2016
New Revision: 287215
URL: http://llvm.org/viewvc/llvm-project?rev=287215&view=rev
Log:
[clang-tidy] Changes to modernize-use-default check
Summary:
Warn about special member functions that only contain a comment.
Report the location of the sp
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Template instantiations were causing misplaced fixits.
https://reviews.llvm.org/D26751
Files:
clang-tidy/modernize/UseEqualsDeleteCheck.cpp
test/cl
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, Eugene.Zelenko, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Herald added subscribers: modocache, mgorny.
Fixes PR18858
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, klimek, teemperor, doug.gregor.
malcolm.parsons added a subscriber: cfe-commits.
https://reviews.llvm.org/D26742
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index:
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Warn about special member functions that only contain a comment.
Report the location of the special member function, unless it is
defined in a macro. Rep
Author: malcolm.parsons
Date: Wed Nov 16 03:51:40 2016
New Revision: 287091
URL: http://llvm.org/viewvc/llvm-project?rev=287091&view=rev
Log:
[clang-tidy] Handle template instantiations in modenize-use-default check
Summary:
Duplicate fixes were being created for explicit template instantiations
1 - 100 of 321 matches
Mail list logo
