[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ updated this revision to Diff 322445. malharJ added a comment. This update removes the dependence of (emitting) vectorize_predicate metadata on whether vectorization is disabled (via vectorize(disable) or vector_width(1)) or not. This means that vectorize_predicate loop metadata is emitt

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:88 + +#pragma clang loop vectorize_predicate(enable) vectorize_width(1) + for (int i = 0; i < Length; i++) dmgreen wrote: > Can you add another test for `#pragma clang loo

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:88 + +#pragma clang loop vectorize_predicate(enable) vectorize_width(1) + for (int i = 0; i < Length; i++) dmgreen wrote: > malharJ wrote: > > dmgreen wrote: > > > Can you

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

malharJ added a comment. I do not have commit access. Can someone with commit access please commit this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94779/new/ https://reviews.llvm.org/D94779 _

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ created this revision. Herald added a subscriber: rogfer01. malharJ requested review of this revision. Herald added subscribers: cfe-commits, vkmr. Herald added a project: clang. This ensures that the Clang loop pragma vectorize_predicate([enable|disable]) is ignored when vectorize_width(

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:102 + +// CHECK-NEXT: ![[LOOP7]] = distinct !{![[LOOP7]], [[MP]], [[GEN8]], [[GEN11:![0-9]+]], [[GEN3]]} +// CHECK-NEXT: [[GEN11]] = !{!"llvm.loop.vectorize.width", i32 4}

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added a comment. I had a look at the Clang Language Extension ... and I saw this: > Specifying a width/count of 1 disables the optimization, and is equivalent to > vectorize(disable) or interle

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added a comment. > what is the problem with the current behaviour (i.e. not ignoring/handling > it)? The current behaviour is //ignoring/not handling// the vectorize_predication pragma whenever vectorization width is non-zero. Could you kindly see the original condition I stated in my p

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ updated this revision to Diff 317345. malharJ added a comment. added tests for loop predication enabled case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94779/new/ https://reviews.llvm.org/D94779 Files: clang/lib/CodeGen/CGLoopInfo.cp

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc80c57674e4d: [Clang] Allow 'Complex float __attribute__((mode(HC)))' (authored by jolanta.jensen, committed by malharJ). Changed prior to commit:

[PATCH] D97993: [Driver] Suppress GCC detection under -B

malharJ added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Hi, Has anything been done to address this bug (related to COMPILER_PATH no longer being supported) ? https://bugs.llvm.org/show_bug.cgi?id=52009 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS