Re: r280409 - When we reach the end of a #include of a header of a local submodule that we

Hi Richard, I fixed a regression caused by this commit in r291628. Let me know if you see any problem! Manman > On Sep 1, 2016, at 1:15 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Thu Sep 1 15:15:25 2016 > New Revision: 280409 > > URL:

Re: Regression caused by r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

> On Dec 14, 2016, at 1:20 PM, Manman wrote: > > >> On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits >> wrote: >> >> Author: rsmith >> Date: Wed Jul 20 14:10:16 2016 >> New Revision: 276159 >> >> URL:

Regression caused by r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

> On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Wed Jul 20 14:10:16 2016 > New Revision: 276159 > > URL: http://llvm.org/viewvc/llvm-project?rev=276159=rev > Log: > [modules] Don't emit initializers for VarDecls

Re: r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

> On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits > wrote: > > Author: vvassilev > Date: Wed Oct 19 06:19:30 2016 > New Revision: 284577 > > URL: http://llvm.org/viewvc/llvm-project?rev=284577=rev > Log: > [modules] Do not report missing definitions of

Re: [libcxx] r249738 - Split out of .

> On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits > wrote: > > Hi, > > On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote: >> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes >> wrote: >>>

Re: r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

gt; On Thu, Oct 13, 2016 at 11:52 AM, Manman via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Hi Richard, > > I committed a follow-up patch in r284142 to fix issues with C/ObjC. > > Let me know if you see any prob

Re: r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

Hi Richard, I committed a follow-up patch in r284142 to fix issues with C/ObjC. Let me know if you see any problem. Manman > On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Wed Jul 20 14:10:16 2016 > New Revision:

Re: r284008 - Reinstate r283887 and r283882.

> On Oct 12, 2016, at 1:39 PM, Vassil Vassilev wrote: > > Hi Manman, > On 12/10/16 20:28, Manman wrote: >> Hi Vassil, >> >> Any change between this commit and “r283887 + r283882”? > The only extra change is in: > > + bool isThisDeclarationADemotedDefinition() const {

Re: r284008 - Reinstate r283887 and r283882.

Hi Vassil, Any change between this commit and “r283887 + r283882”? And what was the issue that caused the revert? Thanks, Manman > On Oct 12, 2016, at 4:57 AM, Vassil Vassilev via cfe-commits > wrote: > > Author: vvassilev > Date: Wed Oct 12 06:57:08 2016 > New

Re: Modules: Suggestion on how to fix a regression caused by r259901

Hi Richard, Any suggestion on this? Thanks, Manman > On Sep 7, 2016, at 12:40 PM, Manman wrote: > > Hi Richard, > > We noticed a regression for this simple testing case: > rm -rf tmp3 > clang -cc1 -fimplicit-module-maps -x objective-c -fmodules > -fmodules-cache-path=tmp3

Re: Submodule semantics with macro guard

by c.h is not correct? It is guarded by a macro, so if we are not using modules, it will work. Also I thought the definition of a non-modular header is that it is not mapped to any module. Is that my misunderstanding? Is there a formal definition for modular header? Thanks, Manman > >> On 19

Submodule semantics with macro guard

Hi Richard & Ben, Given a simple testing case, where we have two submodules X.A (A.h) and X.B (B.h, it includes C.h, and C.h is guarded with a macro), when we import X.A and then textually include a header C.h, we get redefinition error. This is because the macro guard is owned by module X.B

Re: r281351 - Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.

I checked in r281404. Hopefully it will fix the issue. Let me know if it does not. Thanks, Manman > On Sep 13, 2016, at 3:03 PM, Artem Belevich via cfe-commits > wrote: > > Manman, > > FYI, It appears that some of your ObjC commits today trigger asan error. >

Modules: Suggestion on how to fix a regression caused by r259901

Hi Richard, We noticed a regression for this simple testing case: rm -rf tmp3 clang -cc1 -fimplicit-module-maps -x objective-c -fmodules -fmodules-cache-path=tmp3 -emit-obj standalone.c -I Inputs/ —> standalone.c:4:6: error: variable has incomplete type 'void' void foo __P(()); ^

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

> On May 23, 2016, at 8:15 PM, Bob Wilson wrote: > > Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for > Objective-C properties marked with the IBOutlet attribute. Those properties > are supposed to be weak but they are only accessed from the main