klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. I also think it makes the code nicer by breaking out the right functions.
Thanks!
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
https://reviews.llvm.org/D27447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76
+
+ Clang Format Document
+
hans wrote:
> amaiorano wrote:
> > hans wrote:
> > > I think File would be better than Document when referring to
klimek added a reviewer: djasper.
klimek added a comment.
Adding djasper, who had brought forward the idea.
https://reviews.llvm.org/D27440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. We can always add more intricate ways later on.
Repository:
rL LLVM
https://reviews.llvm.org/D27140
___
cfe-commits mailing list
klimek added a comment.
Pondering this a bit - one question is whether we should make clang-format not
return 0 if we pass -fallback-style=none (it already has this option) and we
can't figure out a style. What do you think?
https://reviews.llvm.org/D27440
klimek added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5034
+/// \c substTemplateTypeParmType(hasReplacementType(type())) matches int
+AST_MATCHER_P(SubstTemplateTypeParmType, hasReplacementType,
+ ast_matchers::internal::Matcher,
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288366: Adds hasUnqualifiedDesugaredType to allow matching
through type sugar. (authored by klimek).
Changed prior to commit:
https://reviews.llvm.org/D27207?vs=79891=79912#toc
Repository:
rL LLVM
klimek added a comment.
I added a test for multi-stage desugaring. Generally, we want to model Clang's
AST where it makes sense. The AST has a getUnqualifiedDesugaredType, thus the
matcher as it is is expected. We can add single step desugaring or
hasAnyDeclaration or similar things when they
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D27138#607859, @joerg wrote:
> Which struct are we talking about, `CompileCommandRef` or `CompileCommand`?
> It is a pointer in the former and a plain StringRef in
klimek updated this revision to Diff 79891.
klimek added a comment.
Add multi-level using test.
https://reviews.llvm.org/D27207
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
klimek added a comment.
hasUnqualifiedDesugaredType(hasDeclaration(
How about using hasUnqualifiedDesugaredType(recordType(hasDeclaration instead?
https://reviews.llvm.org/D27207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek added a comment.
In https://reviews.llvm.org/D27138#607786, @joerg wrote:
> It's not the directory, but the output file. That's optional since it is a
> new addition and I don't want to invalidate all existing JSON databases.
It seems like we're talking past each other. I'm not
klimek added a comment.
> for these cases the
> original Breakable{Line,Block}Comment still breaks the long lines.
Do you intend for this to continue to be the case?
https://reviews.llvm.org/D27211
___
cfe-commits mailing list
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
joerg wrote:
> klimek wrote:
> > joerg wrote:
> >
klimek added a comment.
Can you add a test to ASTMatchersNodeTests.cpp? Otherwise LG for the matcher
parts.
https://reviews.llvm.org/D27181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek added reviewers: bkramer, akyrtzi.
klimek added a comment.
Adding some folks. One question is whether we can use the additional output
stuff doug added at some point for this.
https://reviews.llvm.org/D27140
___
cfe-commits mailing list
klimek created this revision.
klimek added reviewers: bkramer, lukasza.
klimek added a subscriber: cfe-commits.
https://reviews.llvm.org/D27207
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
klimek added a comment.
In https://reviews.llvm.org/D27104#607161, @lukasza wrote:
> Forcing shallow matching means that unit test below will stop passing after
> this CL.
>
> TEST(HasDeclaration, DeepTagType) {
> std::string input =
> "class Foo {};\n"
> "using Bar =
klimek updated this revision to Diff 79530.
klimek added a comment.
Add tests, update hasDeclaration to work for ElaboratedType.
https://reviews.llvm.org/D27104
Files:
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Index:
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
joerg wrote:
> klimek wrote:
> > joerg wrote:
> >
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
joerg wrote:
> klimek wrote:
> > Optional: I'd
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
Optional: I'd probably let the nodeToCommandLine
501 - 525 of 525 matches
Mail list logo
