[PATCH] D69855: Fix llvm-namespace-comment for macro expansions

twardakm created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. twardakm edited the summary of this revision. twardakm added a project: clang-tools-extra. If a namespace is a macro name, it should be allowed to close the namespace with the same name. This co

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 228088. twardakm added a comment. Remove unnecessary line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/ https://reviews.llvm.org/D69855 Files: clang-tools-extra/clang-tidy/readability/NamespaceCo

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 230113. twardakm added a comment. Apply Aaron's comments - Fix missing namespace to macro definition instead of extension - Print macro definition also in warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked 9 inline comments as done. twardakm added a comment. Thanks for the review! @aaron.ballman take a look at new revision and let me know if something needs to be fixed. Thanks! Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:50-51

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 230285. twardakm added a comment. Fix style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/ https://reviews.llvm.org/D69855 Files: clang-tools-extra/clang-tidy/readability/NamespaceCommentCh

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked 9 inline comments as done. twardakm added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:83 +const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + PP->addPPCallbacks(std::make_unique(

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked an inline comment as done. twardakm added a comment. @aaron.ballman thanks for the review :) Can you please push the change on my behalf? I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/ https://

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm added a comment. The reason for this whole patch was a bug in clang-tidy, which caused warning in the following code: #define SOME_RANDOM_MACRO macro namespace SOME_RANDOM_MACRO { } // namespace SOME_RANDOM_MACRO and clang-tidy suggested: namespace SOME_RANDOM_MACRO {

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

twardakm updated this revision to Diff 225939. twardakm added a comment. Rebase with master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

twardakm added a comment. In D55793#1571534 , @aaron.ballman wrote: > In D55793#1535895 , @m4tx wrote: > > > @JonasToth thanks for asking! Yes, since I do not have commit access, I > > need someone to do the commi