@@ -194,9 +217,31 @@ I::~I() { call_in_dtor(); }
// CHECK-MSABI32-LABEL: define {{.*}} @"??_GI@@UAEPAXI@Z"(
// CHECK-MSABI-NOT: call{{ }}
// CHECK-MSABI: load i32
-// CHECK-MSABI: icmp eq i32 {{.*}}, 0
-// CHECK-MSABI: br i1
+// CHECK-MSABI-NEXT: and i32 %[[IMP_PARAM:.*]], 4
+/
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/11] [win][clang] Align scalar deleting destructor
@@ -1590,25 +1590,70 @@ namespace {
void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF,
Fznamznon wrote:
Added a comment.
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commit
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/10] [win][clang] Align scalar deleting destructor
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/8] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/7] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/5] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/144109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Thanks @AaronBallman , It seems -fclang-abi-compat=20 doesn't work, so first we
need https://github.com/llvm/llvm-project/pull/144109 .
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.ll
@@ -11,6 +12,7 @@ struct XMM2 : XMM1<0>, XMM1<1> {
};
// CHECK: define{{.*}} @_Z3foov({{.*}} [[ARG:%.*]]){{.*}}
+// CLANG-20: define{{.*}} <4 x double> @_Z3foov()
Fznamznon wrote:
I think this is the only test which is different between clang 20 and clang 21,
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/144109
The value was known already, but it was parsed as latest which is incorrect
because we are already doing clang 21.
>From a48dd54fb4918a89e6a98f82860332ab59be6df6 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/144068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -836,8 +836,7 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext
StmtCtx,
Diag(ExpectedLoc, diag::err_expected_after)
<< "'case'" << tok::colon
- << FixItHint::CreateInsertion(ExpectedLoc,
-tok::getTo
https://github.com/Fznamznon commented:
Can we add a test?
https://github.com/llvm/llvm-project/pull/144068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/144068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Ok, I added the release note.
> we'd use ABI version tags for it at that point.
@AaronBallman Could you please elaborate a bit more on that?
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@li
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/4] [win][clang] Align scalar deleting destructors
Fznamznon wrote:
> Was there a backport request created for this one?
No, when I applied the patch locally to release20.x branch, one of the tests
that this patch adds crashed, so probably additional fixes required to be
backported.
https://github.com/llvm/llvm-project/pull/135957
___
@@ -1589,25 +1589,74 @@ namespace {
void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF,
llvm::Value *ShouldDeleteCondition,
bool ReturnAfterDelete) {
+const CXXDestructorDecl *Dtor = cast(CGF.C
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/2] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/143546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
> I didn't add a test because this can't be reproduced yet in this repo, I
> reproduced this only in intel's fork with more SYCL support.
But that does sound specific to the downstream, right? Do we observe the issue
there because intel's fork used to add OpenCLKernelAttr impl
@@ -7179,6 +7179,12 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D,
const ParsedAttr &AL,
case ParsedAttr::AT_EnumExtensibility:
handleEnumExtensibilityAttr(S, D, AL);
break;
+ case ParsedAttr::AT_SYCLKernel:
+S.SYCL().handleKernelAttr(D, AL);
+break
@@ -1,128 +1,128 @@
// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fsycl-is-device
-disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
void bar(int &Data) {}
-// CHECK: define dso_local void @[[RAW_REF:[a-zA-Z0-9_]+]](ptr noundef nonnull
align 4 dereferenceable(4) %
+// CHEC
@@ -0,0 +1,38 @@
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify %s
+
+// Semantic tests for sycl_external attribute
+
+[[clang::sycl_external(3)]] // expected-error {{'sycl_external' attribute
takes no arguments}}
+void bar() {}
+
+[[clang::sycl_external]] // expected
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify %s
+
+// expected-warning@+1{{'sycl_external' attribute only applies to functions}}
+[[clang::sycl_external]] int a;
+
+
+// expected-warning@+2{{'sycl_external' attribute only applies to functions}}
+stru
@@ -29,21 +29,10 @@ int foo() {
}
template
-__attribute__((sycl_kernel)) void kernel_single_task(const Func &kernelFunc) {
+[[clang::sycl_external]] void kernel_single_task(const Func &kernelFunc) {
Fznamznon wrote:
I think it was meant to be a kernel, so sy
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
@@ -476,6 +476,33 @@ The SYCL kernel in the previous code sample meets these
expectations.
}];
}
+def SYCLExternalDocs : Documentation {
+ let Category = DocCatFunction;
+ let Heading = "sycl_external";
+ let Content = [{
+The ``sycl_external`` attribute (or the ``SYCL_E
@@ -476,6 +476,33 @@ The SYCL kernel in the previous code sample meets these
expectations.
}];
}
+def SYCLExternalDocs : Documentation {
+ let Category = DocCatFunction;
+ let Heading = "sycl_external";
+ let Content = [{
+The ``sycl_external`` attribute (or the ``SYCL_E
@@ -1046,6 +1046,9 @@ class DiagnosticsEngine : public
RefCountedBase {
bool EmitDiagnostic(const DiagnosticBuilder &DB, bool Force = false);
/// @}
+
+private:
+ void Report(Level DiagLevel, const Diagnostic &Info);
Fznamznon wrote:
Why not put it righ
@@ -658,13 +658,97 @@ void DiagnosticsEngine::Report(const StoredDiagnostic
&storedDiag) {
Level DiagLevel = storedDiag.getLevel();
Diagnostic Info(this, storedDiag.getLocation(), storedDiag.getID(),
DiagStorage, storedDiag.getMessage());
+ Report(DiagLe
@@ -658,13 +658,97 @@ void DiagnosticsEngine::Report(const StoredDiagnostic
&storedDiag) {
Level DiagLevel = storedDiag.getLevel();
Diagnostic Info(this, storedDiag.getLocation(), storedDiag.getID(),
DiagStorage, storedDiag.getMessage());
+ Report(DiagLe
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/143517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
That makes sense to me, but I've never touched that before, so probably makes
sense to wait for the feedback from @AaronBallman too.
https://github.com/llvm/llvm-project/pull/143517
___
cfe-comm
@@ -2885,6 +2886,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon commented:
Thank you for the fix, this overall lg. But perhaps a release note makes sense,
and I agree with @Sirraide that canonical types need to be stored into the set.
https://github.com/llvm/llvm-project/pull/143244
__
Fznamznon wrote:
ping.
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
/cherry-pick 40417915a161e87b398f1cc3e9b7c159207abd77
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon milestoned
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/141783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -359,3 +359,29 @@ struct alignment { // c17-error {{redefinition of
'alignment'}} \
c23-error {{type 'struct alignment' has a member with an
attribute which currently causes the types to be treated as though they are
incompatible}}
int x;
};
+
+//
@@ -12909,6 +12909,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) {
if (D->hasAttr())
return false;
+ if (LangOpts.SYCLIsDevice &&
+ (!D->hasAttr() ||
!D->hasAttr()))
Fznamznon wrote:
Shouldn't that be
```suggestion
if (LangOpts.SYCLI
Fznamznon wrote:
Ping.
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/Fznamznon approved this pull request.
That looks great imo
https://github.com/llvm/llvm-project/pull/141471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/140230
None
>From eeea84b4989b4497cc804f403258b986c09cf5ab Mon Sep 17 00:00:00 2001
From: Elizabeth Andrews
Date: Thu, 8 Aug 2024 18:05:48 -0700
Subject: [PATCH 1/5] [SYCL] Add support for __builtin_sycl_kernel_name
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/140230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -692,6 +692,86 @@ ExprResult Parser::ParseLambdaExpression() {
return ParseLambdaExpressionAfterIntroducer(Intro);
}
+bool Parser::IsLambdaAfterTypeCast() {
+ assert(getLangOpts().CPlusPlus && Tok.is(tok::l_square) &&
+ "Not at the start of a possible lambda expr
https://github.com/Fznamznon approved this pull request.
A couple of nits, otherwise LGTM
https://github.com/llvm/llvm-project/pull/139638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
@@ -52,7 +52,7 @@ static bool CheckWasmBuiltinArgIsInteger(Sema &S, CallExpr *E,
}
bool SemaWasm::BuiltinWasmRefNullExtern(CallExpr *TheCall) {
- if (TheCall->getNumArgs() != 0)
+ if (SemaRef.checkArgCount(TheCall, 0))
Fznamznon wrote:
```suggestion
if (S
@@ -168,7 +168,7 @@ bool Sema::checkArgCount(CallExpr *Call, unsigned
DesiredArgCount) {
Fznamznon wrote:
Maybe also assert that `ArgCount > 0`? In case `checkArgCountAtLeast` becomes
broken.
https://github.com/llvm/llvm-project/pull/139638
_
@@ -62,12 +62,8 @@ bool SemaWasm::BuiltinWasmRefNullExtern(CallExpr *TheCall) {
bool SemaWasm::BuiltinWasmRefNullFunc(CallExpr *TheCall) {
ASTContext &Context = getASTContext();
- if (TheCall->getNumArgs() != 0) {
-Diag(TheCall->getBeginLoc(), diag::err_typecheck_call_t
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/139566
While working on vector deleting destructors support (GH19772), I noticed that
MSVC produces different code in scalar deleting destructor body depending on
whether class defined its own operator delete. In MS
@@ -7220,6 +7220,17 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc,
TypeSourceInfo *TInfo,
if (auto ILE = dyn_cast(LiteralExpr))
for (unsigned i = 0, j = ILE->getNumInits(); i != j; i++) {
Expr *Init = ILE->getInit(i);
+// C99 6.5.2.5
+
@@ -7220,6 +7220,17 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc,
TypeSourceInfo *TInfo,
if (auto ILE = dyn_cast(LiteralExpr))
for (unsigned i = 0, j = ILE->getNumInits(); i != j; i++) {
Expr *Init = ILE->getInit(i);
+// C99 6.5.2.5
+
@@ -105,3 +105,11 @@ int main(int argc, char **argv) {
return (tmain(argc) + tmain(argv[0][0])); // expected-note
{{in instantiation of function template specialization 'tmain'
requested here}} expected-note {{in instantiation of function template
specialization 'tmain' re
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
That looks good to me unless @shafik has any additional concerns.
https://github.com/llvm/llvm-project/pull/137899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -231,6 +231,13 @@ namespace DeprecatedVolatile {
a = c = a;
b += a;
}
+
+ volatile struct amber jurassic();
Fznamznon wrote:
Yeah, these are what I meant. Thanks!
https://github.com/llvm/llvm-project/pull/137899
_
@@ -5056,13 +5056,13 @@ static TypeSourceInfo
*GetFullTypeForDeclarator(TypeProcessingState &state,
S.Diag(DeclType.Loc, diag::err_func_returning_qualified_void) << T;
} else
diagnoseRedundantReturnTypeQualifiers(S, T, D, chunkIndex);
-
-//
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/138516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,28 +1,23 @@
-// RUN: %clang_cc1 -fsyntax-only -verify=c,unsafe -Wdefault-const-init %s
-// RUN: %clang_cc1 -fsyntax-only -verify=c,unsafe -Wc++-compat %s
-// RUN: %clang_cc1 -fsyntax-only -verify=unsafe %s
-// RUN: %clang_cc1 -fsyntax-only -verify=c -Wdefault-const-init
-Wn
@@ -5056,13 +5056,13 @@ static TypeSourceInfo
*GetFullTypeForDeclarator(TypeProcessingState &state,
S.Diag(DeclType.Loc, diag::err_func_returning_qualified_void) << T;
} else
diagnoseRedundantReturnTypeQualifiers(S, T, D, chunkIndex);
-
-//
@@ -231,6 +231,13 @@ namespace DeprecatedVolatile {
a = c = a;
b += a;
}
+
+ volatile struct amber jurassic();
Fznamznon wrote:
As I can see, if the return type is not a struct/class, the warning is issued.
Could you please add a test case with vol
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/137899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon commented:
Thank you for the fix, could you please also add a release note?
https://github.com/llvm/llvm-project/pull/137899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/137464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/137464
None
>From e6d3f185e8e5dffa65856391e4d709c167f96805 Mon Sep 17 00:00:00 2001
From: Mariya Podchishchaeva
Date: Sat, 26 Apr 2025 18:28:44 +0200
Subject: [PATCH] [clang][NFC] Avoid a duplicate variable in SemaE
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135957
>From b194133f44768a61a7af6486dc40deae2de73f9a Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 16 Apr 2025 05:59:24 -0700
Subject: [PATCH 1/6] [clang] Implement StmtPrinter for EmbedExpr
Tr
Fznamznon wrote:
> Libcxx tests failed. I'll check them tomorrow.
IMO they fail now in all PRs
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -435,6 +435,7 @@ ExprResult Parser::createEmbedExpr() {
ExprResult Res;
ASTContext &Context = Actions.getASTContext();
SourceLocation StartLoc = ConsumeAnnotationToken();
+
Fznamznon wrote:
```suggestion
```
https://github.com/llvm/llvm-project/pull/
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135957
>From b194133f44768a61a7af6486dc40deae2de73f9a Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 16 Apr 2025 05:59:24 -0700
Subject: [PATCH 1/6] [clang] Implement StmtPrinter for EmbedExpr
Tr
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135957
>From b194133f44768a61a7af6486dc40deae2de73f9a Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 16 Apr 2025 05:59:24 -0700
Subject: [PATCH 1/2] [clang] Implement StmtPrinter for EmbedExpr
Tr
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4049,5 +4050,13 @@ void Preprocessor::HandleEmbedDirective(SourceLocation
HashLoc, Token &EmbedTok,
if (Callbacks)
Callbacks->EmbedDirective(HashLoc, Filename, isAngled, MaybeFileRef,
*Params);
- HandleEmbedDirectiveImpl(HashLoc, *Param
Fznamznon wrote:
This might also fix https://github.com/llvm/llvm-project/issues/107869 since a
similar fix was proposed earlier to fix it. I don't have any experience with
clangd to verify though.
https://github.com/llvm/llvm-project/pull/135957
__
@@ -136,3 +136,43 @@ constexpr struct HasChar c = {
c-error {{constexpr initializer evaluates to
255 which is not exactly representable in type 'signed char'}}
};
+
+#if __cplusplus
+namespace std {
+typedef decltype(sizeof(int)) size_t;
+
+tem
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/135957
Tries to avoid memory leaks caused by saving filename earlier by allocating
memory in the preprocessor.
Fixes https://github.com/llvm/llvm-project/issues/132641
>From b194133f44768a61a7af6486dc40deae2de73f9a
@@ -271,3 +271,33 @@ void operators() {
if (to_int_int) {} // expected-error {{attempt to use a deleted function:
deleted (TO, operator bool)}}
static_cast(to_int_int); // expected-error {{static_cast from 'TO' to 'bool' uses deleted function: deleted (TO, operator bool)}}
Fznamznon wrote:
@zmodem , @DKLoehr , please feel free to hit the submit button once the
pre-commit is green. The revert was not clean, so I would prefer to wait for
it. I'm feeling ill and may end up offline after some time.
https://github.com/llvm/llvm-project/pull/135611
___
@@ -271,3 +271,33 @@ void operators() {
if (to_int_int) {} // expected-error {{attempt to use a deleted function:
deleted (TO, operator bool)}}
static_cast(to_int_int); // expected-error {{static_cast from 'TO' to 'bool' uses deleted function: deleted (TO, operator bool)}}
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/135679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
The clang format concerns were in main branch before I came in, so I think they
can be ignored.
https://github.com/llvm/llvm-project/pull/135611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/135611
Finding operator delete[] is still problematic, without it the extension is a
security hazard, so reverting until the problem with operator delete[] is
figured out.
>From 460d4807104c925232def63b516853f9ee22
Fznamznon wrote:
I'm working on a revert of the extension.
https://github.com/llvm/llvm-project/pull/133950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Oh no, I didn't pick up the test
https://github.com/llvm/llvm-project/pull/135370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
I'm not sure what to say in the release note. Sorry folks, we never really
supported these but now we reject to be safe?
https://github.com/llvm/llvm-project/pull/135370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
Fznamznon wrote:
Yeah, but this is kind of expected. Otherwise it is unclear how to emit vector
deleting destructor body. Should we fallback to calling something, like MSVC
does? See
https://github.com/llvm/llvm-project/pull/135041#issuecomment-2790227622 for
example.
https://github.com/llvm
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135370
>From 49e347a73709661fcf3a4805f38cfa2d78e3a196 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 11 Apr 2025 06:46:00 -0700
Subject: [PATCH 1/4] [clang] Reject character devices in #embed for
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135370
>From 49e347a73709661fcf3a4805f38cfa2d78e3a196 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 11 Apr 2025 06:46:00 -0700
Subject: [PATCH 1/3] [clang] Reject character devices in #embed for
Fznamznon wrote:
> on Windows we could use something like COM1 on Windows.
How would that look like?
https://github.com/llvm/llvm-project/pull/135370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/Fznamznon approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/135368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 873 matches
Mail list logo
