lodato accepted this revision.
lodato added a comment.
This revision is now accepted and ready to land.
Thanks for the fix!
https://reviews.llvm.org/D26287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lodato accepted this revision.
lodato added a reviewer: lodato.
lodato added a comment.
This revision is now accepted and ready to land.
Nice feature. Thanks for the patch!
https://reviews.llvm.org/D24319
___
cfe-commits mailing list
lodato added a comment.
Could you add a note to the commit description to say that there is a backwards
incompatibility: if a filename matches a branch name or other commit-ish, then
`git clang-format ` will no longer work as expected; use `git
clang-format -- ` instead.
lodato added a comment.
Sorry for the delay - I haven't had a chance to review. I'll be sure to review
by tomorrow. Thanks for the updates!
https://reviews.llvm.org/D24319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lodato added a subscriber: lodato.
lodato added a comment.
Hi lhchavez,
This patch does not work as intended. If I understand correctly, you want to
see if a given `` has any clang-format problems. However:
1. This patch only computes `changed_lines` from `` but then runs
clang-format on the
lodato added inline comments.
Comment at: git-clang-format:124
@@ -121,3 +123,3 @@
del opts.quiet
commit, files = interpret_args(opts.args, dash_dash, opts.commit)
lodato wrote:
> This will work without `--diff` (otherwise it will try to apply changes in
lodato added a subscriber: lodato.
lodato requested changes to this revision.
lodato added a reviewer: lodato.
lodato added a comment.
This revision now requires changes to proceed.
This does not work properly because it calls `clang-format` on the files in the
working directory, even if
