Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

fowles added a subscriber: fowles. Comment at: test/clang-tidy/misc-use-after-move.cpp:158 @@ +157,3 @@ +std::move(ptr); +ptr.get(); + } would this warn on: std::unique_ptr ptr; std::move(ptr); ptr->Foo(); I would like it to since that is a likely segfa

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

fowles added a comment. LGTM, but I will wait for people who know this stuff better to sign off http://reviews.llvm.org/D20010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its

fowles accepted this revision. fowles added a comment. This revision is now accepted and ready to land. Thanks for doing this! I tried a bunch of variants and just couldn't figure it out. http://reviews.llvm.org/D18993 ___ cfe-commits mailing list

Re: [PATCH] D18608: note for top-level consts in function decls tidy

fowles marked an inline comment as done. fowles added a comment. http://reviews.llvm.org/D18608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18608: note for top-level consts in function decls tidy

fowles updated this revision to Diff 52126. fowles added a comment. - move release note to 3.9 section http://reviews.llvm.org/D18608 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ do

Re: [PATCH] D18608: note for top-level consts in function decls tidy

fowles added inline comments. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls + `_ * `re

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a comment. Helped by sbenza@ http://reviews.llvm.org/D18608 Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18608: note for top-level consts in function decls tidy

fowles created this revision. fowles added a reviewer: alexfh. fowles added a subscriber: cfe-commits. Add missing release note http://reviews.llvm.org/D18608 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a comment. that is what I was trying to do. I can't seem to make arc play nice. Repository: rL LLVM http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a subscriber: fowles. fowles added a comment. My attempts to do this end with: $ arc diff Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. SKIP STAGING Unable to determine repository for this change. Ex

Re: [PATCH] D18408: readability check for const params in declarations

fowles updated this revision to Diff 51954. fowles marked 2 inline comments as done. fowles added a comment. - review comments - rename variables and remove MSVC compat issues http://reviews.llvm.org/D18408 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp clang-tidy/readability/Avo

Re: [PATCH] D18408: readability check for const params in declarations

fowles added a comment. ping? http://reviews.llvm.org/D18408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18408: readability check for const params in declarations

fowles updated this revision to Diff 51596. fowles marked 5 inline comments as done. fowles added a comment. - review comments http://reviews.llvm.org/D18408 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp clang-tidy/readability/AvoidConstParamsInDecls.h clang-tidy/readability/C

[PATCH] D18408: readability check for const params in declarations

fowles created this revision. fowles added a reviewer: alexfh. fowles added a subscriber: cfe-commits. Adds a clang-tidy warning for top-level consts in function declarations. http://reviews.llvm.org/D18408 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp clang-tidy/readability/Avoi

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles added a comment. thank you! Repository: rL LLVM http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

fowles added a subscriber: fowles. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:8 @@ +7,3 @@ + void nonConstMethod() {} + virtual ~ExpensiveToCopyType() {} +}; you don't actually need to fill in these methods, just declare them ==

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 51289. fowles added a comment. rebased to latest. Can someone submit this for me I don't have commit bits. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitializatio

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ +20,3 @@ + +void recordFixes(const VarDecl &Var, ASTContext &Context, + DiagnosticBuilder &Diagnostic) { I am inclined to just leave it as is f

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 51215. fowles marked 2 inline comments as done. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-init

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles marked 4 inline comments as done. fowles added a comment. http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50879. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst test/clang-tidy/performa

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50878. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst test/clang-tidy/performa

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50927. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst test/clang-tidy/performa