https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From 7d221cbcf91248f44b016aea107109756fa9f785 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?=
=?UTF-8?q?an?=
Date: Sat, 6 Jul 2024 17:22:55 -0700
Subject: [
vegerot wrote:
@AaronBallman sure. Should I still use http://llvm-compile-time-tracker.com/ ,
or do I run the benchmark another way?
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
vegerot wrote:
@mordante @AaronBallman This diff is ready for review 🙂
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vegerot ready_for_review
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From 55e3359cf82d766e8b361b6f167d6cc445853eb0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?=
=?UTF-8?q?an?=
Date: Sat, 6 Jul 2024 17:22:55 -0700
Subject: [
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From 1f231975f2f6b59375bbe88241e533ec18725aaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Co
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
https://github.com/vegerot converted_to_draft
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
@@ -3921,7 +3921,7 @@ _ForwardIterator basic_regex<_CharT,
_Traits>::__parse_character_escape(
if (__hd == -1)
__throw_regex_error();
__sum = 16 * __sum + static_cast(__hd);
- // fall
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
https://github.com/vegerot edited
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
@@ -3921,7 +3921,7 @@ _ForwardIterator basic_regex<_CharT,
_Traits>::__parse_character_escape(
if (__hd == -1)
__throw_regex_error();
__sum = 16 * __sum + static_cast(__hd);
- // fall
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
vegerot wrote:
@AaronBallman I stacked this diff on top of #100821 to remove that build error.
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl
Message-ID:
In-Reply-To:
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From eb83d32dcf26cf5a8f749400beaccf6688b9107d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Co
vegerot wrote:
I'm pretty sure I enabled the warning correctly. @AaronBallman are we good to
land?
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
vegerot wrote:
> CTMark is not compiled with `-Wextra`, so we'd not get any useful data out of
> this patch. What changes does one have to do to enable
> `-Wimplicit-fallthrough` by default (not just for `-Wextra`)?
@nikic done! At
[vegerot/llvm-project/perf/add-implicit-fallthrough-to-wextr
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From 9640f00fac2be5984b6a0ee2f7f917a58f7e53d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?=
=?UTF-8?q?an?=
Date: Sat, 6 Jul 2024 17:22:55 -0700
Subject: [
vegerot wrote:
> I would put up a branch on http://llvm-compile-time-tracker.com (instructions
> in the `About` page) and see how this impacts compile times. We've always
> left diagnostics out of -Wextra that require a CFG, so getting performance
> measurements is important.
Thanks! The `Ab
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From c05d739d105b76fcf83985b20762809f6eea6f40 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?=
=?UTF-8?q?an?=
Date: Sat, 6 Jul 2024 17:22:55 -0700
Subject: [
vegerot wrote:
@AaronBallman please review
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vegerot ready_for_review
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vegerot created
https://github.com/llvm/llvm-project/pull/97926
This patch adds -Wimplicit-fallthrough to -Wextra. GCC already includes it in
-Wextra.
This patch also adds a test to check that -Wimplicit-fallthrough is included in
-Wextra.
Note: This patch may regress perf
20 matches
Mail list logo
