[PATCH] D83936: [SimplifyCFG] Do not create unneeded PR Phi in block with convergent calls

2020-07-21 Thread Max Kazantsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG360ab707127d: [SimplifyCFG] Do not create unneeded PR Phi in block with convergent calls (authored by mkazantsev). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG L

[Differential] D83936: [SimplifyCFG] Do not create unneeded PR Phi in block with convergent calls

2020-07-21 Thread Max Kazantsev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG360ab707127d: [SimplifyCFG] Do not create unneeded PR Phi in block with convergent calls (authored by mkazantsev). Herald

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

2021-01-18 Thread Max Kazantsev via Phabricator via cfe-commits
mkazantsev added a comment. This is awesome. And scary. This is scarily awesome. :) Comment at: llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp:263 const SimplifyCFGOptions &Options) { - assert((!RequireAndPreserveDomTree || - (DT && DT

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

2021-01-18 Thread Max Kazantsev via Phabricator via cfe-commits
mkazantsev added inline comments. Comment at: llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp:263 const SimplifyCFGOptions &Options) { - assert((!RequireAndPreserveDomTree || - (DT && DT->verify(DominatorTree::VerificationLevel::Full))) &

[PATCH] D139006: [UpdateTestChecks] Match define for labels

2022-12-12 Thread Max Kazantsev via Phabricator via cfe-commits
mkazantsev added a comment. So now every single test needs to be regenerated? It'll create straw diff from nowhere... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139006/new/ https://reviews.llvm.org/D139006 _