[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov added a subscriber: tstellar. maxim-kuvyrkov added a comment. @tstellar Hi Tom, This has passed buildbots, so I'll cherry-pick this to release/12.x to fix https://bugs.llvm.org/show_bug.cgi?id=49624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2049fe58903b: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2] (authored by maxim-kuvyrkov). Repository: rG LLVM Github

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov accepted this revision. maxim-kuvyrkov added a comment. This revision is now accepted and ready to land. Herald added a subscriber: mstorsjo. This was reviewed in https://reviews.llvm.org/D98493 and https://reviews.llvm.org/D98862. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov updated this revision to Diff 331849. maxim-kuvyrkov added a comment. NFC: Make clang-format happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98935/new/ https://reviews.llvm.org/D98935 Files:

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov abandoned this revision. maxim-kuvyrkov added a comment. This is now squashed into https://reviews.llvm.org/D98935 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov created this revision. maxim-kuvyrkov added reviewers: asl, phosek. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment "link.exe" is hard-coded as default linker in MSVC.cpp, so there's no way to

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov added a comment. Hi @amyk , thanks for testing -- I've updated two more places, which I missed on the first go. Would you please test the new version? Also, D98862 was reverted so you need to apply it manually. Thanks! Repository: rG LLVM

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2636616 , @phosek wrote: > They're not part of buildbot but they're not internal, you can see the log > here: >

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov updated this revision to Diff 331784. maxim-kuvyrkov added a comment. Added more fixes to OpenMP/linking.c and Driver/msvc-link.c . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 Files:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. Hi @phosek , The only upstream bot that was broken by this change was clang-ppc64le-rhel, and I have notified the bot owner of the problem and said that I'm working on this within 15 minutes of the breakage. I posted a tentative fix for the testsuite several

[PATCH] D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary

maxim-kuvyrkov closed this revision. maxim-kuvyrkov added a comment. This is merged to release/12.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98415/new/ https://reviews.llvm.org/D98415 ___

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov added a comment. @SureYeaah , does this fix your internal buildbot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 ___ cfe-commits mailing list

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov created this revision. maxim-kuvyrkov added a reviewer: asl. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://reviews.llvm.org/D98493 clang driver for *-msvc target uses linker from

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634107 , @SureYeaah wrote: > We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER > is set to ld. It would be nice to make the tests more tolerant. > > Can we revert this patch until then?

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634089 , @SureYeaah wrote: > What if CLANG_DEFAULT_LINKER=ld? @SureYeaah , then *-msvc targets will attempt to use "ld" linker as instructed. Or are you asking about something else? Repository: rG LLVM

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. This patch broke clang-ppc64le-rhel builder. The patch makes MSVC-compatible driver honour CLANG_DEFAULT_LINKER setting, which this builder sets to “lld”. Therefore there’s an expected change in the output now that CLANG_DEFAULT_LINKER can override link.exe.

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov added a comment. The patch was wrong. We use "const Arg *A" at the end of GetLinkerPath, so can't remove it. I thought I tested this, but, apparently, not. Reverted in 62948c4532d59b59f63409eae5d7f9e4990e5626

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6802fdf8871f: [NFC] Minor cleanup to use default setting of getLastArg() (authored by maxim-kuvyrkov). Repository: rG LLVM Github Monorepo

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a subscriber: tstellar. maxim-kuvyrkov added a comment. @tstellar , OK to backport to release/12.x if buildbots are happy with this? I've filed https://bugs.llvm.org/show_bug.cgi?id=49624 with background info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGace56d41aca8: [WoA][MSVC] Use default linker setting in MSVC-compatible driver (authored by maxim-kuvyrkov). Repository: rG LLVM Github Monorepo

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:582 + StringRef Linker = Args.getLastArgValue(options::OPT_fuse_ld_EQ, + CLANG_DEFAULT_LINKER); + if (Linker.empty()) asl wrote: >

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov updated this revision to Diff 330273. maxim-kuvyrkov added a comment. Fixed thinko: GetLastArg -> GetLastArgValue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 Files:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov updated this revision to Diff 330272. maxim-kuvyrkov added a comment. Added missing header to pull in definition of CLANG_DEFAULT_LINKER. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Noticed this while I was looking at linker defaults. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98494 Files:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment "link.exe" is hard-coded as default linker in MSVC.cpp, so there's no way to use LLD as default linker for MSVC driver.

[PATCH] D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary

maxim-kuvyrkov created this revision. maxim-kuvyrkov added reviewers: richard.townsend.arm, tstellar. Herald added subscribers: danielkiss, kristof.beyls. maxim-kuvyrkov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald