[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 291736. mibintc added a comment. This update uses context information from Expr->getFPFeaturesInEffect() to disable fp constant folding in ExprConstant.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/ne

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. In D69272#2271338 , @sepavloff wrote: > In D69272#2268337 , @mibintc wrote: > >> I am working on a task to ensure that clang is doing floating point constant >> folding correctly. > > Could

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. Hello, I rebased this and made a few changes here, https://reviews.llvm.org/D87528 ; I added a question about floating point constant folding in that review, I'm going to duplicate it here, My question is about constant folding. I am working on a task to ensure that cl

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc created this revision. mibintc added reviewers: sepavloff, rjmccall. Herald added a project: clang. mibintc requested review of this revision. I rebased https://reviews.llvm.org/D69272 to work on the blocking comment from @rsmith @sepavloff Is it OK if I continue work on this item? Not

[PATCH] D87049: Exploratory patch - capture DebugInfo for constexpr variables used within lambda

mibintc added a comment. In D87049#2253150 , @dblaikie wrote: > I think it'd be helpful to discuss what the DWARF does and should look like > in this case (I wonder if, maybe, the better solution is in the DWARF > consumer - to do name lookup out through

[PATCH] D87049: Exploratory patch - capture DebugInfo for constexpr variables used within lambda

mibintc created this revision. mibintc added a reviewer: debug-info. Herald added a project: clang. mibintc requested review of this revision. This is an exploratory patch, an attempt to solve bugs.llvm.org/show_bug.cgi?id=47400 That bug report shows a simple test case where the constexpr variab

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc added a comment. In D81869#2116752 , @yaxunl wrote: > Would you please add the following lit test > > F12245277: diff.pch.txt > > If you change FastMath, FiniteMathOnly and UnsafeFPMath to > COMPATIBLE_LANGOPT,

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 273133. mibintc added a comment. I decided that I shouldn't make float options that define a macro, like -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior and rounding-mode BENIGN, I modified the pch test case to test that the beni

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc added a comment. I need to make another revision that makes a couple more of the fp options, like ffp-contract, "benign" and add a test case that demonstrates fp options don't carry over from pch-create to pch-use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272808. mibintc added a comment. The difference between this patch and the earlier one today is that I modified the new test case I misunderstood why the test case was failing. The BENIGN_LANGOPT is working as desired and those pch diagnostics are no longer

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272798. mibintc added a comment. I responded to review from @riccibruno and @rjmccall : I put the dump() routines into the .cpp file and changed them to use the x-macros. I moved CXXOperatorCall.FPOptionsOverride from the Expr bits into the OperatorCall it

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc marked 6 inline comments as done. mibintc added a subscriber: yaxunl. mibintc added a comment. @rjmccall I added some inline questions and comments for you. Thanks a lot for your review. Comment at: clang/include/clang/AST/ExprCXX.h:172 + FPOptionsOverride getFPFeatu

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272536. mibintc added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. This revision rewrites FPOptionsOverride like @rjmccall suggests. There are a couple problems, i'll add inline comments in the trouble areas Repository:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 271188. mibintc added a comment. This version passes all the lit tests, i believe it's functional tho' maybe not elegant. I still need to add a test case that PCH behaves as desired, and that the floating point command line options from PCH create do not clo

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc marked an inline comment as done. mibintc added a comment. @rjmccall You suggested that the FPFeatures could be delta instead of absolute settings, I think this is approximately what you mean. This is a rough patch employing that idea, would welcome your early comments. There are 2 cla

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc created this revision. mibintc added a reviewer: rjmccall. Herald added subscribers: llvm-commits, dexonsmith. Herald added projects: clang, LLVM. mibintc marked an inline comment as done. mibintc added a comment. @rjmccall You suggested that the FPFeatures could be delta instead of absolu

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. Herald added a subscriber: sstefan1. I documented the issue reported by @yaxunl here, https://bugs.llvm.org/show_bug.cgi?id=46166, and take ownership of the bug. Thanks for the report. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

mibintc added a comment. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

This revision was automatically updated to reflect the committed changes. Closed by commit rG827be690dce1: [clang] FastMathFlags.allowContract should be initialized only from FPFeatures. (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc added a subscriber: arsenm. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); -

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc updated this revision to Diff 264241. mibintc marked an inline comment as done. mibintc added a comment. This is the same as the previous patch, except I removed the fix for pragma push-pop that John said should be committed separately Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added a subscriber: Anastasia. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6C

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added a comment. reply about the incorrect setting of 'fast' during OpenCL compilation with option -cl-fast-relaxed-math Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefau

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); }

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc created this revision. mibintc added reviewers: rjmccall, scanon. Herald added a project: clang. mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastR

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); } michele.scandale wrote: > I'm not con

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7f2db9935009: [PATCH] #pragma float_control should be permitted in namespace scope. (authored by mibintc). Repository:

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#2029821 , @plotfi wrote: > @ab @rjmccall @mibintc Posted D79730 for > consideration. > @mibintc can you produce a version of _this_ diff that works with D79730 >

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

This revision was automatically updated to reflect the committed changes. Closed by commit rG01dc694ccb86: FP LangOpts should not be dependent on CGOpt This bug was observed by Apple… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

mibintc created this revision. mibintc added reviewers: plotfi, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. This bug was observed by Apple since their compiler processes LangOpts and CGOpts in a different order Repository: rG LLVM Github Monorepo https://

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3192 + Opts.NoHonorNaNs = + Opts.FastMath || CGOpts.NoNaNsFPMath || Opts.FiniteMathOnly; + Opts.NoHonorInfs = @rjmccall I could set these by using Args.hasArg instead of C

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. @rjmccall Uncertain how to proceed, can you recommend? If I recall correctly, I added the lines in CompilerOptions because there were many failing lit tests, i could have fixed the lit fails by adding the lang options to the lit tests. (of course that change could have

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. Some inline replies/comments to @rjmccall and @plotfi Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3185 Opts.FiniteMathOnly = Args.hasArg(OPT_ffinite_math_only) || Args.hasArg(OPT_cl_finite_ma

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I will work @rjmccall comment about codegen vs langopt - can you leave it in place for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 __

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc updated this revision to Diff 263020. mibintc added a comment. I corrected the assertion error by propagating usesFPIntrin flag from the template function to the template instantiation and added a test case. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc added a comment. No this patch isn't ready yet. i see an assertion if try to instantiate a template function when the template has enabled floating point settings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79631/new/ https://reviews.llv

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I got a report that this patch was causing a problem with Windows header because #pragma float_control should be supported in namespace context. I've posted a patch for review here https://reviews.llvm.org/D79631 Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc created this revision. mibintc added reviewers: rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. I got a bug report from Intel that https://reviews.llvm.org/D72841 was causing a crash on Windows in vs2017 header in /std:c++17 mode, because #p

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5578013b199: When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures Bug… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D79510?vs=262434&id=262467#toc Repository

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc added a comment. The ISO C proposal is here http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2407.pdf but the details are in the IEEE standards documents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.llvm.org/D

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc added a comment. BTW there is a proposal http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2421.pdf at the ISO C meeting to support some new floating point pragmas including #pragma STDC FENV_ALLOW_ASSOCIATIVE_LAW on-off-switch The committee wants to see an implementation(s) to ensure th

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I posted a patch to fix the bug reported by @uabelho here https://reviews.llvm.org/D79510 @rjmccall I used check-clang and check-all on D71841 from my linux x86-64 server before submitting, and the testing was clear. Maybe your branch

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:111 PP.Diag(Tok, diag::warn_stdc_fenv_access_not_supported); + return; } Modified this to return instead of making changes which

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

mibintc created this revision. mibintc added reviewers: uabelho, rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug reported by @uabelho against reviews.llvm.org/D72841 pragma STDC FENV_ACCESS ON is ignored, but the f

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc355bec749e9: Add support for #pragma clang fp reassociate(on|off) (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://r

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#2022354 , @uabelho wrote: > It seems to be this change in SemaStmt.cpp that makes the FENV-pragma have > some effect regardless of the warning saying that the pragma doesn't have > any effect: > > index aa0d89ac09c3.

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 262217. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associati

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

mibintc added a comment. I checked with FPGA folks and confirm what @scanon says is correct, the reassoc fast math flag enables reassociation across multiple statements, so i changed the syntax to use 'fast' and 'off', and changed the documentation Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 262108. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associati

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261921. mibintc added a comment. I fixed the issues that @rjmccall mentioned. I don't yet have an answer for @scanon, need to get back to you about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc marked an inline comment as done. mibintc added a comment. A reply to @scanon Comment at: clang/docs/LanguageExtensions.rst:3182 +enabled for the translation unit with the ``-fassociative-math`` flag. +The pragma can take two values: ``on`` and ``off``. + --

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261875. mibintc retitled this revision from "Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative mat

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc marked 4 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:186 +FPM_Fast }; rjmccall wrote: > I'm not sure I think this fusion was an improvement; the net effect was to > remove a few lin

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def warn_cxx_ms_struc

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261036. mibintc added a comment. Thanks for your review @sepavloff and @erichkeane, I have responded to your feedback and reverted the name back to reassoc which is what Serge prefers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:2701 + FPOptions FPFeatures; + mibintc wrote: > erichkeane wrote: > > This type already has trailing-storage type stuff. I think in the past >

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added a comment. A couple replies to @erichkeane Comment at: clang/include/clang/AST/Expr.h:2251 + /// allocated in Trailing Storage + void setHasStoredFPFeatures(bool B) { UnaryOperatorBits.HasFPFeatures = B; } + bool hasSto

[PATCH] D78827: Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 260381. mibintc retitled this revision from "Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associa

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3197 +by the pragma behaves as though the command-line option + ``-ffp-exception-behavior=strict`` is enabled, +when ``pragma float_control(precise, off)`` is en

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc marked an inline comment as done. mibintc added a comment. added an inline comment Comment at: clang/include/clang/AST/Stmt.h:618 // Only meaningful for floating point types. -unsigned FPFeatures : 8; +unsigned FPFeatures : 14; }; This c

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. noted bug in an inline comment. i will upload a fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 ___ cfe-commits mailing list cfe-co

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc created this revision. mibintc added reviewers: rjmccall, sepavloff, andrew.w.kaylor. Herald added a project: clang. mibintc marked an inline comment as done. mibintc added a comment. added an inline comment Comment at: clang/include/clang/AST/Stmt.h:618 // Only me

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. added a couple inline explanatory comments Comment at: clang/include/clang/Basic/LangOptions.h:307 + bool denormalIsIEEE = false; + I added this boolean as part of validating the correctness

[PATCH] D78305: [NFC] Rename Sema.FPFeatures to CurFPFeatures and accessor to getCurFPFeatures

mibintc created this revision. Herald added a project: clang. Companion patch to reviews.llvm.org/D76384 this patch renames 2 identifiers Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78305 Files: clang/include/clang/Sema/Sema.h clang/li

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. I also added this patch which is a companion to this. commit 8812b0cc5cc09f350d8e89bff99f185c5e1a5d4d Author: Melanie Blower Date: Thu Apr 16 08:45:26 2020 -0700 [NFC] Rename Sema.FPFeatures to Cu

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1986525 , @mibintc wrote: > @rjmccall Can you check the patch added last night here, commit > 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf > > Author: B

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added a subscriber: martong. mibintc added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6821 + E->getFPFeatures(Importer.getFromContext()), + importChecked(Err, ToComputationLHSType), + importChecked(E

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. @rjmccall Can you check the patch added last night here, commit 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf Author: Benjamin Kramer Date: Thu Apr 16 11:45:02 2020 +0200 LangOptions cannot depend on

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba4e3a4598b: Move BinaryOperators.FPOptions to trailing storage (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://rev

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > I *would* like an NFC patch first that renames `FPFeatures` to something like > `CurFPFeatures` in order to more clearly distinguish it from `FPOptions` in > Sema code, though. That should

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > In D76384#1984498 , @mibintc wrote: > > > Responding to @rjmccall 's review. John, after this is approved I want to > > proceed with pragma float_con

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257789. mibintc added a comment. Responding to @rjmccall 's review. John, after this is approved I want to proceed with pragma float_control as proposed in D72841 . Can you recommend an approach, do you think I will need to

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257704. mibintc added a comment. Lost power in Monday's storm, back online today. I made the changes requested by @rjmccall. Look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. Adding an inline reply for John. rebased the patch, also re-applied clang-format. What do you think? Comment at: clang/lib/Analysis/BodyFarm.cpp:120 +VK_RValue, OK_Ordinary, Sou

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257055. mibintc added a comment. Responded to @rjmccall 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 256998. mibintc added a comment. I made the changes requested by @rjmccall ; I also used clang-format on the tip. check-clang is passing. Look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ http

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 256648. mibintc added a comment. I finally decided that combining BinaryOperator and CompoundAssignOperator was too difficult, this patch uses the trailing object approach similar to that used in CallExpr. @rjmccall thank you once again for all your reviews

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. It seems like the macro's in StmtVisitor.h only work if CAO and BinaryOperator are separate classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 _

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. If I change StmtVisitor to send compound assignment opcodes to BinaryOperator, then 12 clang LIT tests fail, all related to compound assignment mishandling, i.e. this patch - a/clang/include/clang/AST/StmtVisitor.h +++ b/clang/include/clang/AST/StmtVisitor.h @@ -143,7

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 255301. mibintc added a comment. I beleive this patch responds to all @rjmccall 's review comments, except I don't know how to program a solution to his StmtVisitor remark. I'll add more info about that. This patch optionally allocates the trailing storage

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 253983. mibintc added a comment. Here's another revision, I believe this handles all of @rjmccall 's requests. Thank you, John, for your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https:

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. On my RHEL8 system building Debug clang;clang-tools-extra, check-all is passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 ___ cf

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 253341. mibintc marked 12 inline comments as done. mibintc added a comment. @rjmccall Many thanks for your code review. Please take a look at this when you get a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added a comment. I added some inline replies to John. I'm not certain I have everything yet exactly the way he wants it. Comment at: clang/include/clang/AST/Expr.h:2573 + FPOptions FPFeatures; + rjmccall wr

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:3465 +SubExprs[RHS] = rhs; +hasFPFeatures = true; +isCompoundAssign = 1; rjmccall wrote: > Okay, so this is *always* adding trailing st

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. I don't see those Harbormaster fails, using trunk and RHEL8 on architecture x86_64, Debug build of clang;clang-tools-extra and check-all. I ran all the failed lit tests separately and each passed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 252469. mibintc added a comment. I think this addresses all the feedback from @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1934785 , @rjmccall wrote: > Let's make this patch be purely a representation change. I wouldn't expect > *any* test changes from that; if there are, we should understand why. You > can then add the stuff about tracki

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251746. mibintc added a comment. This revision fixes the clang-tidy,clang-format and removes the redundant accessors. Ready for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://rev

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. In D76384#1929774 , @mibintc wrote: > There's a bug in this patch that i haven't solved yet. I think it's just 1 > bug. The bug is that the AST statement visitor is going to the "fallback"

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251699. mibintc retitled this revision from "Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary" to "Move FPFeatures from BinaryOperator bitfields to Trailing storage". mibintc added a comment. This revision has been rebased, the

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary

mibintc created this revision. mibintc added reviewers: rjmccall, sepavloff. Herald added subscribers: martong, jfb, arphaman. Herald added a reviewer: shafik. Herald added a project: clang. mibintc added a comment. There's a bug in this patch that i haven't solved yet. I think it's just 1 bug. T

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary

mibintc added a comment. There's a bug in this patch that i haven't solved yet. I think it's just 1 bug. The bug is that the AST statement visitor is going to the "fallback" instead of the right destination when walking CompoundAssignmentOperator. This patch collapses CompoundAssignmentOperato

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. @David.Bolvansky told me “https://lnt.llvm.org/ -> Test suite nts -> watch for > LNT-Broadwell-AVX2-O3__clang_PROD__x86_64:1364” The fails were seen on aarch too and a couple other arch. AFAIK the old results are no longer availble. i scraped the list of fails, pastin

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. This patch, which hasn't been committed, contains modifications to the UserManual with many details concerning 'floating point semantic modes" and the relation to floating point command line options. This is from a discussion that @andrew.w.kaylor initiated on the discu

<    1   2   3   4   5   >