[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/155485 >From 4d47b8bdf579de65eb69c69381c98c85e7f5a8e5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/3] [clang][Mangle] Inject structor type into mangled name whe

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/155485 >From 4d47b8bdf579de65eb69c69381c98c85e7f5a8e5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/2] [clang][Mangle] Inject structor type into mangled name whe

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Michael Buch via cfe-commits
Michael137 wrote: > > We didn't expect the debug info to increase that much based on the [#145967 > > (comment)](https://github.com/llvm/llvm-project/pull/145967#issuecomment-3099264478). > > Are they using some variant of -fno-sanitize-merge by any chance? > > Typically in optimized builds th

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-26 Thread Michael Buch via cfe-commits
Michael137 wrote: @AaronBallman I *think* you looked at this already in https://github.com/llvm/llvm-project/pull/149827, but thought it's best I split this out since it's sufficiently strange behaviour to warrant its own commit. https://github.com/llvm/llvm-project/pull/155485 ___

[clang] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/155485 Part of https://github.com/llvm/llvm-project/pull/149827 This patch adds special handling for `AsmLabel`s created by LLDB. LLDB uses `AsmLabel`s to encode information about a function declaration to make it

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From a4ec01a37825ac1a2fd910ad1357b7bbe403046e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/10] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Michael Buch via cfe-commits
Michael137 wrote: uhm i'll have a more detailed look at the motivation for this but i added this specifically for better debugging experience. I'd be surprised if this didnt regress anything in LLDB https://github.com/llvm/llvm-project/pull/155120 __

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-22 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-22 Thread Michael Buch via cfe-commits
Michael137 wrote: Rebased the PR on top of the LLVM/Clang changes that are in-review in separate PRs. Cleaned up the commits. The LLDB changes are all in the latest one https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenObjCXX to DebugInfo directory (PR #154912)

2025-08-22 Thread Michael Buch via cfe-commits
Michael137 wrote: This would conclude moving all the debug-info tests. Might've missed a couple here and there, but the vast majority should be in `clang/test/DebugInfo` now. https://github.com/llvm/llvm-project/pull/154912 ___ cfe-commits mailing lis

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenObjCXX to DebugInfo directory (PR #154912)

2025-08-22 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154912 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only the

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/10] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/11] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenObjC to DebugInfo directory (PR #154781)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154781 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only th

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/11] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/10] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/9] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] Fix scope of typedefs present inside a template class (PR #146729)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -debug-info-kind=standalone -o - %s | FileCheck %s Michael137 wrote: You'll have to rebase the PR to get the directory https://github.com/llvm/llvm-project/pull/146729 ___

[clang] Fix scope of typedefs present inside a template class (PR #146729)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -debug-info-kind=standalone -o - %s | FileCheck %s Michael137 wrote: Could you move this test into the recently added `clang/test/DebugInfo/CXX` directory? https://github.com/llv

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/154538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From ff0b6ac2d035ea3abb8506c02b92e07a17788142 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/8] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -125,8 +125,11 @@ DEBUGOPT(DebugNameTable, 2, 0, Compatible) /// Whether to use DWARF base address specifiers in .debug_ranges. DEBUGOPT(DebugRangesBaseAddress, 1, 0, Compatible) +/// Whether to add linkage names to constructor/destructor declarations. +DEBUGOPT(DebugStruct

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -4753,6 +4753,15 @@ def gembed_source : Flag<["-"], "gembed-source">, Group, def gno_embed_source : Flag<["-"], "gno-embed-source">, Group, Flags<[NoXarchOption]>, HelpText<"Restore the default behavior of not embedding source text in DWARF debug sections">; +defm

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/7] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
@@ -125,8 +125,11 @@ DEBUGOPT(DebugNameTable, 2, 0, Compatible) /// Whether to use DWARF base address specifiers in .debug_ranges. DEBUGOPT(DebugRangesBaseAddress, 1, 0, Compatible) +/// Whether to add linkage names to constructor/destructor declarations. +DEBUGOPT(DebugStruct

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: > Even a 3-4% increase in binary size is going to cause serious problems for us > at Google. Is there any way that this work could be guarded by a flag, so > that we can turn it off until we find a way to work around the problems it > will cause for us? Yup I put this behind

[clang] [llvm] [DO-NOT-MERGE] Add unified mangled name to structor declarations in DWARF (PR #153369)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: Closing in favour of https://github.com/llvm/llvm-project/pull/154538 https://github.com/llvm/llvm-project/pull/153369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DO-NOT-MERGE] Add unified mangled name to structor declarations in DWARF (PR #153369)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/153369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/3] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: Test failure is an XPASS in `TestExprDefinitionInDylib` because the LLDB `AsmLabel` now has a mangled name in it and the lookup by mangled name succeeds. Though it's technically not correct because we're not guaranteed to pick the right constructor variant (we probably just p

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/2] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154538 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only th

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: Here is the debug-info increase when I run bloaty on all the Clang/LLDB/LLVM object files: ``` $ bloaty `find builds-lldb/with-patch/ -name '*.o'` -- `find builds-lldb/no-patch/ -name '*.o'` FILE SIZEVM SIZE -- -- +15% +207Mi [ =

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/6] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/6] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/4] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
Michael137 wrote: Removed the `debug-*` prefix from the tests where it made sense https://github.com/llvm/llvm-project/pull/154311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154311 >From 0831825c1e1708926fcb803fa0c3e14db7943859 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 19 Aug 2025 11:37:58 +0100 Subject: [PATCH 1/4] [clang][test][DebugInfo] Move debug-info tests from CodeG

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
Michael137 wrote: > Any chance of stripping the debug/debug-info prefixes from the file names, > now that they'll b ein a DebugInfo directory? I did for most of them :) Let me check if there are any left https://github.com/llvm/llvm-project/pull/154311

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154311 >From 0831825c1e1708926fcb803fa0c3e14db7943859 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 19 Aug 2025 11:37:58 +0100 Subject: [PATCH 1/3] [clang][test][DebugInfo] Move debug-info tests from CodeG

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154311 >From 0831825c1e1708926fcb803fa0c3e14db7943859 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 19 Aug 2025 11:37:58 +0100 Subject: [PATCH 1/2] [clang][test][DebugInfo] Move debug-info tests from CodeG

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154311 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only th

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/153637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/153637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 approved this pull request. I run into this stepping behaviour once in a while. Happy to see it get fixed Given what @rjmccall, if we don't know of any sub-expressions that could cause this logic to fail, then happy to keep it as proposed. You might be able to use

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-18 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154142 Depends on https://github.com/llvm/llvm-project/pull/154137 This patch is motivated by https://github.com/llvm/llvm-project/pull/149827, where we plan on using mangled names on structor declarations to find

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-18 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/3] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-18 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-18 Thread Michael Buch via cfe-commits
Michael137 wrote: I provided some debug-info size numbers in https://github.com/llvm/llvm-project/pull/149827 but I'll regenerate them with this PR because the implementation changed slightly. https://github.com/llvm/llvm-project/pull/154142 ___ cfe-

[clang] [lldb] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154123)

2025-08-18 Thread Michael Buch via cfe-commits
Michael137 wrote: Also, please split out the clang change into a separate PR. The clang maintainers can comment on whether that's a useful thing to have in place https://github.com/llvm/llvm-project/pull/154123 ___ cfe-commits mailing list cfe-commits

[clang] [lldb] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154123)

2025-08-18 Thread Michael Buch via cfe-commits
Michael137 wrote: Hmm yea guarding against incorrect DWARF has been mostly best effort. Can you provide a test-case for this? https://github.com/llvm/llvm-project/pull/154123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-15 Thread Michael Buch via cfe-commits
Michael137 wrote: > > Not sure where we go from here then if this is a blocker. > > It's definitely a "problem", but I'm not sure if it's a "blocker". We had > some discussions about what we could do to absorb that cost, but it's not > trivial and it's getting kind of over my head. The thing i

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-14 Thread Michael Buch via cfe-commits
Michael137 wrote: Latest commit has the changes that make use of the unified structor mangling to do the cross-module lookup. Still not the prettiest because it relies on the `ManglingSubstitutor`, but it makes the cross-module case work pretty seamlessly. And from digging around, it looks li

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-14 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From c094d29dd10161d62131a1de15562ce6024d5e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 01/10] [clang][Mangle] Inject structor type into mangled name w

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From c094d29dd10161d62131a1de15562ce6024d5e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/8] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From c094d29dd10161d62131a1de15562ce6024d5e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/8] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
Michael137 wrote: @labath Thanks for the reviews so far. The latest commit contains a prototype of adding the GCC-style unified mangled name to constructor/destructor declarations. Turns out this wasn't too hard and actually solves all the issues we talked about pretty nicely. Mainly needed to

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From c094d29dd10161d62131a1de15562ce6024d5e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/8] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From c094d29dd10161d62131a1de15562ce6024d5e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/8] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From c094d29dd10161d62131a1de15562ce6024d5e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/8] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 0efab8b369c3938d6b3f441060c5df5f4b9ba739 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/8] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
@@ -2482,6 +2485,134 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +static int ClangToItaniumCtorKind(clang::CXXCtorType kind) { + switch (kind) { + case clang::CXXCtorType::Ctor_Complete: +return 1; + case clang::CXXCtorType::Cto

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 0efab8b369c3938d6b3f441060c5df5f4b9ba739 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/7] [clang][Mangle] Inject structor type into mangled name whe

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
@@ -2482,6 +2485,134 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +static int ClangToItaniumCtorKind(clang::CXXCtorType kind) { + switch (kind) { + case clang::CXXCtorType::Ctor_Complete: +return 1; + case clang::CXXCtorType::Cto

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/8] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-07 Thread Michael Buch via cfe-commits
@@ -2482,6 +2485,134 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +static int ClangToItaniumCtorKind(clang::CXXCtorType kind) { + switch (kind) { + case clang::CXXCtorType::Ctor_Complete: +return 1; + case clang::CXXCtorType::Cto

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
@@ -2482,6 +2485,134 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +static int ClangToItaniumCtorKind(clang::CXXCtorType kind) { + switch (kind) { + case clang::CXXCtorType::Ctor_Complete: +return 1; + case clang::CXXCtorType::Cto

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-06 Thread Michael Buch via cfe-commits
@@ -2482,6 +2485,134 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +static int ClangToItaniumCtorKind(clang::CXXCtorType kind) { + switch (kind) { + case clang::CXXCtorType::Ctor_Complete: +return 1; + case clang::CXXCtorType::Cto

[clang] Fix scope of typedefs present inside a template class (PR #146729)

2025-08-06 Thread Michael Buch via cfe-commits
@@ -4189,8 +4189,13 @@ llvm::DICompositeType *CGDebugInfo::CreateLimitedType(const RecordType *Ty) { llvm::MDNode::replaceWithDistinct(llvm::TempDICompositeType(RealDecl)); break; } - - RegionMap[Ty->getDecl()].reset(RealDecl); + if (auto *CTSD = dyn_cast(Ty->g

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-05 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [lldb] [clang][Attr] Remove 'literal label' form of AsmLabelAttr (PR #151858)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/151858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
Michael137 wrote: > Clang bits LGTM Sorry for the back and forth but I had some of the Clang changes not split into separate commits. Not sure if you looked at the entire diff or just the Clang commits, but I split out one more commit just now. https://github.com/llvm/llvm-project/pull/149827

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
Michael137 wrote: CC @AaronBallman for the Clang side of this https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   >