[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5da7f30f24c4: [AIX][Clang][K] Create `-K` Option for AIX. (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520502. francii added a comment. Remove leftover marker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520455. francii added a comment. Don't claim `-k` when checking target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 511431. francii added a comment. Add unsupported target test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td cla

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 511208. francii added a comment. Add -c test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii added a comment. In D146399#4243803 , @hubert.reinterpretcast wrote: > @francii, what happens when `-K` is used on a pure-compile (`-c`) invocation? > Do we get an "unused" message? Should we be testing that? > I think we should be testing the d

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 508709. francii added a comment. Remove `NoArgumentUnused`, claim -K when checking target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clan

[PATCH] D146578: [AIX][r] Do not call AddFilePathLibArgs with -r

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc04557d71c: [AIX][r] Do not call AddFilePathLibArgs with -r (authored by francii). Repository: rG LLVM Github Monorep

[PATCH] D146578: [AIX][r] Do not call AddFilePathLibArgs with -r

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We do not want to add file path lib args when -r is specified. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D146443: [AIX] Consolidate Crt0Basename logic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4c483a046d2f: [AIX] Consolidate Crt0Basename logic (authored by francii). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests

francii closed this revision. francii added a comment. Closing as this revision has landed https://reviews.llvm.org/rGe07a7040d9c6dbdd71e55d1153bfe1357079e511 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137372/new/ https://reviews.llvm.org/D1373

[PATCH] D137373: [Test][[AIX][p] Add 64-bit linker invocation tests

francii closed this revision. francii added a comment. Closing as this revision has landed https://reviews.llvm.org/rGdc9846ce988b9ddfcbc42cd462d5d94b634b3161 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137373/new/ https://reviews.llvm.org/D1373

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii closed this revision. francii added a comment. Closing as this revision has landed https://reviews.llvm.org/rG0fae851824bc1b64a727aeb331b7a0787599bd1f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D13737

[PATCH] D146443: [AIX] Consolidate Crt0Basename logic

francii updated this revision to Diff 506684. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146443/new/ https://reviews.llvm.org/D146443 Files: clang/lib/Driver/ToolChains/AIX.cpp Index: clang/lib/Driver/ToolCha

[PATCH] D146443: [AIX] Consolidate Crt0Basename logic

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. when certain flags are specified, the Crt0 object files are not linked. However, the logic for determining which fil

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG5259da75b935: [AIX][Clang] Respect -r when invoking the linker (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://revi

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506580. francii added a comment. Clean up test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 506577. francii added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506575. francii added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolC

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506447. francii added a comment. nit: spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolCh

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. `-K` is a linker option on AIX, that is used to align the header, text, data, and loader sections of the output fil

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 506439. francii added a comment. Allow user-specified -L and -l options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505691. francii added a comment. Add missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505689. francii added a comment. Add missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505657. francii added a comment. Herald added a subscriber: jplehr. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac1d143b0ef9: [Clang][AIX][p] Manually Claim -p in front end (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505653. francii added a comment. Rebase for push Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolC

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505602. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505601. francii added a comment. Don't claim when checking for object file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505560. francii added a comment. Fix segfault Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChai

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505243. francii added a comment. Wildcard check for `-l`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Dri

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505221. francii added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/Tool

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

francii updated this revision to Diff 505186. francii added a comment. Make `-p` a CC1 option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D146073: Revert "Revert "[Clang][AIX][p] Manually Claim -p in front end""

francii updated this revision to Diff 505179. francii added a comment. Update message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146073/new/ https://reviews.llvm.org/D146073 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Tool

[PATCH] D146073: Revert "Revert "[Clang][AIX][p] Manually Claim -p in front end""

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This reverts commit 7488dd25e1613894d79d69f153469545b9bf660a

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504884. francii added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, ormris. Update check in AIX.cpp, add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii added a comment. In D145899#4190055 , @w2yehia wrote: > testcase? This patch is still WIP while I verify the libraries that we intend not to add. But I will add a test case once I've done so :) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504518. francii added a comment. Move `-r` check in `CommonArgs.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp cl

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504516. francii added a comment. Move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChai

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker On AIX, libraries are still being linked when `-r` is passed to the driver. This patch corrects this error.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59848b9ebae6: [Clang][AIX][p] Manually Claim -p in front end (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 503109. francii added a comment. Test case nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolCha

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 503107. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502693. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502204. francii added a comment. Fix missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { daltenty wrote: > Actually

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502006. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501929. francii added a comment. Update based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Drive

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501711. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501698. francii added a comment. Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501692. francii added a comment. Always throw error when `-p` is in command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501668. francii added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cl

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501666. francii added a comment. Update to claiming logic: if `-pg` is passed, only claim `-p` if `-p` is passed afterwards. Otherwise, always claim `-p`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501533. francii added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/ibm-profiling.

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501531. francii added a comment. Add test case descriptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tes

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501530. francii added a comment. Remove old test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501529. francii added a comment. Remove old test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501527. francii added a comment. Merge z/OS and AIX profiling tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501526. francii added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/unus

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501362. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp Index: clang/lib/Driver/ToolC

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The current implementation of `-p` does not claim the argument once it is passed. Since it pushes `-pg` directly, it

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rGec094d259ecf: [z/OS][pg] Throw error when using -pg on z/OS (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f85c560b43b: [Clang][AIX][p]Enable -p Functionality (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.o

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 495588. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495570. francii added a comment. Update test case verbosity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tes

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495267. francii added a comment. Rebase and test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/te

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 493401. francii added a comment. Move check to Clang.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/D

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 493054. francii added a comment. Update based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:274 -if (Args.hasArg(options::OPT_pg)) { +if (Args.hasArg(options::OPT_p, options::OPT_pg)) { CmdArgs.push_back(Args.MakeArgString((llvm::Twine("-L") + D.SysRoot) + da

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 492189. francii added a comment. Remove cc1 option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/T

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 491444. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 491204. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 490638. francii added a comment. Specifically check for AIX before pushing pg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Opti

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 490261. francii added a comment. Remove codegen option approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 487907. francii added a comment. Add supports profiling check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:22 +: ToolChain(D, Triple, Args) { + for (Arg *A : Args.filtered(options::OPT_pg)) { +auto ArgString = A->getAsString(Args); @MaskRay we still need `-pg` to error-out on z/OS.

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii added a comment. In D137756#4023531 , @hubert.reinterpretcast wrote: > In D137756#4018666 , @MaskRay wrote: > >> Most targets reject `-p` now. It's unnecessary to have another z/OS specific >> diagnostic

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 480130. francii marked an inline comment as not done. francii added a comment. Remove -p references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 477241. francii added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/ZOS.cpp clang/test/Driver/zos-pr

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii added a comment. I will add the missing `e` in the `error:` momentarily. Comment at: clang/test/Driver/zos-profiling-error.c:7 +// RUN: not %clang -target s390x-none-zos -pg -S %s 2>&1 | FileCheck -check-prefix=FAIL-PG-NAME %s +// FAIL-PG-NAME: rror: unsupported option

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii added a comment. In D137375#3943751 , @cebowleratibm wrote: > Looks good but I just want to confirm that the profiled -L paths are appended > in the correct order with respect to the non-profiled paths. The linker gives priority to the librarie

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 476649. francii added a comment. Remove Linux changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3935391 , @MaskRay wrote: > In D137753#3935305 , @francii wrote: > >> Recall that the goal with `-p` is to create parity with GCC (at least with >> Linux and AIX), as per the R

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3935391 , @MaskRay wrote: > In D137753#3935305 , @francii wrote: > >> Recall that the goal with `-p` is to create parity with GCC (at least with >> Linux and AIX), as per the R

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. Recall that the goal with `-p` is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion. In D137753#3935138 , @MaskRay wrote: > In D137753#3935126 , @francii

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3934932 , @MaskRay wrote: > Please make `-p` accepted for AIX only and don't change the semantics for > other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try > rejecting `-p`. If OpenBSD wants t

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 476203. francii added a comment. Specify prof and gprof in help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475242. francii added a comment. Add sysroot check to aix-ld.c test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475203. francii added a comment. Add sysroot to test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/D

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475197. francii added a comment. Remove check for -p Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475196. francii added a comment. Add profiled libraries check AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions.de

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475194. francii added a comment. Fix mixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475187. francii added a comment. Herald added a subscriber: ormris. Removed check for sysroot, it is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475009. francii added a comment. Updated Linux test case Added profiled library search for AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475007. francii added a comment. Soft reset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp Index: clang/lib/Driver/Too

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475006. francii added a comment. Removed unnecessary variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp Index: c

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475005. francii added a comment. Add support for `--sysroot` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp Index: cla

[PATCH] D137753: [Clang][GNU][AIX}[p]Enable -p Functionality

francii updated this revision to Diff 474604. francii added a comment. Added Linux implementation and test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 474440. francii added a comment. Use existing error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/ZOS.cpp clang/test/Driver/z

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Throw an error when trying to compile with `-p` or `-pg` on z/OS, as the platform does not support `prof` and `gprof

  1   2   >