Re: r303322 - [modules] Switch from inferring owning modules based on source location to

> On Jun 21, 2017, at 4:56 PM, Richard Smith via cfe-commits > wrote: > > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: > On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith > wrote: > > On 21 June 2017 at 14:51, Bruno Cardoso

r274157 - [cmake] Move creation of ClangTargets and installation of ClangConfig.cmake from ./CMakeLists.txt -> ./cmake/modules/CMakeLists.txt.

Author: mgottesman Date: Wed Jun 29 15:22:44 2016 New Revision: 274157 URL: http://llvm.org/viewvc/llvm-project?rev=274157&view=rev Log: [cmake] Move creation of ClangTargets and installation of ClangConfig.cmake from ./CMakeLists.txt -> ./cmake/modules/CMakeLists.txt. This matches LLVM. Added:

r274158 - [ClangConfig] Replace paths with the same value as CLANG_INSTALL_PACKAGE_DIR with a deref of the variable.

Author: mgottesman Date: Wed Jun 29 15:22:46 2016 New Revision: 274158 URL: http://llvm.org/viewvc/llvm-project?rev=274158&view=rev Log: [ClangConfig] Replace paths with the same value as CLANG_INSTALL_PACKAGE_DIR with a deref of the variable. Modified: cfe/trunk/cmake/modules/CMakeLists.txt

r274168 - [ClangConfig] Copy ClangConfig.cmake to ${CMAKE_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR} instead of to ${CLANG_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR}.

Author: mgottesman Date: Wed Jun 29 16:12:38 2016 New Revision: 274168 URL: http://llvm.org/viewvc/llvm-project?rev=274168&view=rev Log: [ClangConfig] Copy ClangConfig.cmake to ${CMAKE_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR} instead of to ${CLANG_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR}. This

r274180 - [ClangConfig] Store all of the targets exported in the variable CLANG_EXPORTED_TARGETS.

Author: mgottesman Date: Wed Jun 29 16:59:23 2016 New Revision: 274180 URL: http://llvm.org/viewvc/llvm-project?rev=274180&view=rev Log: [ClangConfig] Store all of the targets exported in the variable CLANG_EXPORTED_TARGETS. Modified: cfe/trunk/cmake/modules/CMakeLists.txt cfe/trunk/cmak

r274177 - [ClangConfig] Follow LLVM's example and only install Clang{Config, Target}.cmake when LLVM_INSTALL_TOOLCHAIN_ONLY is disabled.

Author: mgottesman Date: Wed Jun 29 16:59:15 2016 New Revision: 274177 URL: http://llvm.org/viewvc/llvm-project?rev=274177&view=rev Log: [ClangConfig] Follow LLVM's example and only install Clang{Config,Target}.cmake when LLVM_INSTALL_TOOLCHAIN_ONLY is disabled. Modified: cfe/trunk/cmake/mod

r274178 - [ClangConfig] Instead of hard coding the ClangTargets location to /ClangTargets.cmake, follow LLVM's example and use a pre-computed cmake variable @CLANG_CONFIG_EXPORTS_FILE@.

Author: mgottesman Date: Wed Jun 29 16:59:19 2016 New Revision: 274178 URL: http://llvm.org/viewvc/llvm-project?rev=274178&view=rev Log: [ClangConfig] Instead of hard coding the ClangTargets location to /ClangTargets.cmake, follow LLVM's example and use a pre-computed cmake variable @CLANG_CONFI

r274179 - [ClangConfig] Unset some variables after we are done using them to configure ClangConfig.cmake.in files.

Author: mgottesman Date: Wed Jun 29 16:59:20 2016 New Revision: 274179 URL: http://llvm.org/viewvc/llvm-project?rev=274179&view=rev Log: [ClangConfig] Unset some variables after we are done using them to configure ClangConfig.cmake.in files. This ensures that the values do not bleed over in betw

r274176 - [cmake] Instead of just copying ClangConfig.cmake, configure it using ClangConfig.cmake.in.

Author: mgottesman Date: Wed Jun 29 16:59:14 2016 New Revision: 274176 URL: http://llvm.org/viewvc/llvm-project?rev=274176&view=rev Log: [cmake] Instead of just copying ClangConfig.cmake, configure it using ClangConfig.cmake.in. This will allow for cmake to expand variables in ClangConfig.cmake

r274212 - [cmake] Remove stale comment. NFC.

Author: mgottesman Date: Thu Jun 30 00:51:18 2016 New Revision: 274212 URL: http://llvm.org/viewvc/llvm-project?rev=274212&view=rev Log: [cmake] Remove stale comment. NFC. Modified: cfe/trunk/cmake/modules/ClangConfig.cmake.in Modified: cfe/trunk/cmake/modules/ClangConfig.cmake.in URL: http

r284658 - [cmake] Follow LLVM's lead in creating exported tool targets for clang tools.

Author: mgottesman Date: Wed Oct 19 17:46:06 2016 New Revision: 284658 URL: http://llvm.org/viewvc/llvm-project?rev=284658&view=rev Log: [cmake] Follow LLVM's lead in creating exported tool targets for clang tools. This is needed by downstream projects such as swift to get proper cmake dependency

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

gottesmm updated this revision to Diff 46354. gottesmm added a comment. Added documentation. http://reviews.llvm.org/D16708 Files: include/clang/Basic/Attr.td lib/Sema/SemaDeclAttr.cpp test/SemaObjC/attr-cf_no_release.m Index: test/SemaObjC/attr-cf_no_release.m ==

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

> On Jan 29, 2016, at 6:02 AM, Aaron Ballman wrote: > > aaron.ballman added a subscriber: aaron.ballman. > aaron.ballman added a reviewer: aaron.ballman. > aaron.ballman added a comment. > > It's a bit strange to add an attribute that has absolutely no semantic effect > whatsoever. Where is th

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

gottesmm added a comment. I think that my response via email did not hit phabriactor. So sorry for the delay. Yes there is a forthcoming patch for CodeGen which will place an attribute on the relevant functions. The attribute will be queried in the middle end optimizer. The reason why there ha

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

gottesmm added inline comments. Comment at: include/clang/Basic/Attr.td:540 @@ +539,3 @@ + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; +} aaron.ballman wrote: > Please, no undocumented new attributes. You should modify AttrDocs.

Re: r250418 - [CodeGen] Remove dead code. NFC.

> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Thu Oct 15 10:29:40 2015 > New Revision: 250418 > > URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev > Log: > [CodeGen] Remove dead code. NFC. > > Modified: >cfe/trunk/lib/CodeGen/C

Re: r250418 - [CodeGen] Remove dead code. NFC.

> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >>

Re: r250418 - [CodeGen] Remove dead code. NFC.

AA extension hooks? > > On Mon, Oct 19, 2015 at 9:00 PM Michael Gottesman via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >>&g

Re: [ALERT:Possible Phishing] r250418 - [CodeGen] Remove dead code. NFC.

Thanks! Michael > On Oct 20, 2015, at 12:55 AM, Benjamin Kramer wrote: > > Put it back in r250803. Tests very welcome ;) > > - Benjamin > > On Tue, Oct 20, 2015 at 9:14 AM, Michael Gottesman via cfe-commits > wrote: >> Let me play with it a bit (I did not read

r274992 - Move add_clang_* entry points from the main clang CMakeLists.txt to cmake/modules/AddClang.cmake.

Author: mgottesman Date: Sat Jul 9 16:58:40 2016 New Revision: 274992 URL: http://llvm.org/viewvc/llvm-project?rev=274992&view=rev Log: Move add_clang_* entry points from the main clang CMakeLists.txt to cmake/modules/AddClang.cmake. This matches how LLVM has its cmake files organized and is cl

r275006 - Add CLANG_BUILD_TOOLS as a clang counterpart for LLVM_BUILD_TOOLS

Author: mgottesman Date: Sat Jul 9 20:44:00 2016 New Revision: 275006 URL: http://llvm.org/viewvc/llvm-project?rev=275006&view=rev Log: Add CLANG_BUILD_TOOLS as a clang counterpart for LLVM_BUILD_TOOLS LLVM_BUILD_TOOLS is a boolean variable that controls whether or not generated targets for llvm