[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Michael Kuperstein via Phabricator via cfe-commits
mkuper added a comment. I defer to Justin, he knows AST much better than I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___ cfe-commits mailing list

[PATCH] D16135: Macro Debug Info support in Clang

2017-01-30 Thread Michael Kuperstein via Phabricator via cfe-commits
mkuper resigned from this revision. mkuper added a comment. I admit it would be nice if someone reviewed this, but I'm really the wrong person for this code area. :-) https://reviews.llvm.org/D16135 ___ cfe-commits mailing list

[PATCH] D27473: Bring back note about not supporting global register variables

2016-12-12 Thread Michael Kuperstein via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289455: Bring back note about not supporting global register variables. (authored by mkuper). Changed prior to commit: https://reviews.llvm.org/D27473?vs=80450=81113#toc Repository: rL LLVM

[PATCH] D27473: Bring back note about not supporting global register variables

2016-12-06 Thread Michael Kuperstein via Phabricator via cfe-commits
mkuper created this revision. mkuper added a reviewer: rengolin. mkuper added a subscriber: cfe-commits. This partially reverts r260506 which removed this note. Renato, the part about "not being implemented soon because it requires backend support" was taken verbatim from the original text,

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

2016-12-05 Thread Michael Kuperstein via Phabricator via cfe-commits
mkuper added a comment. If there are real-life usecases, then GCC-compatible behavior is probably better than just rejecting it outright, so I'm retracting my comment from PR30426. (I would probably have liked x86_64 with -mno-sse2 and no -msoft-float to be an error, but I would also like a