Re: [PATCH] D11469: [OPENMP] Parsing and sema support for device clause

2015-08-07 Thread Michael Wong via cfe-commits
fraggamuffin added a comment. This has landed. Commit C:\llvmtrunk\tools\clang\include\clang\AST\DataRecursiveASTVisitor.h C:\llvmtrunk\tools\clang\include\clang\AST\OpenMPClause.h C:\llvmtrunk\tools\clang\include\clang\AST\RecursiveASTVisitor.h C:\llvmtrunk\tools\clang\include\clang\Basic\OpenMPK

r244569 - This patch fixes the assert in emitting captured code in the target data construct.

2015-08-10 Thread Michael Wong via cfe-commits
Author: fraggamuffin Date: Mon Aug 10 23:52:01 2015 New Revision: 244569 URL: http://llvm.org/viewvc/llvm-project?rev=244569&view=rev Log: This patch fixes the assert in emitting captured code in the target data construct. This is on behalf of Kelvin Li. http://reviews.llvm.org/D11475 Modified:

Re: [PATCH] D11475: [OPENMP] fix the assert in emitting captured code inside the target data construct

2015-08-10 Thread Michael Wong via cfe-commits
fraggamuffin added a comment. This patch has landed. Commit C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp At revision: 244569 http://reviews.llvm.org/D11475 ___ cfe-commits mailing list c

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2015-08-20 Thread Michael Wong via cfe-commits
fraggamuffin added a comment. Comment at: lib/Parse/ParseDeclCXX.cpp:3011 @@ -3010,3 +3010,3 @@ if (Tok.is(tok::annot_pragma_openmp)) { -ParseOpenMPDeclarativeDirective(); continue; While testing this patch with the latest trunk for my w

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

2015-08-24 Thread Michael Wong via cfe-commits
fraggamuffin added a comment. Got it. Test results look good with this patch. Expected Passes: 7011 Expected Failures : 21 Unsupported Tests : 89 Unexpected Failures: 47 http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-

[PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-07 Thread Michael Wong via cfe-commits
fraggamuffin created this revision. fraggamuffin added a reviewer: cfe-commits. fraggamuffin set the repository for this revision to rL LLVM. Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0. Summary The declare target directive specifies that variables, functions (C, C++ a

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-09 Thread Michael Wong via cfe-commits
fraggamuffin marked 14 inline comments as done. fraggamuffin added a comment. In http://reviews.llvm.org/D15321#304557, @ABataev wrote: > Michael, please provide full diff log, as described in > http://llvm.org/docs/Phabricator.html (with full context) Ok, no problem. Sorry I forgot. Thanks fo

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-09 Thread Michael Wong via cfe-commits
fraggamuffin removed rL LLVM as the repository for this revision. fraggamuffin updated this revision to Diff 42307. fraggamuffin marked an inline comment as done. fraggamuffin added a comment. This is just an interim full diff file of changes accepted so far. I still need to address the attribute

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-29 Thread Michael Wong via cfe-commits
fraggamuffin marked 15 inline comments as done. fraggamuffin added a comment. Thanks for the pre-xmas review. Comment at: include/clang/AST/DeclOpenMP.h:98 @@ +97,3 @@ +/// +class OMPDeclareTargetDecl : public Decl, public DeclContext { + friend class ASTDeclReader; --

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-29 Thread Michael Wong via cfe-commits
fraggamuffin updated this revision to Diff 43746. fraggamuffin marked 3 inline comments as done. fraggamuffin added a comment. Fixed Comments from Dec 17. http://reviews.llvm.org/D15321 Files: include/clang/AST/DeclBase.h include/clang/AST/DeclOpenMP.h include/clang/AST/RecursiveASTVisito