[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

mikerice closed this revision. mikerice added a comment. 57caadc57a30f2279099e5b86bb555b4aab621ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623

[PATCH] D144015: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144015/new/ https://reviews.llvm.org/D144015

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rGe716b0204a5a: [OpenMP 5.2] Deprecate destroy clause without argument for depobj construct (authored by mdfazlay, committed by mikerice). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd27fb5efc5f2: [Serialization] Add support for (de)serializing #pragma pack (authored by DHowett-MSFT, committed by mikerice). Changed prior to

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks for taking care of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice added a comment. In D143410#4107862 , @DHowett-MSFT wrote: > While this fixes the assertion failure and the immediate issue of whether > packing _works_ inside delay-parsed templates in a PCH, it does reveal a > follow-on issue that I can't

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice added inline comments. Comment at: clang/test/PCH/delayed-template-with-pragma-pack.cpp:14 +int func() { +#pragma pack(push, 1) + struct s { short a; T b; }; Your test should include testing of the slot string too, so we are sure all fields are

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

mikerice added a comment. In D138453#410 , @aaron.ballman wrote: > In D138453#4105211 , @DHowett-MSFT > wrote: > >> >> I believe it's expected that we hit this assertion - it's clearer than the >>

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

mikerice accepted this revision. mikerice added a comment. LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141375/new/ https://reviews.llvm.org/D141375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rG530eb263c0ec: [clang] Add serialization for loop hint annotation tokens (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D138328: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'num_tasks' clause on 'taskloop' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rG56c166017055: [OpenMP] Initial parsing/sema for strict modifier with num_tasks clause (authored by mdfazlay, committed by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rGab9eac762c35: [OpenMP] Initial parsing/sema for strict modifier with grainsize clause (authored by mdfazlay, committed by mikerice). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

mikerice added a comment. In D137570#3921879 , @erichkeane wrote: > I haven't dealt much with the loop hint attributes, but two of my coworkers > have done extensive work in our downstream (@jyu2 and @mikerice), and likely > have feedback about how

[PATCH] D134816: [OpenMP] Account for the possibility of multiple target regions per line

This revision was automatically updated to reflect the committed changes. Closed by commit rGc954cfeb57a1: Some uses of the preprocessor can result in multiple target regions on the (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1909 +CtorEntryInfo.ParentName = Twine(Buffer, "_ctor").toStringRef(Out); +llvm::errs() << "Registering var ctor: " << Twine(Buffer, "_ctor") << "\n";

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added a comment. In D136601#3892410 , @jsjodin wrote: > When I have a fix, is there a way for me to test my code on the buildbot? I > don't seem to be able to reproduce the problem on my machine. If you have access to valgrind it can be

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; vitalybuka

[PATCH] D132270: [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute

This revision was automatically updated to reflect the committed changes. mikerice marked an inline comment as done. Closed by commit rG129904d5041f: [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute (authored by mikerice). Herald added a project: clang. Herald added a

[PATCH] D132171: [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args' clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG89167e3c5b00: [OpenMP][NFC] Refactor code for interop parts of init and append_args… (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D131222: [OpenMP] Allow data members in interop init/use/destroy clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4c838da30a: [OpenMP] Allow data members in interop init/use/destroy clauses (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D128397: Add handling cases when filter(tid) appears with deafult(none)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa35141d39501: [OpenMP] Add handling cases when filter(tid) appears with default(none) (authored by mdfazlay, committed by mikerice). Herald added a

[PATCH] D126426: [OpenMP] Use the align clause value from 'omp allocate' for globals

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a5cfbf7b2e8: [OpenMP] Use the align clause value from omp allocate for globals (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

mikerice added a comment. In D126331#3538670 , @jdoerfert wrote: > Cool! Can we have that for begin declare variant too :D ? I'll take a look when I get a moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

This revision was automatically updated to reflect the committed changes. Closed by commit rGba3f85390bde: [OpenMP] Add diagnostic for unterminated omp [begin] declare target (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba937112fa6: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator (authored by mikerice). Herald added a project: clang. Herald

[PATCH] D125493: [clang][OpenMP] Fix declare simd use on in-class member template function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d67c8a51d61: [OpenMP] Fix declare simd use on in-class member template function (authored by mikerice). Herald added a project: clang. Herald added

[PATCH] D125406: [OpenMP] Fix mangling for linear parameters with negative stride

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG772b0c44a429: [OpenMP] Fix mangling for linear parameters with negative stride (authored by mikerice). Herald added a project: clang. Herald added a

[PATCH] D125330: [OpenMP] Fix mangling for linear modifiers with variable stride

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0dbaef61b56f: [OpenMP] Fix mangling for linear modifiers with variable stride (authored by mikerice). Herald added a project: clang. Herald added a

[PATCH] D125269: [OpenMP] Add mangling support for linear modifiers (ref, uval, val)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a02519bc504: [OpenMP] Add mangling support for linear modifiers (ref,uval,val) (authored by mikerice). Herald added a project: clang. Herald added

[PATCH] D124676: [clang][OpenMP] Local variable alignment incorrect with align clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG37471cf2c3fd: [clang][OpenMP] Local variable alignment incorrect with align clause (authored by ddpagan, committed by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122359: [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf82ec5532b2f: [OpenMP] Initial parsing/sema for the omp target parallel loop construct (authored by mikerice). Herald added a project: clang. Herald

[PATCH] D122028: [OpenMP] Initial parsing/sema for the 'omp target teams loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bd8dc91b89d: [OpenMP] Initial parsing/sema for the omp target teams loop construct (authored by mikerice). Herald added a project: clang. Herald

[PATCH] D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79f661edc13d: [OpenMP] Initial parsing/sema for the omp teams loop construct (authored by mikerice). Herald added a project: clang. Herald added a

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

mikerice added a comment. What's the use case? I wasn't aware of any. We saw it from someone who did it accidently and caused the compiler to crash in codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119979/new/

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

This revision was automatically updated to reflect the committed changes. Closed by commit rG383f3a467c92: [OpenMP] Diagnose bad omp declare variant that references itself. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D119761: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective

This revision was automatically updated to reflect the committed changes. Closed by commit rG83a407d176f8: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D117172: [OpenMP] Fix problems with the declare variant append_args clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d5b9fb3e3cd: [OpenMP] Fix problems with the declare variant append_args clause (authored by mikerice). Herald added a project: clang. Herald added

[PATCH] D115902: [OPENMP]Look through member function call base during implicit DSA analysis.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115902/new/ https://reviews.llvm.org/D115902

[PATCH] D115817: [clang] Cleanup unneeded Function nullptr checks [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d0bf1439727: [clang] Cleanup unneeded Function nullptr checks [NFC] (authored by mikerice). Herald added a project: clang. Herald added a

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

mikerice added a comment. Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp for the new clause or the flang build will fail. CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. Looks okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114546/new/ https://reviews.llvm.org/D114546

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114560/new/ https://reviews.llvm.org/D114560

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114653/new/ https://reviews.llvm.org/D114653

[PATCH] D114102: [OpenMP] Add version macro support for 5.1 and 5.2

This revision was automatically updated to reflect the committed changes. Closed by commit rG69f35f896912: [OpenMP] Add version macro support for 5.1 and 5.2 (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4eac7bcf1af1: [OpenMP] Add parsing/sema/serialization for bind clause. (authored by mikerice). Herald added projects: clang, Flang. Herald added a

[PATCH] D112499: [OpenMP] Initial parsing/sema for the 'omp loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f9c25167d16: [OpenMP] Initial parsing/sema for the omp loop construct (authored by mikerice). Herald added a project: clang. Herald added a

[PATCH] D111854: [OPENMP51]Initial parsing/sema for append_args clause for 'declare variant'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8699391a431: [OPENMP51]Initial parsing/sema for append_args clause for declare variant (authored by mikerice). Herald added projects: clang, Flang.

[PATCH] D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4c451001d0: [OPENMP51]Initial parsing/sema for adjust_args clause for declare variant (authored by mikerice). Herald added projects: clang, Flang.

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ https://reviews.llvm.org/D107649

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

mikerice added a comment. Works for the test we have. What about a lit test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ https://reviews.llvm.org/D107649 ___ cfe-commits mailing

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

mikerice added a comment. Looks like now omp.outlined functions are marked with both 'noinline' and 'alwaysinline'. See https://bugs.llvm.org/show_bug.cgi?id=51349 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106799/new/

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. In D101849#2764825 , @ABataev wrote: > No, it is not required. Most probably, needed to simplify test checks, > nothing else. Thanks. I'd like to remove the "REQUIRES: x86-registered-target", the -O1 for CHECK6,10, and

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. > // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd > -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 Is there a good reason to run this with -O1? Doing so makes it super sensitive to which llvm passes run and now this test fails for

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

mikerice added a comment. @jyu2 is currently working on the novariants and nocontext clauses. We are still working on the overall construct so I'm not sure yet what more we will have to contribute. I'll look into updating the support doc. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7899ba0e8b7: [OPENMP51]Initial support for the dispatch directive. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D98834: [OPENMP51]Support for the 'destroy' clause with interop variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f8e158f57c: [OPENMP51]Support for the destroy clause with interop variable. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D98815: [OPENMP51]Initial support for the use clause

This revision was automatically updated to reflect the committed changes. Closed by commit rGc615927c8e38: [OPENMP51]Initial support for the use clause. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98558: [OPENMP51]Initial support for the interop directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG410f09af09b9: [OPENMP51]Initial support for the interop directive. (authored by mikerice). Herald added a project: clang. Herald added a subscriber:

[PATCH] D95834: [OpenMP] Fix iterations calculation for dependent counters

This revision was automatically updated to reflect the committed changes. Closed by commit rGca98c15f2335: [OpenMP] Fix iterations calculation for dependent counters. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

mikerice added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7641 + /// (which accepts anything) and (later) extensions. + StringRef RawString; }; This field doesn't seem to have serialization code. Is that expected or an oversight?

[PATCH] D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88179/new/ https://reviews.llvm.org/D88179

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

mikerice added a comment. Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'? I haven't seen any test fail for those yet though. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:357 ///should be called. +

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice accepted this revision. mikerice added a comment. This looks like the right change to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 ___

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice added a comment. My reasoning is that the generic TreeTransform does semantic analysis on CallExpr and this seems to be related semantic analysis that would need to be redone when the call changed as well. Say someone codes up a new subclass of TreeTransform that maybe changes one of

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8260 } -return Result; + +if (!SemaRef.getLangOpts().OpenMP || !Result.isUsable() || I was expecting the code would be added to RebuildCallExpr in TreeTransform.h. This

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. I did run the math_cpp11 tests. I don't have a cuda environment so it was probably of limited value. I didn't see any failures that seemed related to this during the compiles.

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. Looks okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/ https://reviews.llvm.org/D77414

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

mikerice added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1823 ASTContext = Actions.getASTContext(); -TI.getAsVariantMatchInfo(ASTCtx, VMI, /* DeviceSetOnly */ true); +TI.getAsVariantMatchInfo(ASTCtx, VMI); OMPContext

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice added a comment. I just moved your lookup code and tried to get the same info from the declarator. The function looks like this: FunctionDecl * Sema::ActOnStartOfFunctionDefinitionInOpenMPDeclareVariantScope(Scope *S,

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5512 + + if (!BaseFD) { +// TODO: Determine if we can reuse the declarator to create a declaration I think if you do the base lookup in

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1693 +ExprResult TemplateInstantiator::TransformCallExpr(CallExpr *E) { + ExprResult R = TreeTransform::TransformCallExpr(E); + if (!SemaRef.getLangOpts().OpenMP || !R.isUsable() ||

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1698 + auto *CE = cast(R.get()); + return SemaRef.ActOnOpenMPCall(R, nullptr, CE->getRParenLoc(), + MultiExprArg(CE->getArgs(), CE->getNumArgs()),

[PATCH] D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

This revision was automatically updated to reflect the committed changes. Closed by commit rL366336: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field (authored by mikerice, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

mikerice created this revision. mikerice added reviewers: ABataev, cfe-commits. Herald added a subscriber: guansong. checkDecl is only valid for VarDecls or FieldDecls, since getCanonicalDecl expects only these. Prevent other Decl kinds (such as CXXMethodDecls and EnumConstantDecls) from

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

mikerice added a comment. For the most part, these headers are going to be included in almost every compilation unit anyway since they will come in through other C/C++ library headers. So this would presumably affect only a small numbers of compilation units that only include stddef.h and

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS (authored by mikerice, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

mikerice updated this revision to Diff 198559. mikerice added a comment. Added comments as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61646/new/ https://reviews.llvm.org/D61646 Files: lib/Headers/stdarg.h lib/Headers/stddef.h test/Headers/Inputs/ms-crt/corecrt.h

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

mikerice created this revision. mikerice added reviewers: cfe-commits, rnk. Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This allows some applications developed with MSVC to compile with clang without any extra changes. Fixes: llvm.org/PR40789

[PATCH] D61217: Fix PCH skipping to handle all Lexers

This revision was automatically updated to reflect the committed changes. Closed by commit rC359506: When skipping code at the start of a file during PCH use, Preprocessor::Lex (authored by mikerice, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61217: Fix PCH skipping to handle all Lexers

mikerice created this revision. mikerice added reviewers: rnk, cfe-commits. When skipping code at the start of a file during PCH use, Preprocessor::Lex is not used since it consumes all preprocessor directives until it returns a real token. Using the specific Lexer (i.e. CurLexer->Lex) makes

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

This revision was automatically updated to reflect the committed changes. Closed by commit rC341963: [clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop (authored by mikerice, committed by ). Changed prior to commit: https://reviews.llvm.org/D51391?vs=164698=164917#toc

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

mikerice updated this revision to Diff 164698. mikerice marked an inline comment as done. mikerice added a comment. Updated to use two options: -pch-through-header-create and -pch-through-header-use. https://reviews.llvm.org/D51391 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

mikerice added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2862 + Opts.PCHWithHdrStopCreate = + Args.getLastArgValue(OPT_pch_through_hdrstop_EQ) == "create"; Opts.PCHThroughHeader = Args.getLastArgValue(OPT_pch_through_header_EQ);

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

mikerice updated this revision to Diff 163946. mikerice marked 7 inline comments as done. mikerice added a comment. Thanks for the review. Updated based on comments from Hans. https://reviews.llvm.org/D51391 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340934: [OPENMP] Create non-const ident_t objects. (authored by mikerice, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340934: [OPENMP] Create non-const ident_t objects. (authored by mikerice, committed by ). Repository: rC Clang https://reviews.llvm.org/D51331 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

mikerice created this revision. mikerice added reviewers: thakis, hans. With clang-cl, when the user specifies /Yc or /Yu without a header the compiler uses a #pragma hdrstop in the main source file to determine the end of the PCH. If a header is specified with /Yc or /Yu #pragma hdrstop has no

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

mikerice created this revision. mikerice added a reviewer: ABataev. Herald added subscribers: jfb, guansong. ITT Notify in the OpenMP runtime uses (and writes to) the reserved_2 field in the ident_t struct. See __kmp_itt_region_forking in openmp/runtime/src/kmp_itt.inl. Currently clang is

[PATCH] D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output

mikerice added a comment. In https://reviews.llvm.org/D50640#1203314, @thakis wrote: > Thanks! Do you need someone to land this? Feel free to commit it if you want. Otherwise I'll have my colleague take care of it in the morning. Thanks! https://reviews.llvm.org/D50640

[PATCH] D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output

mikerice added a comment. In https://reviews.llvm.org/D50640#1201216, @thakis wrote: > How does the gcc driver codepath handle this? Interestingly I'd say. So the gcc PCH model uses -include pch.h to use a PCH. In the driver, -include pch.h is handled by locating a matching pch file (say

[PATCH] D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output

mikerice updated this revision to Diff 161116. mikerice marked an inline comment as done. mikerice added a comment. Added a -verify test to ensure no warnings on successful PCH use. https://reviews.llvm.org/D50640 Files: lib/Driver/Driver.cpp test/Driver/cl-pch.cpp

[PATCH] D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output

mikerice created this revision. Herald added a subscriber: cfe-commits. This clang-cl driver change removes the PCH options when we are only generating preprocessed output. This is similar to the behavior of Y-. Repository: rC Clang https://reviews.llvm.org/D50640 Files:

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice added a comment. In https://reviews.llvm.org/D46652#1164010, @thakis wrote: > Also, were you planning on also adding support for the (filename-less version > of) hdrstop pragma? After this change, that should probably be fairly > straightforward. Thanks for taking a look. I'll be

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice added inline comments. Comment at: include/clang/Driver/CC1Options.td:604 + HelpText<"When creating a pch stop at this file. When using a pch start " + "after this file.">; def fno_pch_timestamp : Flag<["-"], "fno-pch-timestamp">, hans

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice added inline comments. Comment at: include/clang/Driver/CC1Options.td:604 + HelpText<"When creating a pch stop at this file. When using a pch start " + "after this file.">; def fno_pch_timestamp : Flag<["-"], "fno-pch-timestamp">, hans

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice updated this revision to Diff 153067. mikerice marked 8 inline comments as done. mikerice added a comment. Thanks for the review. Updated based on comments. https://reviews.llvm.org/D46652 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Driver/CC1Options.td

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice added a comment. Ping. This can significantly improve compile time for projects that use the common /Yc /Yu PCH mechanism. https://reviews.llvm.org/D46652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice added a comment. Ping. Still looking for a reviewer, mostly Lex and clang-cl driver changes. https://reviews.llvm.org/D46652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >