[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

hctim added a comment. Hi folks, I found an issue with building Android using this patch. I've reduced it down to the following problem where the evaluation of the `std::visit` is believed to be non-exhaustive, but it seems like it is? Would you mind taking a look? Admittedly, my knowledge in

[PATCH] D146987: [Assignment Tracking] Enable by default

hctim added a comment. Hey, found another error that looks to be different from @maskray's revert. $ bin/clang -c -O2 -g -ftrivial-auto-var-init=zero /tmp/repro.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

hctim added a comment. Hi, yep, I've reverted upstream. If you could please also integrate https://reviews.llvm.org/rG8c7c1f11ffaacf762e612c65440fd2cbb58ee426 in the relanding, that would be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139395: Add CFI integer types normalization

hctim added a comment. Hey folks, looks like this caused a failure on the msan buildbot: https://lab.llvm.org/buildbot/#/builders/237/builds/785 It's been had a long-running bug that I'm still tracking down but seems like this is a new failure caused by this patch. The track-origins log is

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

hctim added a comment. Hey, looks like this broke the x86_64-linux sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/19910 You can reproduce the bot using the instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (substitute

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added a comment. In D133392#4094524 , @dyung wrote: > Hi @hctim, the test you added is failing on buildbots where AArch64 is not > built, can you either update the test to not require that backend, or mark > the test as requiring it? > >

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4edfcff71e15: [MTE] Add AArch64GlobalsTagging Pass (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 493642. hctim marked 2 inline comments as done. hctim added a comment. Rebase for submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files:

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 486093. hctim added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang/test/CodeGen/memtag-globals-asm.cpp

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012854 , @ilinpv wrote: > I don't think `std::equal` is underlying cause here. We have > featuresStrs_size() comparison before calling it: > > if (CurClones && NewClones && >

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012276 , @ilinpv wrote: > I've managed to reproduce "MemorySanitizer: use-of-uninitialized-value" error > locally, thank you @hctim for help! > If I understand it right, it seems **MSan didn't handle correctly >

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4011372 , @ilinpv wrote: > Regular builds works fine for me, pthreads located here > "/lib/x86_64-linux-gnu/libpthread.so" > "/usr/lib/x86_64-linux-gnu/libpthread.so". Enabling > "-DLLVM_USE_SANITIZER=Memory" resulted

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4010856 , @ilinpv wrote: > It would be great to have more details how to setup up your bot, using > buildbot_fast.sh on x86_64 Ubuntu 22.04 LTS leads to error ( pthreads > installed ): > > CMake Error at >

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4009447 , @hctim wrote: > Hi, this looks like a candidate for breaking the MSan bot: > https://lab.llvm.org/buildbot/#/builders/5/builds/30139 > > Still looking into it and bisecting, will let you know when I have more

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. Hi, this looks like a candidate for breaking the MSan bot: https://lab.llvm.org/buildbot/#/builders/5/builds/30139 Still looking into it and bisecting, will let you know when I have more info. To reproduce the bots, the best way (because MSan setup is tricky because it

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. Herald added subscribers: Enna1, abrachet, MaskRay. Herald added a project: All. Partially merged (making -fsanitize=scudo use scudo_standalone) merged in D138157 . Will probably re-use this in a bit to add the dangling scudo tests to

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc414bbefe45a: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 479693. hctim added a comment. Lots of places in scudo_standalone depend on GWP-ASan, and it seems far more reasonable to make COMPILER_RT_HAS_GWP_ASAN mean "is GWP-ASan actually going to be built", rather than checking three variables in all the places.

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/CodeGen/GlobalMerge.cpp:657 +// Tagged global variables shouldn't be merged, as they are assigned unique +// memory tags at runtime. +if (GV.isTagged()) eugenis wrote: > This comment is not

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 479452. hctim marked 2 inline comments as done. hctim added a comment. Rebase now that the parent is submitted, clean up an old comment. New commit message also incoming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850defb86164: Add assembler plumbing for sanitize_memtag (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); fmayer wrote: > Is the story here that

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 478367. hctim marked an inline comment as done. hctim added a comment. Update comment for .memtag globals when generating object files on non-MTE-globals supported architectures, and move said comment from an assert to a fatal error. Repository: rG LLVM

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477620. hctim marked 2 inline comments as done. hctim added a comment. Move isMemtag below assert(Sym) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files:

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477600. hctim added a comment. Use new MemtagABI section types, now that it's merged upstream: https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. Thanks for the detailed information folks. I'll probably fix it up and re-submit next week (after the US holidays) given that the blast radius seems to be bigger than I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab1a5991fe76: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. In D138157#3935173 , @phosek wrote: > Is the plan to eventually rename `scudo_standalone` to `scudo` once the > santiizer-based Scudo implementation is deleted? Ideally, yes (as well as make scudo_standalone not be in a

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added inline comments. Comment at: llvm/docs/GwpAsan.rst:174 ++-++ -| PerfectlyRightAlign| false | When allocations are right-aligned, should we

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 476241. hctim marked 2 inline comments as done. hctim added a comment. Remove unrelated diff from doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 Files:

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, abrachet, phosek, cryptoad. Herald added a project: All. hctim requested review of this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, MaskRay. Herald added projects:

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 459534. hctim added a comment. Remove unnecessary hasSanitizerMetadata() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files: clang/test/Driver/memtag-stack.c

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:25 + +using namespace llvm; + fmayer wrote: > why don't we put this into the llvm namespace rather than using? common for code in this folder, `INITIALIZE_PASS_BEGIN`

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458536. hctim marked 2 inline comments as done. hctim added a comment. Some namespace moving and shaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files:

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458487. hctim marked an inline comment as done. hctim added a comment. Update inlined constants to use named constant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:60 + // gadgets. + if (G.getName().startswith("llvm.") || G.isThreadLocal() || G.isConstant()) { +Meta.Memtag = false; fmayer wrote: > not necessarily in this CL: do

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458472. hctim marked 3 inline comments as done. hctim added a comment. Update from Florian's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files:

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim created this revision. hctim added reviewers: fmayer, eugenis. Herald added subscribers: hiraditya, kristof.beyls, mgorny. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adds the

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 457431. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. Move some existing stack tests to use -fsanitize=memtag-stack now that we have a non-android warning on -fsanitize=memtag-globals (which is

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. In D132425#3753065 , @leonardchan wrote: > We have a generic long term solution for hwasan+RV which I think might also > be applicable for MTE+RV. For hwasan, since it's mainly the IR pass that > converts usages of the vtable

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. Glad to see that refactoring the sanitizer metadata made someone's life easier ;) (now allowing for disabling hwasanificiation of globals) Patch looks reasonable to me. Can you please add the negative test (that vtables under the vanilla ABI still have hwasan)? I wans't

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

hctim added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131806/new/ https://reviews.llvm.org/D131806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. In D129048#3652689 , @aaron.ballman wrote: > In D129048#3652679 , @hctim wrote: > >> Looks like unfortunately this breaks all lots of libcxx tests - which were >> picked up by our

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. Looks like unfortunately this breaks all lots of libcxx tests - which were picked up by our sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/85/builds/9157 Should be reproducible with just `cmake -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" && make check-cxx`.

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7045519359de: Add missing sanitizer metadata plumbing from CFE. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129492/new/

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90e5a8ac475f: Remove no_sanitize_memtag. Add sanitize_memtag. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim updated this revision to Diff 444115. hctim added a comment. Update ASan and HWASan tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129492/new/ https://reviews.llvm.org/D129492 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

hctim updated this revision to Diff 444111. hctim marked an inline comment as done. hctim added a comment. Final comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128950/new/ https://reviews.llvm.org/D128950 Files:

[PATCH] D128672: Update DynInit generation for ASan globals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18de7619e5d: Update DynInit generation for ASan globals. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim updated this revision to Diff 443702. hctim marked an inline comment as done. hctim added a comment. Integrate Vitaly's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llvm.org/D128672 Files:

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim created this revision. hctim added a reviewer: eugenis. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang misses attaching sanitizer metadata for external globals. Repository: rG LLVM Github

[PATCH] D128950: Add 'sanitize_memtag' Global IR attribute

hctim updated this revision to Diff 443390. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. After talking with Evgenii offline, and testing, clearly we don't need an exclude mask. Update the patch to remove the exclude mask, and

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3614242 , @thakis wrote: > Looks like this breaks check-clang on windows: > http://45.33.8.238/win/61067/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks. Added a2095d1aff84

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rGdacfa24f75c3: Delete llvm.asan.globals for global metadata. (authored by hctim). Changed prior to commit:

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address a follow-up TODO for Sanitizer Metadata. Repository: rG LLVM Github Monorepo

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439918. hctim marked 3 inline comments as done. hctim added a comment. Vitaly's comments, round 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files:

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439912. hctim marked 2 inline comments as done. hctim added a comment. Vitaly's comments - round 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files:

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(;

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. I see that the clang-ppc64le-linux bot is green with the second attempt (https://lab.llvm.org/buildbot/#/builders/105/builds/27200). Please let me know if you have further issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609343 , @hubert.reinterpretcast wrote: > In D127544#3609335 , @hctim wrote: > >> Sent fadc98b06befb674fa47da4f3d8606bf61bed681 >>

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. Sent fadc98b06befb674fa47da4f3d8606bf61bed681 to fix-forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added a comment. In D127544#3609312 , @hubert.reinterpretcast wrote: > This is causing "unsupported architecture" errors on bots. Looking, I see this on the sanitizer-ppc64 bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439880. hctim added a comment. Rebase on main / landed changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf5e0ec737a: Add no_sanitize(hwaddress) (and memtag, but thats a no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3605774 , @MaskRay wrote: >> This saves about ~0.275% of the optimised clang binary. > > Worth clarifying a bit which -O level and whether -g is used. `clang-15` binary, no `-g`, `-DLLVM_ENABLE_ASSERTIONS=ON

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. friendly ping @vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437734. hctim marked 2 inline comments as done. hctim added a comment. Create test input files rather than synthesizing on the fly, fix tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > hctim wrote: > > aaron.ballman wrote: > > > Spurious whitespace change? > >

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Integrated slowly and surely as part of the stack leading up to D127911 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126224: Add DWARF string debug to clang release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011e0604ebc9: Add DWARF string debug to clang release notes. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim updated this revision to Diff 437717. hctim marked an inline comment as done. hctim added a comment. Change a small amount of wording, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 Files:

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim marked an inline comment as done. hctim added a comment. In D126224#3534643 , @probinson wrote: > I see some unrelated whitespace changes, we generally don't like mixing those > with "real" changes. But the description seems fine to me. Looks

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. (thanks for the bump - this one fell off the radar) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. Yeah, I'll look at landing it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 437385. hctim added a comment. Small test fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, ormris, hiraditya. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers,

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim added a comment. In D127163#3587115 , @thakis wrote: > FYI: If you change serialized opts in a def file, you have to bump the pch > version, else with builds that don't embed the llvm revision > (LLVM_APPEND_VC_REV=OFF) won't notice they have to

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > Spurious whitespace change? unfortunately there's no way in my editor to trim trailing whitespace only on changed lines

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437355. hctim marked 6 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45d88cd00846: [clang] Add -fsanitize=memtag-globals (no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. LGTM: http://45.33.8.238/win/60042/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 ___ cfe-commits mailing list

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added a comment. Thanks for the heads up. Reverted, and now re-landing. Unfortunately I don't have a Windows machine so I've made my best guesses about fixing (mostly seems to just symbol name mangling / global attributes that change on the windows target). I'll keep an eye on that

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7766972a679: Add sanitizer metadata attributes to clang IR gen. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 436485. hctim added a comment. Remove one unnecessary set of brackets before submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files:

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:101 + llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( + llvm::Type::getInt1Ty(VMContext), Meta.IsDynInit)), llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 436484. hctim marked 4 inline comments as done. hctim added a comment. Final review touch-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files:

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

hctim added a comment. Looks like this broke the ASan buildbot (and may have been missed because the bot was already red at the time): https://lab.llvm.org/buildbot/#/builders/5/builds/24588 Instructions on how to repro the bot are here:

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Deprecated by D127544 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119367/new/

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim updated this revision to Diff 436059. hctim marked 2 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 Files:

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:767 + if (IsAArch64) { +Res |= SanitizerKind::MemtagGlobals; + } eugenis wrote: > Hmm why are all the other memtag* not here? Yeah, just

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim created this revision. hctim added a reviewer: pcc. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Enna1. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits.

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rG8db981d463ee: Add sanitizer-specific GlobalValue attributes. (authored by hctim). Repository: rG LLVM

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435671. hctim added a comment. And some small diff-reducing touch ups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435669. hctim added a comment. Remove two unnecessary braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435667. hctim marked 3 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files:

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked 10 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435257. hctim marked 3 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files:

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if

  1   2   3   >