[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Well done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150057/new/ https://reviews.llvm.org/D150057

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar added a comment. I retract my objection. I forgot that from clang-format's perspective, `#else` blocks in separate functions have the same indent and nesting level, and thus the same "scope", so the alignment issues may persist there. You will see misalignment in `#else`

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar added a comment. After reviewing the GitHub issue, it looks like the IndentAndNestingLevel is sticky over the entire scope for `#else` blocks, so the regression only occurs within `#else` blocks in the same scope. The bug I fixed affected alignment in all `#else` blocks,

[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. It would be ideal to be able to properly handle nested types like this, but for right now this is causing a crash in Swift-DocC, so this patch will at least get that

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar updated this revision to Diff 461979. mitchell-stellar added a comment. Do not limit columns and added nested test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar updated this revision to Diff 460890. mitchell-stellar added a comment. Added context and use verifyFormat(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar created this revision. mitchell-stellar added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. mitchell-stellar added a project: clang-format. Herald added a project: All. mitchell-stellar requested review of this revision. Herald added a project: clang. Fixes

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

QuietMisdreavus added a comment. clang-format failed: --- clang-format changed files: clang/test/ExtractAPI/underscored.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125678/new/ https://reviews.llvm.org/D125678

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125678/new/ https://reviews.llvm.org/D125678

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ https://reviews.llvm.org/D123391

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

QuietMisdreavus added a comment. This looks good! Just one question. Comment at: clang/test/ExtractAPI/objc_interface.m:198 +"kind": "identifier", +"spelling": "getWithProperty:" + } I'm curious: Does this properly handle

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123259/new/ https://reviews.llvm.org/D123259

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123261/new/ https://reviews.llvm.org/D123261

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. I like the idea of using the RAII context/guard to manage the path components stack. I have one non-blocking comment about the rest of the patch now.

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } dang wrote: > dang wrote: > > zixuw wrote: > > > zixuw wrote: > >

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added a comment. In D123045#3427992 , @zixuw wrote: > In D123045#3427699 , > @QuietMisdreavus wrote: > >> After a quick scan comparing the current output of these symbol graphs with >> the

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added a comment. After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them , the last thing i can spot that's "off" is that the "function signature" is currently being

[PATCH] D117809: [clang] Add an extract-api driver option

QuietMisdreavus added inline comments. Comment at: clang/include/clang/Driver/Types.def:103 TYPE("hip-fatbin", HIP_FATBIN, INVALID, "hipfb", phases::Compile, phases::Backend, phases::Assemble, phases::Link) +TYPE("api-information", API_INFO,

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

mitchell-stellar added a comment. I am in favor of a new option, `IncludeIsMainAllowBraces`. It keeps things simple and does not cause any backwards-compatibility issues. The `${}` variables are clever, but if "users unconcerned with formatting ... could get the current functionality by

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

mitchell-stellar accepted this revision. mitchell-stellar added a comment. I am in favor of landing this and iterating. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing list

[PATCH] D85304: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ad60f6452ff: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85304: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85304/new/ https://reviews.llvm.org/D85304

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

mitchell-stellar added a comment. I often: 1. Commit the change to my local repo, following the style of previous commit messages for clang-format. 2. Build and run the clang-format tests and make sure they pass. 3. Pull, rebase, and push. (Linear history is enforced.) 4. Build and run the

[PATCH] D75364: [clang-format] Handle macros in function params and return value

mitchell-stellar added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7359 verifyIndependentOfContext("bool a = f() && final.f();"); + verifyFormat("int f(M(x) *p1 = nullptr, M(x) *p2, volatile M(x) *p3);"); + verifyFormat("M(x) *foo();");

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reverted this commit due to an unexpected test failure: TEST 'Clang :: Format/dump-config-objc.h' FAILED Script: -- :

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b1a87ba35d: [clang-format] Add option to specify explicit config file Summary: This diff… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eff1c3ce48e: [clang-format] Extend AllowShortLoopsOnASingleLine to do ... while loops. (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D75022?vs=246512=248748#toc

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

mitchell-stellar added a comment. It's not more approval that is needed, it's just that someone with commit access (assuming you do not) needs to find the time to commit this. For what it's worth, I'm getting a patch rejection for the 4th block in lib/Format/Format.cpp. It seems the contents

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

mitchell-stellar added a comment. Not that I am aware of. Whoever ends up doing the merge will likely run the necessary tests before committing. If you've run as many as you can, then hopefully all will be fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

mitchell-stellar added a subscriber: mxbOctasic. mitchell-stellar added a comment. Digging through the history, it seems this behavior was explicitly desired: https://reviews.llvm.org/D19028. @mxbOctasic was the original author and perhaps could comment. Regardless, I think there should be a

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. Assuming this passes all existing tests, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___ cfe-commits mailing list

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rG73d93617d3ae: [clang-tidy] modernize-use-using uses AST and now supports struct defintions… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

This revision was automatically updated to reflect the committed changes. Closed by commit rGd45aafa2fbcf: [clang-format] fix conflict between FormatStyle::BWACS_MultiLine and… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71769/new/ https://reviews.llvm.org/D71769

[PATCH] D71659: [clang-format] Added new option to allow setting spaces before and after the operator

mitchell-stellar requested changes to this revision. mitchell-stellar added a comment. This revision now requires changes to proceed. This feature is missing unit tests. Also, what is the reason for all the comment changes? I don't think the changed comment lines originally exceeded 80

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG26748a321e20: [clang-format] Add new option to add spaces around conditions Summary: This… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D68346?vs=225345=231930#toc

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

This revision was automatically updated to reflect the committed changes. Closed by commit rG24aafcadff38: [clang-tidy] modernize-use-equals-default avoid adding redundant semicolons (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

This revision was automatically updated to reflect the committed changes. Closed by commit rG980653621ef5: [clang-tidy] Give readability-redundant-member-init an option… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69145?vs=229934=230077#toc Repository:

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rG1315f4e009b0: [clang-tidy] Fix readability-redundant-string-init for c++17/c++2a (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69238?vs=229651=230039#toc

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf7086fe: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229632=230040#toc

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D70165. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D69238. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar added a comment. Oops, it looks like I mixed up this ticket with https://reviews.llvm.org/D69238. Sorry about that. Would you like me to revert both commits and then re-commit with the correct links, etc.? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar added a comment. Yes, there was a failing unit test that had to be fixed. I reverted the first commit and then committed a version that fixed the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/ https://reviews.llvm.org/D70355 ___ cfe-commits

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rG06f3dabe4a2e: [clang-tidy] Fix readability-redundant-string-init for c++17/c++2a (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69238?vs=228556=229651#toc

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG96fbc32cb9ea: [clang-tidy] Give readability-redundant-string-init a customizable list of… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69548?vs=228769=229637#toc

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rG50e99563fb04: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229012=229632#toc

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG782392db8122: [clang-tidy] modernize-use-using work with multi-argument templates (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70249: [clang-format] Fixed edge-case with `Style.SpacesInSquareBrackets` with trailing bare `&` lambda capture

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ee70e00b509: [clang-format] Fixed edge-case with SpacesInSquareBrackets with trailing bare… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70249: [clang-format] Fixed edge-case with `Style.SpacesInSquareBrackets` with trailing bare `&` lambda capture

mitchell-stellar created this revision. mitchell-stellar added a reviewer: MyDeveloperDay. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lambda captures allow for a lone `&` capture, so `&]` needs to be properly handled.

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

mitchell-stellar added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3109 return Right.HasUnescapedNewline; + if (isAllmanBrace(Left) && !Style.AllowShortEnumsOnASingleLine && + (Line.startsWith(tok::kw_enum) || MyDeveloperDay

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69951/new/ https://reviews.llvm.org/D69951 ___ cfe-commits

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1589 + statement. Switch statement body is always indented one level more than + case labels. \code false: true: This generated rst

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. MyDeveloperDay wrote: > mitchell-stellar wrote: > > Can this documentation be

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. Can this documentation be formatted in a way that avoids clang-format

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70003/new/ https://reviews.llvm.org/D70003

[PATCH] D56345: [clang-format] Assert that filenames are not empty

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56345/new/ https://reviews.llvm.org/D56345 ___ cfe-commits

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

mitchell-stellar added a comment. Never mind, I got it resolved and pushed. Sorry for the noise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/ https://reviews.llvm.org/D69649 ___ cfe-commits mailing list

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d7bd5752648: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial ref… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

mitchell-stellar added a comment. Thanks. Would you mind committing this on my behalf? It seems I wasn't migrated from SVN access to git access. It may take some time to sort out. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, klimek, sammccall. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes an edge case in the `SpacesInSquareBrackets` option

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added a comment. Sounds like you know what you're doing. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69433/new/ https://reviews.llvm.org/D69433 ___ cfe-commits mailing list

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): MyDeveloperDay wrote: > mitchell-stellar wrote: > > This seems quite

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): This seems quite flimsy to me, as it depends on an undocumented comment

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69404/new/ https://reviews.llvm.org/D69404

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar accepted this revision. mitchell-stellar added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits mailing list

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1955 + /// \endcode + bool SpacesInConditionalStatement; + Nitpick: this

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Okay. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68707/new/ https://reviews.llvm.org/D68707 ___

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

mitchell-stellar added a comment. To me, whether or not the assertion was valid is irrelevant. That assertion was intentionally added, and its replacement with an `if()` statement materially changes the inputs and outputs of the function. I'm questioning whether the input of a "while" token

[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

mitchell-stellar added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:847 case tok::kw_while: - assert(!Line.startsWith(tok::hash)); - if (Tok->is(tok::kw_if) && CurrentToken && - CurrentToken->isOneOf(tok::kw_constexpr,

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

mitchell-stellar added a comment. I don't care for the command line switches that try to emulate compiler flags. I am also of the opinion that external scripts should be used for this functionality. git for Windows gives you a full set of bash utilities to utilize, so doing stuff like this on

[PATCH] D29039: [clang-format] Proposal for clang-format -r option

mitchell-stellar added a subscriber: djasper. mitchell-stellar added a comment. I agree with @djasper that this is outside the scope of clang-format. git for Windows gives you a full set of bash utilities to utilize, so doing stuff like this on Windows is much easier now. Repository: rL

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. I agree that a system in place that either enforces clang-formatting on commit or after the fact would be ideal. Otherwise, I don't see a need to have to approve

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68481/new/ https://reviews.llvm.org/D68481 ___ cfe-commits

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:1617 +if (Tok.Next->isOneOf(tok::kw_noexcept, tok::kw_volatile, tok::kw_const, +

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

mitchell-stellar added a comment. Thanks, please commit on my behalf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68473/new/ https://reviews.llvm.org/D68473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes the `SpacesInSquareBrackets` setting also apply to C++

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

mitchell-stellar requested changes to this revision. mitchell-stellar added a comment. This revision now requires changes to proceed. This needs to be more thought out. At the very least it needs to cover more keywords like `do`, `switch`, `try`, and `catch`. There may be more. Consideration

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68332/new/ https://reviews.llvm.org/D68332 ___ cfe-commits

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar updated this revision to Diff 223212. mitchell-stellar added a comment. Fixed empty parentheses unit test for C++11 braced initializer list. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 Files:

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. You are correct. I'll work on this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. Thanks. Please commit on my behalf when you have a chance. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. If you want spaces in your C++11 initializers and nothing else, then you don't want the `Cpp11BracedListStyle` setting enabled. Turning it off gives you spaces inside without affecting anything else. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2290 +**SpacesAroundConditions** (``bool``) + If ``true``, spaces will be inserted around if/for/while (and similar) conditions.

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar updated this revision to Diff 223077. mitchell-stellar added a comment. Added additional unit tests to verify that the `SpaceInEmptyParentheses` setting is also correctly adhered to. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. I don't think that's a good idea, considering the fact that braces can mean different things in different contexts, and it would cause trouble for existing clang-format settings. If a hypothetical `SpacesInBraces` were `false` by default, then you could have

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:2892 + if (Left.is(TT_UnaryOperator)) { +// Don't combine the unary operators !~ into

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the clang-format documentation, "Fundamentally, C++11 braced

[PATCH] D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67629/new/ https://reviews.llvm.org/D67629

[PATCH] D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67660/new/ https://reviews.llvm.org/D67660

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

mitchell-stellar added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68242/new/ https://reviews.llvm.org/D68242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 223058. mitchell-stellar added a comment. Rebased against master, and also added test case for 'do' statements. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68296/new/ https://reviews.llvm.org/D68296 Files:

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar marked 4 inline comments as done. mitchell-stellar added inline comments. Comment at: clang/lib/Format/Format.cpp:643 +true}; switch (Style.BreakBeforeBraces) { case FormatStyle::BS_Linux: MyDeveloperDay wrote:

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 222907. mitchell-stellar added a comment. Renamed "OnlyMultiLine" option to "MultiLine", per reviewer request. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68296/new/ https://reviews.llvm.org/D68296 Files:

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar added a comment. @MyDeveloperDay I am not wedded to "OnlyMultiLine". I picked it, as it seemed reasonable to me, but if you think another string expresses the intent better, then feel free to use it. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 222835. mitchell-stellar edited the summary of this revision. mitchell-stellar added a comment. Thanks for the review. I have added documentation updates. I do not have a public style guide to reference. My company just switched to

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

mitchell-stellar created this revision. mitchell-stellar added reviewers: sammccall, owenpan, reuk. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the BraceWrappingFlags' AfterControlStatement from a bool to an enum