Phabricator Creator Pulling the Plug

All I'm a massive fan of Phabricator, and I know there is often lots of contentious discussion about its relative merits vs github, But unless I missed this, was there any discussion regarding the recent "Winding Down" announcement of Phabricator? and what it might mean for us in LLVM See: https

Re: [PATCH] D93938: [clang-format] Fixed AfterEnum handling

+1 we are not going to land this with a failing or removed test On Tue, 9 Mar 2021 at 07:29, Marek Kurdej via Phabricator < revi...@reviews.llvm.org> wrote: > curdeius added a comment. > > In D93938#2612952 , > @HazardyKnusperkeks wrote: > > > In my opini

Re: [PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

I have a script that runs clang-format -n on various directories in clang that are clang format clean, polly is one of them because they have clang format as a unit test I use this to ensure I don’t regress behaviour Maybe we should formalise this with some sort of clang-format-check cmake rule

Re: [PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

We could resolve this using a separate TokenAnalyzer pass similar to what we are doing here https://reviews.llvm.org/D69764, such a would let us look at the last token on the previous line or the next token in the next time to ensure we don't remove legal cases like for(; ; ) Adding a DoubleSem

Re: [PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

Thank you for handling that I will look into your suggestions MyDeveloperDay On Sat, 12 Oct 2019 at 23:55, Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > This fails on macOS: > > : 'RUN: at line 2'; grep -E "*code should be clang-formatted*" > /U

Re: r372939 - [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Thank you for fixing this... On Thu, Sep 26, 2019 at 3:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Wed Sep 25 19:02:17 2019 > New Revision: 372939 > > URL: http://llvm.org/viewvc/llvm-project?rev=372939&view=rev > Log: > [clang-format] Add Sor

Re: r355182 - [clang-format] [NFC] clang-format the Format library

Yes ideally I'd agree, It also says: > Avoid committing formatting- or whitespace-only changes outside of code you plan to make subsequent changes to. This was getting to be a problem, every time we edited the file (with auto-clang-format) a large number of other changes would also get made, pres