[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. Could you please commit this on my behalf? I don't have commit access. https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. Ping https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng updated this revision to Diff 130817. ng added a comment. Fix multiset variable definition in tests https://reviews.llvm.org/D42344 Files: libcxx/include/map libcxx/include/set libcxx/test/std/containers/associative/map/map.ops/count_transparent.pass.cpp libcxx/test/std/containers

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng updated this revision to Diff 130814. ng added a comment. Renamed tests for map/set, and added multimap/multiset tests https://reviews.llvm.org/D42344 Files: libcxx/include/map libcxx/include/set libcxx/test/std/containers/associative/map/map.ops/count_transparent.pass.cpp libcxx/

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote: > Shouldn't there be tests for `multimap` and `multiset`, too? Sure; will the same tests as for map/set be alright? https://reviews.llvm.org/D42344 ___ cfe-commits

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng updated this revision to Diff 130812. ng added a comment. As per the above suggestions, enabled _multi tree search only for transparent comparator functions, and added tests. https://reviews.llvm.org/D42344 Files: libcxx/include/map libcxx/include/set libcxx/test/std/containers/as

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng created this revision. ng added a reviewer: mclow.lists. Herald added a reviewer: EricWF. As described in http://bugs.llvm.org/show_bug.cgi?id=30959, the current implementation of std::{map, key}::{count, equal_range} in libcxx is non-conforming. Quoting ISO/IEC 14882:2014 section 23.2.4: >