[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557588. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav marked an inline comment as done. chaitanyav added a comment. Ran llvm with the boolean and operator change. attaching the log file with errors .F29524460: llvm.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557513. chaitanyav added a comment. rebase upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557427. chaitanyav added a comment. Add parentheses to the conditional expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557417. chaitanyav added a comment. Add parentheses to the conditional expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. Bootstrapping build failed due to -werror flag (https://buildkite.com/llvm-project/libcxx-ci/builds/30031) |

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557373. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557346. chaitanyav added a comment. Rebase with upstream and update code as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG785b30b8a33a: [clang-tidy] Check for specific return types on all functions (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. In D151383#4377043 , @PiotrZSL wrote: > LGTM, you may consider reducing commit message (aka review description by > removing example and error from it, and leaving just plain description of a > change). got it, will make

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526173. chaitanyav marked an inline comment as done. chaitanyav added a comment. use fully qualified name in code and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526159. chaitanyav marked 4 inline comments as done. chaitanyav added a comment. Make changes as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525926. chaitanyav marked an inline comment as done. chaitanyav added a comment. Use single backticks for options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. please let me know if there is better way to do the matching `hasAnyReturnType`. We could also sort then do binarysearch instead of looping through the list of ret types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525855. chaitanyav added a comment. Add tests, update docs and extend matchcallexpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files:

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525359. chaitanyav added a comment. Reuse diag code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files:

[PATCH] D151383: Check for specific return types on all functions

chaitanyav added a comment. @royjacobson Please list other types that must be included here. The tests are coming... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151383: Check for specific return types on all functions

chaitanyav created this revision. chaitanyav added a reviewer: royjacobson. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. I used the patch to compile LLVM, apache/arrow, apache/trafficserver, folly, tensorstore, protobuf. I did not see any cases with pointer arithmetic in these repos. I see there is some value for the patch in terms of readability (will be helpful to someone who is

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. In D147844#4361956 , @aaron.ballman wrote: > In D147844#4335598 , @dblaikie > wrote: > >> In D147844#4329497 , >> @aaron.ballman wrote: >>

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 524376. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 524321. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 524072. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 521330. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 521203. chaitanyav added a comment. Remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 520725. chaitanyav added a comment. Rebase with upstream and remove duplicate line from ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 520491. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments

This revision was automatically updated to reflect the committed changes. Closed by commit rG14805dcb0d8a: [clang][ExtractAPI] Add semicolon to function declaration fragments (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

chaitanyav added a comment. @shafik @aaron.ballman I see some errors [1/2496] Building DiagnosticAnalysisKinds.inc... FAILED: tools/clang/include/clang/Basic/DiagnosticAnalysisKinds.inc /home/nvellanki/scratch/llvm-project/tools/clang/include/clang/Basic/DiagnosticAnalysisKinds.inc cd

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 519259. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments

chaitanyav added a comment. @dang @ributzka I missed adding semicolons to function declaration fragments in this commit https://github.com/llvm/llvm-project/commit/afce10c5b60fada1db369d3770f4389da7ef30ef . Please review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add missing semicolon at the end of function

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 518118. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517429. chaitanyav added a comment. Revert libcxx libcxxabi files unrelated to the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517372. chaitanyav added a comment. Add parentheses around integer expressions in libcxx tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517300. chaitanyav added a comment. Revert to earliest patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. In D147844#4299874 , @aaron.ballman wrote: > In D147844#4299856 , @chaitanyav > wrote: > >> Disable precedence conditional warning by default; Revert changes to test >> files > >

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517268. chaitanyav added a comment. Disable precedence conditional warning by default; Revert changes to test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. @aaron.ballman just for learning, can you point me to the code where a warning is selectively enabled/disabled based on a flag. For e.g. -Wunused-comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517070. chaitanyav added a comment. Herald added a subscriber: arphaman. Fix more failing tests due to missing parentheses in conditional operator expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. Added parentheses to lots of files to fix the precedence warning. Still a lot to change in OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517042. chaitanyav added a comment. Herald added subscribers: jplehr, kosarev, jdoerfert, sstefan1, kerbowa, jvesely. Herald added a reviewer: jdoerfert. Fix tests/code by adding parentheses around the conditional operator expression Repository: rG

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. In D147844#4293299 , @cjdb wrote: > I think this is a good diagnostic to add: it improves readability and > eliminates ambiguities. My only request is that if there isn't already a > FixIt hint, one be added, please. @cjb

[PATCH] D147844: [clang][Sema]Print diagnostic warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515978. chaitanyav added a comment. Revise commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515974. chaitanyav marked an inline comment as done. chaitanyav added a comment. Modify the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515687. chaitanyav added a comment. Fix indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav added a comment. @aaron.ballman please take a look. I filed a issue that premerge checks are not working on AIX https://github.com/google/llvm-premerge-checks/issues/441 Not sure why the TSAN, MSAN and ASAN checks are failing on libcxx Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515591. chaitanyav added a comment. Place parentheses around conditional expression to prevent precedence warnings since -Werror is enabled on build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515513. chaitanyav added a comment. clang-format the changes to the file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

chaitanyav updated this revision to Diff 515492. chaitanyav added a comment. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. Place parentheses around conditional expression to prevent precedence warnings since -Werror is enabled on build Repository: rG LLVM Github

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515445. chaitanyav added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Place parentheses around conditional operator since & has higher precedence Repository: rG LLVM Github

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515394. chaitanyav added a comment. Update test to use parentheses around conditional operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515367. chaitanyav added a comment. Update SemaCXX tests to use parentheses around conditional operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav marked 2 inline comments as done. chaitanyav added a comment. @aaron.ballman I have made more changes so that the warning is emitted on other integer expressions where the opertors has higher precedence than conditional operator. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515130. chaitanyav added a comment. Emit warning when implicit cast from int to bool in an conditional operator expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. In D147844#4281288 , @aaron.ballman wrote: > In D147844#4278384 , @chaitanyav > wrote: > >> @aaron.ballman am looking into this. If i change it back to >> `operation int();` >> and

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. @aaron.ballman am looking into this. If i change it back to `operation int();` and add `Stream& operator<<(bool)` I get ` - error: 'warning' diagnostics expected but not seen: File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 514702. chaitanyav added a comment. Update release notes about the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav reclaimed this revision. chaitanyav added a comment. re-opening the revision to make further updates as per comments on the github issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. @aaron.ballman Please review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 ___ cfe-commits mailing list

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. output for testcases mentioned in https://github.com/llvm/llvm-project/issues/61943 test.cpp:6:30: warning: overloaded operator << has higher precedence than comparison operator [-Woverloaded-shift-op-parentheses] std::cout << "Test" << a == 5 ? 1 : 0;

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav created this revision. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes issue https://github.com/llvm/llvm-project/issues/61943 Repository: rG LLVM Github Monorepo

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

This revision was automatically updated to reflect the committed changes. Closed by commit rGa590d8634308: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments… (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav added a comment. @dang Please review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146866/new/ https://reviews.llvm.org/D146866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav updated this revision to Diff 509429. chaitanyav added a comment. Add comment to indicate that id* is not an qualified id type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146866/new/ https://reviews.llvm.org/D146866 Files:

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav added a comment. looks like its waiting on libcxx build(https://buildkite.com/llvm-project/premerge-checks/builds/143382#job-01872209-2788-44ef-930c-11e741ff906e) and it is actively being debugged as per comments on other differential. Repository: rG LLVM Github Monorepo

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav added a comment. @dang @ributzka Please review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146866/new/ https://reviews.llvm.org/D146866 ___ cfe-commits mailing list

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc13ccf1fbabe: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type… (authored by chaitanyav). Repository: rG LLVM Github

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9173365a93: Fix highlighting issue with _complex and initialization list with more than 2… (authored by chaitanyav). Repository: rG LLVM Github

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked 3 inline comments as done. chaitanyav added a comment. Thank you, I will commit myself. Should i wait for the build to finish?. this will be my first direct commit to repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav updated this revision to Diff 507750. chaitanyav marked an inline comment as not done. chaitanyav added a comment. one diagnostic per line when there are multiple diagnostics expected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav added a comment. @dang Please review the test/output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146671/new/ https://reviews.llvm.org/D146671 ___ cfe-commits mailing list

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav updated this revision to Diff 507725. chaitanyav added a comment. update test to check for id type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146671/new/ https://reviews.llvm.org/D146671 Files:

[PATCH] D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav added a comment. Will update the test to also include a Id instance method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146671/new/ https://reviews.llvm.org/D146671 ___ cfe-commits mailing

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked an inline comment as done. chaitanyav added a comment. I reported the flang failures https://github.com/llvm/llvm-project/issues/61634 and it was reverted. How can i trigger a new build with TOT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146671: Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked an inline comment as done. chaitanyav added a comment. @aaron.ballman Please review. Comment at: clang/test/Sema/complex-init-list.c:37 struct teststruct invalid1 = { 1, 2 }; // expected-warning {{excess elements}} -_Complex float invalid2 = { 1, 2, 3 }; //

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav updated this revision to Diff 507479. chaitanyav added a comment. Added tests to check for the right diagnostic messages and highlighting at correct place Update the release docs about the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav added a comment. Please review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146503/new/ https://reviews.llvm.org/D146503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav added a comment. test outputs for C, C++ _Complex float invalid2 = { 1, 2, 3 }; ^ test.cpp:2:34: error: excess elements in scalar initializer _Complex double dd = {1.0, 2.0 , 3.0}; ^~~ test.cpp:3:32: error:

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav updated this revision to Diff 507090. chaitanyav added a comment. Only proceed with scalar initialization if number of elements is less than 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146503/new/ https://reviews.llvm.org/D146503

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav added a comment. It will fall through to scalar type to do field wise initialization _Complex double gx = {1.0}; _Complex double dx = {}; I think i get what you are saying, we can directly say that it has excess elements without having to do the field wise initialization.

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav added a comment. test.cpp:2:34: error: excess elements in scalar initializer _Complex double dd = {1.0, 2.0 , 3.0}; ^~~ test.cpp:3:32: error: excess elements in scalar initializer _Complex float fd = {1.0, 2.0, 3.0, 4.0, 5.0};

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav created this revision. chaitanyav added a reviewer: tbaeder. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/61518 Repository: rG LLVM

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav added a comment. Name: NagaChaitanya Vellanki email: pnag...@protonmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D146354 ___ cfe-commits mailing

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav added a comment. Thank you, Please go ahead and Commit the change. I don't have commit access, Will follow the instructions on the page to get access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav added a comment. The debian build is failing because of this https://github.com/google/llvm-premerge-checks/issues/436 The windows build is failing because of https://github.com/llvm/llvm-project/issues/61519, i see that the fix

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav updated this revision to Diff 506309. chaitanyav added a comment. - Update reference output in underscored.c - combine return and append semicolon fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav updated this revision to Diff 506308. chaitanyav added a comment. - Update reference output in underscored.c - combine return and append semicolon fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/

[PATCH] D146363: Update reference output in underscored.c

chaitanyav created this revision. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. update reference output in underscored.c, combine

[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes