[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecb00a77624c: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to… (authored by nathawes). Repository: rG LLVM Github Mo

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 320646. nathawes added a comment. Made the following changes as a speculative fix for the windows test failures in the pre-merge checks: - When appending the remaining path components to the external redirect path of a directory-remap entry, use the separa

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 320257. nathawes marked an inline comment as done. nathawes edited the summary of this revision. nathawes set the repository for this revision to rG LLVM Github Monorepo. nathawes added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-c

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes marked 6 inline comments as done. nathawes added a comment. @JDevlieghere and @dexonsmith would you mind taking another look? I ended up changing the 'lookup' functions to drop the ExternalRedirect out param and supply that via a new 'LookupResult' return value that also gives the matc

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 319505. nathawes added a comment. - Updated the yaml for the new kind of virtual directory (that maps to a directory in the external filesystem) to have a distinct value for its 'type' field ('directory-remap') to better distinguish it from the existing 'd

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes planned changes to this revision. nathawes added a comment. Thanks for reviewing @dexonsmith! > I don't see a test for a case where the mapped directory already exists in > the external FS ... Unless I just missed it, can you add one? I believe the `clang/test/VFS/directory.c` regressi

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 317157. nathawes edited the summary of this revision. nathawes added a comment. Moved the change combining OverlayFSDirIterImpl and VFSFromYamlDirIterImpl in a single implementation into a separate NFC patch (https://reviews.llvm.org/D94857) CHANGES SINCE

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes planned changes to this revision. nathawes added a comment. Yeah, certainly. Let me put that up separately and update this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94844/new/ https://reviews.llvm.org/D94844

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes created this revision. nathawes added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, hiraditya. nathawes requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously file entries in the -ivfsoverlay

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814 ___ cfe-

[PATCH] D58986: Fix typo in string returned from index::getSymbolKindString for SymbolKind::ConversionFunction

nathawes created this revision. nathawes added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. This patch updates SymbolKind::ConversionFunction's string from "coversion-func" to "conversion-func" and extends the Index/Core/index-source.cpp t

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes added a comment. Herald added a subscriber: ormris. In D58814#1415607 , @gribozavr wrote: > > These references were added to support using the index data for symbol > > rename. > > Understood -- thank you for providing the context (the original c

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes requested changes to this revision. nathawes added a comment. This revision now requires changes to proceed. These references were added to support using the index data for symbol rename. I.e. so that when you rename the class, you can use the index data to find all occurrences of its n

[PATCH] D58478: [index-while-building] FileIndexRecord

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing l

[PATCH] D39050: Add index-while-building support to Clang

nathawes updated this revision to Diff 153190. nathawes added a comment. Updated to apply on top-of-tree. https://reviews.llvm.org/D39050 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt include/clang/Basic/Diagnostic.td include/clang/Basic/DiagnosticGroups

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. In https://reviews.llvm.org/D39050#1037008, @malaperle wrote: > In https://reviews.llvm.org/D39050#1036394, @nathawes wrote: > > > @malaperle Just to clarify, what's the particular end-loc we're talking > > about here? e.g. for a function call, would this be the end of

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. In https://reviews.llvm.org/D39050#1036249, @malaperle wrote: > In https://reviews.llvm.org/D39050#1021204, @malaperle wrote: > > > For computing the start/end-loc of function bodies, I tried the > > SingleFileParseMode and SkipFunctionBodies separately ( as a start). T

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. @ioeric I'm working on a few other priorities over the next few weeks, sorry, but should get back to this relatively soon after that. I would just land it, but I expect some downstream breakage I want to make sure I have time to fix. @malaperle Sounds good – I'll keep

[PATCH] D42588: [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rC Clang https://reviews.llvm.org/D42588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D39050: Add index-while-building support to Clang

nathawes updated this revision to Diff 130496. nathawes marked 6 inline comments as done. nathawes added a comment. - Applied the various refactorings suggested by @ioeric - Extended c-index-test with a new option to print out the collected unit indexing data, and - Added tests for the unit index

[PATCH] D39050: Add index-while-building support to Clang

nathawes planned changes to this revision. nathawes marked 32 inline comments as done. nathawes added a comment. @ioeric I should have an updated patch up shortly with your inline comments addressed + new tests. Thanks again for reviewing! Comment at: include/clang/Index/Index

[PATCH] D39050: Add index-while-building support to Clang

nathawes updated this revision to Diff 127568. nathawes added a comment. Fix out of data header comment in FileIndexData.h https://reviews.llvm.org/D39050 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt include/clang/Basic/Diagnostic.td include/clang/Basic

[PATCH] D39050: Add index-while-building support to Clang

nathawes updated this revision to Diff 127412. nathawes marked an inline comment as done. nathawes added a comment. I've refactored the indexing/dependency data collection out from the writing with the new IndexUnitDataConsumer class, and made other smaller changes to address the feedback from @

[PATCH] D39050: Add index-while-building support to Clang

nathawes marked 45 inline comments as done. nathawes added inline comments. Comment at: lib/Index/FileIndexRecord.h:51 +public: + FileIndexRecord(FileID FID, bool isSystem) : FID(FID), IsSystem(isSystem) {} + ioeric wrote: > s/isSystem/IsSystem/ > > Also, I won

[PATCH] D39050: Add index-while-building support to Clang

nathawes planned changes to this revision. nathawes added a comment. Thanks for taking another look @ioeric – I'll work through your comments and update. https://reviews.llvm.org/D39050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D39050: Add index-while-building support to Clang

nathawes updated this revision to Diff 126065. nathawes added a comment. Herald added a subscriber: mgrang. Worked through the comments from @ioeric and split the code for writing out the collected indexing data into a separate patch. https://reviews.llvm.org/D39050 Files: include/clang/Basi

[PATCH] D39050: Add index-while-building support to Clang

nathawes added inline comments. Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:170 +Act = index::createIndexDataRecordingAction(FEOpts, std::move(Act)); +CI.setGenModuleActionWrapper(&index::createIndexDataRecordingAction); + } ioeric wrote:

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. Thanks for the feedback @malaperle! Comment at: include/indexstore/IndexStoreCXX.h:84 + + std::pair getLineCol() { +unsigned line, col; malaperle wrote: > From what I understand, this returns the beginning of the occurrence. It >

[PATCH] D39050: Add index-while-building support to Clang

nathawes planned changes to this revision. nathawes added a comment. In https://reviews.llvm.org/D39050#920451, @ioeric wrote: > In https://reviews.llvm.org/D39050#900830, @arphaman wrote: > > > I think this patch should be split into a number of smaller patches to help > > the review process. >

[PATCH] D39050: Add index-while-building support to Clang

nathawes added inline comments. Comment at: lib/Index/IndexRecordHasher.cpp:103 + COMBINE_HASH(Hasher.hash(param->getType())); +} +return Hash; arphaman wrote: > Should you hash the return type as well? The return type doesn't affect the function's U

[PATCH] D39050: Add index-while-building support to Clang

nathawes planned changes to this revision. nathawes added a comment. Thanks @arphaman! I'll work through your comments and update. Comment at: include/clang/Index/IndexDataStoreSymbolUtils.h:13 + +#include "indexstore/indexstore.h" +#include "clang/Index/IndexSymbol.h"

[PATCH] D36641: [index] Update indexing to handle CXXDeductionGuideDecls properly

nathawes created this revision. CXXDeductionGuideDecls can't be referenced so there's no need to output a symbol occurrence for them. Also handle DeducedTemplateSpecializationTypeLocs in the TypeIndexer so we don't miss the symbol occurrences of the corresponding template decls. https://revie

[PATCH] D31179: Objective-C categories should support attributes

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Thanks for this – looks good to me! Repository: rL LLVM https://reviews.llvm.org/D31179 ___ cfe-commits mailing list cfe-commits@lists.llv