https://github.com/changkhothuychung created
https://github.com/llvm/llvm-project/pull/75902
Created a PR to fix issue #71675
>From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”>
Date: Tue, 19 Dec 2023 00:03:28 -0800
Subj
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”>
Date: Tue, 19 Dec 2023 00:03:28 -0800
Subject: [PATCH 1/2] return false if t
changkhothuychung wrote:
Thanks, I will look into adding tests!
Regarding the floating point option, are we converting the value to float type
and just print it to the output stream? @cor3ntin
https://github.com/llvm/llvm-project/pull/75902
___
cfe
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”>
Date: Tue, 19 Dec 2023 00:03:28 -0800
Subject: [PATCH 1/3] return false if t
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 0eb58740f33f2eef29c28e43e78118f9f0eea4b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CNhat?= <“nhat7...@gmail.com”>
Date: Tue, 19 Dec 2023 00:03:28 -0800
Subject: [PATCH 1/4] return false if t
changkhothuychung wrote:
Thanks everyone for the comments! I will address as soon as I can.
https://github.com/llvm/llvm-project/pull/75902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue &V,
QualType T,
case BuiltinType::WChar_U: {
unsigned TyWidth = Context.getIntWidth(T);
assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width");
+ if (V.g
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?=
Message-ID:
In-Reply-To:
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CNhat?=
Date: Mon, 1
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?=
Message-ID:
In-Reply-To:
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9C
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?=
Message-ID:
In-Reply-To:
@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue &V,
QualType T,
case BuiltinType::WChar_U: {
unsigned TyWidth = Context.getIntWi
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,Nhat Nguyen
Message-ID:
In-Reply-To:
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,Nhat Nguyen
Message-ID:
In-Reply-To:
changkhothuychung wrote:
> Looks like all the tests disappeared? Only thing I see is the code change.
> Also, no release note is currently present.
Hi I am
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?=
Message-ID:
In-Reply-To:
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001
From:
13 matches
Mail list logo