[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2021-04-06 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 added a comment. I don't have commit access, please push this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93185/new/ https://reviews.llvm.org/D93185 ___ cfe-commits mailing list

[PATCH] D96738: [docs] Fix doxygen comments wrongly attached to the clang namespace

2021-02-15 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 created this revision. Herald added a subscriber: zzheng. nicolas17 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looking at the Doxygen-generated documentation for the clang namespace currently shows several random comments

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2020-12-13 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 created this revision. nicolas17 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code example for "RecursiveASTVisitor based ASTFrontendActions" was using unique_ptr(new X) when creating the AST consumer; change it to use

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

2020-02-12 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:484 +const NoteTag *ChangeTag = + getChangeTag(C, "shrinked from the right by 1 position", ContReg, ContE); // For vector-like and deque-like containers invalidate

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

2020-02-12 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 added a comment. In D74385#1872298 , @serge-sans-paille wrote: > Sure, can you just confirm that you're this guy: https://github.com/nicolas17 > (I need that for proper email attribution) Yes that's me :) Repository: rG LLVM Github

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

2020-02-11 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 added a comment. I don't have commit access, can someone push this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74385/new/ https://reviews.llvm.org/D74385 ___ cfe-commits mailing

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

2020-02-10 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace some #includes in ARCMigrate source files with more specific includes and forward declarations. This reduces the number of files that need to be rebuilt when a header changes (and