[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi by default (PR #146795)

2025-07-09 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 closed https://github.com/llvm/llvm-project/pull/146795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi by default (PR #146795)

2025-07-08 Thread Nilanjana Basu via cfe-commits
nilanjana87 wrote: Heads up: I'll merge this branch tomorrow. Let me know if any of the downstream users need more time before this goes in. > LGTM, please give downstream users ~1w to add the opt out flag to build > configs before landing this. > > CC @llvm/pr-subscribers-pgo for visibility

[clang] [Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (PR #146996)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 closed https://github.com/llvm/llvm-project/pull/146996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (PR #146996)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 updated https://github.com/llvm/llvm-project/pull/146996 >From 93579c9f09516d2eb5cc58ee321fb3a93b2c2bc4 Mon Sep 17 00:00:00 2001 From: Nilanjana Basu Date: Thu, 3 Jul 2025 21:05:20 -0700 Subject: [PATCH 1/3] [Driver][Test] pgo-sample-use-profi.c: Specify targets t

[clang] [Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (PR #146996)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 updated https://github.com/llvm/llvm-project/pull/146996 >From 93579c9f09516d2eb5cc58ee321fb3a93b2c2bc4 Mon Sep 17 00:00:00 2001 From: Nilanjana Basu Date: Thu, 3 Jul 2025 21:05:20 -0700 Subject: [PATCH 1/2] [Driver][Test] pgo-sample-use-profi.c: Specify targets t

[clang] [Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (PR #146996)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 edited https://github.com/llvm/llvm-project/pull/146996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (PR #146996)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 edited https://github.com/llvm/llvm-project/pull/146996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (PR #146996)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 created https://github.com/llvm/llvm-project/pull/146996 This test reportedly fails for some targets (e.g. AIX). Specifying targets to fix it. >From 93579c9f09516d2eb5cc58ee321fb3a93b2c2bc4 Mon Sep 17 00:00:00 2001 From: Nilanjana Basu Date: Thu, 3 Jul 2025 21:0

[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi by default (PR #146795)

2025-07-03 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 ready_for_review https://github.com/llvm/llvm-project/pull/146795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][SamplePGO] Introduce -fno_sample_profile_use_profi flag for SamplePGO (PR #145957)

2025-07-02 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 updated https://github.com/llvm/llvm-project/pull/145957 >From f0893f3b64661fc5a6ab39e7bdcc86a9142221a1 Mon Sep 17 00:00:00 2001 From: Nilanjana Basu Date: Thu, 26 Jun 2025 11:54:14 -0700 Subject: [PATCH 1/3] [Clang][Driver][SamplePGO] Enable -fsample-profile-use

[clang] [Clang][Driver][SamplePGO] Introduce -fno_sample_profile_use_profi flag for SamplePGO (PR #145957)

2025-07-02 Thread Nilanjana Basu via cfe-commits
@@ -1,4 +1,19 @@ -/// Test if profi flat is enabled in frontend as user-facing feature. -// RUN: %clang --target=x86_64 -c -fsample-profile-use-profi -fprofile-sample-use=/dev/null -### %s 2>&1 | FileCheck %s +/// Ensure that profi flag is enabled by default in frontend for Sampl

[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi for SamplePGO (PR #145957)

2025-06-27 Thread Nilanjana Basu via cfe-commits
nilanjana87 wrote: > We evaluated profi internally (at Google) last year. Our configuration uses > AutoFDO with [flow-sensitive discriminators > ](https://lists.llvm.org/pipermail/llvm-dev/2020-November/146694.html) > (FS-AFDO). We found slight regressions with this configuration and didn't >

[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi for SamplePGO (PR #145957)

2025-06-26 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 ready_for_review https://github.com/llvm/llvm-project/pull/145957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi for SamplePGO (PR #145957)

2025-06-26 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 edited https://github.com/llvm/llvm-project/pull/145957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi for SamplePGO (PR #145957)

2025-06-26 Thread Nilanjana Basu via cfe-commits
https://github.com/nilanjana87 created https://github.com/llvm/llvm-project/pull/145957 - Enable -fsample-profile-use-profi flag by default for SamplePGO - Add -fno_sample_profile_use_profi flag for opting out >From f0893f3b64661fc5a6ab39e7bdcc86a9142221a1 Mon Sep 17 00:00:00 2001 From: Nilanja