[llvm] [clang] [IR] Fix GEP offset computations for vector GEPs (PR #75448)

2024-01-10 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: Alive2 is complaining about one of the tests: ```llvm @Global = global 10 bytes, align 1 define void @test_overaligned_vec(i8 %B) { %A = gep ptr @Global, 4 x i64 0, 4 x i64 1 store i8 %B, ptr %A, align 1 ret void } => @Global = global 10 bytes, align 1 define void @test_

[llvm] [clang] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: We don't have a `isGuaranteedNotToBeUndef` only function, so that's the only way. I would leave a fixme, since this call can be removed if we ever manage to kill undef. Thanks for your help! 🙂 https://github.com/llvm/llvm-project/pull/72912 ___

[llvm] [clang] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: Here's a simple-ish example: ```llvm ; Transforms/InstCombine/add.ll define i5 @zext_sext_not(i4 %x) { %zx = zext i4 %x to i5 %notx = xor i4 %x, 15 %snotx = sext i4 %notx to i5 %r = add i5 %zx, %snotx ret i5 %r } => define i5 @zext_sext_not(i4 %x) { %zx = zext i4 %x

[clang] [llvm] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-12-04 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: FWIW, Alive2 is complaining about this commit. These patches are not safe w.r.t. undef. https://github.com/llvm/llvm-project/pull/72912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-08 Thread Nuno Lopes via cfe-commits
https://github.com/nunoplopes closed https://github.com/llvm/llvm-project/pull/65596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-08 Thread Nuno Lopes via cfe-commits
@@ -14,8 +14,8 @@ class B : A { // NO-AS: @_ZTISt9type_info = external constant ptr // AS: @_ZTIi = external addrspace(1) constant ptr addrspace(1) // NO-AS: @_ZTIi = external constant ptr -// AS: @_ZTVN10__cxxabiv117__class_type_infoE = external addrspace(1) global ptr addrsp

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-08 Thread Nuno Lopes via cfe-commits
https://github.com/nunoplopes updated https://github.com/llvm/llvm-project/pull/65596: >From 8585d37c6526d46e08efb2b573ca9ba50dd68a9b Mon Sep 17 00:00:00 2001 From: Nuno Lopes Date: Thu, 7 Sep 2023 11:07:03 +0100 Subject: [PATCH 1/2] [clang][CodeGen] Switch declaration of vtable information to

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nuno Lopes via cfe-commits
nunoplopes wrote: Note that changing the memory accesses performed by clang (load or store) *is* an ABI change at IR level because of UB. Also, please have a look at the existing `-ffine-grained-bitfield-accesses` flag and the discussions around it and IPO. https://github.com/llvm/llvm-projec

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-07 Thread Nuno Lopes via cfe-commits
https://github.com/nunoplopes review_requested https://github.com/llvm/llvm-project/pull/65596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-07 Thread Nuno Lopes via cfe-commits
https://github.com/nunoplopes review_requested https://github.com/llvm/llvm-project/pull/65596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-07 Thread Nuno Lopes via cfe-commits
https://github.com/nunoplopes created https://github.com/llvm/llvm-project/pull/65596: Continuing the discussion in https://discourse.llvm.org/t/codegen-layout-of-si-class-type-info-doesnt-match-the-actual-size/73274 Before we had this code: @_ZTVN10__cxxabiv117__class_type_infoE = external gl

[clang] 2482dbf - [Clang] Use poison instead of undef where its used as placeholder [NFC]

2022-12-11 Thread Nuno Lopes via cfe-commits
Author: Manuel Brito Date: 2022-12-11T16:18:06Z New Revision: 2482dbff461e981203f9c691b24d6017de46a441 URL: https://github.com/llvm/llvm-project/commit/2482dbff461e981203f9c691b24d6017de46a441 DIFF: https://github.com/llvm/llvm-project/commit/2482dbff461e981203f9c691b24d6017de46a441.diff LOG:

[clang] 481170c - [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

2022-12-06 Thread Nuno Lopes via cfe-commits
Author: Manuel Brito Date: 2022-12-06T12:40:33Z New Revision: 481170cb551124ed89353dd55a89b1d9971e9a6d URL: https://github.com/llvm/llvm-project/commit/481170cb551124ed89353dd55a89b1d9971e9a6d DIFF: https://github.com/llvm/llvm-project/commit/481170cb551124ed89353dd55a89b1d9971e9a6d.diff LOG:

[clang] 553bdf4 - [NFC][clang] Strengthen checks in matrix-type-operators.c

2022-12-05 Thread Nuno Lopes via cfe-commits
Author: John McIver Date: 2022-12-05T10:13:35Z New Revision: 553bdf4fde5a4638f3a7764a4f6c209b9cd36a09 URL: https://github.com/llvm/llvm-project/commit/553bdf4fde5a4638f3a7764a4f6c209b9cd36a09 DIFF: https://github.com/llvm/llvm-project/commit/553bdf4fde5a4638f3a7764a4f6c209b9cd36a09.diff LOG: [

[clang] 64428c0 - [NFC][clang] Strengthen checks in matrix-type-operators.cpp

2022-12-05 Thread Nuno Lopes via cfe-commits
Author: John McIver Date: 2022-12-05T10:12:25Z New Revision: 64428c0ddf55295c270569db7f581ac7bedeff87 URL: https://github.com/llvm/llvm-project/commit/64428c0ddf55295c270569db7f581ac7bedeff87 DIFF: https://github.com/llvm/llvm-project/commit/64428c0ddf55295c270569db7f581ac7bedeff87.diff LOG: [

[clang] ee13633 - [NFC][clang] Strengthen checks in avx512fp16-builtins.c

2022-12-04 Thread Nuno Lopes via cfe-commits
Author: John McIver Date: 2022-12-04T14:57:43Z New Revision: ee13633c46cda3826d384d60c85057085025eebb URL: https://github.com/llvm/llvm-project/commit/ee13633c46cda3826d384d60c85057085025eebb DIFF: https://github.com/llvm/llvm-project/commit/ee13633c46cda3826d384d60c85057085025eebb.diff LOG: [

[clang] 2389488 - [NFC][clang] Strengthen checks in avx512f-builtins.c

2022-12-04 Thread Nuno Lopes via cfe-commits
Author: John McIver Date: 2022-12-04T14:55:41Z New Revision: 23894884377372d2ea048b452bf9a68de3e8515a URL: https://github.com/llvm/llvm-project/commit/23894884377372d2ea048b452bf9a68de3e8515a DIFF: https://github.com/llvm/llvm-project/commit/23894884377372d2ea048b452bf9a68de3e8515a.diff LOG: [

[clang] 57ba07c - [clang] fix typo in unit test

2022-10-18 Thread Nuno Lopes via cfe-commits
Author: Susana Monteiro Date: 2022-10-18T16:32:13+01:00 New Revision: 57ba07c06f8b68d401f47ab115259fa2dd3d7136 URL: https://github.com/llvm/llvm-project/commit/57ba07c06f8b68d401f47ab115259fa2dd3d7136 DIFF: https://github.com/llvm/llvm-project/commit/57ba07c06f8b68d401f47ab115259fa2dd3d7136.dif

[clang] 14e2592 - [clang][CodeGen] Use poison instead of undef as placeholder in ARM builtins [NFC]

2022-10-07 Thread Nuno Lopes via cfe-commits
Author: Manuel Brito Date: 2022-10-07T12:50:59+01:00 New Revision: 14e2592ff6112d1869ba1533d058822200162bf1 URL: https://github.com/llvm/llvm-project/commit/14e2592ff6112d1869ba1533d058822200162bf1 DIFF: https://github.com/llvm/llvm-project/commit/14e2592ff6112d1869ba1533d058822200162bf1.diff

[clang] 6a1ccf6 - Revert "[NFC] Add some additional features to MultiLevelTemplateArgumentList"

2022-07-22 Thread Nuno Lopes via cfe-commits
Author: Nuno Lopes Date: 2022-07-22T21:33:22+01:00 New Revision: 6a1ccf61cdf80c793f9c699ada33af5d85263b30 URL: https://github.com/llvm/llvm-project/commit/6a1ccf61cdf80c793f9c699ada33af5d85263b30 DIFF: https://github.com/llvm/llvm-project/commit/6a1ccf61cdf80c793f9c699ada33af5d85263b30.diff LO

[clang] 571ae1a - fix test expected output (fixes arm buildbot failure) [NFC]

2022-06-12 Thread Nuno Lopes via cfe-commits
Author: Nuno Lopes Date: 2022-06-12T19:29:00+01:00 New Revision: 571ae1abebb6b102cc2e95e3abf8e81757fba35a URL: https://github.com/llvm/llvm-project/commit/571ae1abebb6b102cc2e95e3abf8e81757fba35a DIFF: https://github.com/llvm/llvm-project/commit/571ae1abebb6b102cc2e95e3abf8e81757fba35a.diff LO

[clang] 4dd1bff - [clang][CodeGen] Switch a few placeholders from UndefValue to PoisonValue

2022-06-12 Thread Nuno Lopes via cfe-commits
Author: Nuno Lopes Date: 2022-06-12T19:07:59+01:00 New Revision: 4dd1bffc9dac02b34bd1de78808edd9a5955c987 URL: https://github.com/llvm/llvm-project/commit/4dd1bffc9dac02b34bd1de78808edd9a5955c987 DIFF: https://github.com/llvm/llvm-project/commit/4dd1bffc9dac02b34bd1de78808edd9a5955c987.diff LO

[clang] 5fc9449 - [DeadArgElim] Use poison instead of undef as placeholder for dead arguments

2022-05-19 Thread Nuno Lopes via cfe-commits
Author: Nuno Lopes Date: 2022-05-19T18:00:24+01:00 New Revision: 5fc9449c962a0703a658aa8e29162e00dc2fecf1 URL: https://github.com/llvm/llvm-project/commit/5fc9449c962a0703a658aa8e29162e00dc2fecf1 DIFF: https://github.com/llvm/llvm-project/commit/5fc9449c962a0703a658aa8e29162e00dc2fecf1.diff LO

[clang] 7b1cb72 - [SROA] Switch replacement of dead/UB/unreachable ops from undef to poison

2022-01-10 Thread Nuno Lopes via cfe-commits
Author: Nuno Lopes Date: 2022-01-10T14:04:26Z New Revision: 7b1cb72ad944b460c42adf6df635263064a457f3 URL: https://github.com/llvm/llvm-project/commit/7b1cb72ad944b460c42adf6df635263064a457f3 DIFF: https://github.com/llvm/llvm-project/commit/7b1cb72ad944b460c42adf6df635263064a457f3.diff LOG: [S

[clang] 9231045 - Make LLVM build in C++20 mode

2020-12-17 Thread Nuno Lopes via cfe-commits
Author: Barry Revzin Date: 2020-12-17T10:44:10Z New Revision: 92310454bf0f1f9686f38afd11756c7d046495c9 URL: https://github.com/llvm/llvm-project/commit/92310454bf0f1f9686f38afd11756c7d046495c9 DIFF: https://github.com/llvm/llvm-project/commit/92310454bf0f1f9686f38afd11756c7d046495c9.diff LOG:

r312870 - clang fix for LLVM API change: isKnownNonNull -> isKnownNonZero

2017-09-09 Thread Nuno Lopes via cfe-commits
Author: nlopes Date: Sat Sep 9 11:25:36 2017 New Revision: 312870 URL: http://llvm.org/viewvc/llvm-project?rev=312870&view=rev Log: clang fix for LLVM API change: isKnownNonNull -> isKnownNonZero Differential Revision: https://reviews.llvm.org/D37628 Modified: cfe/trunk/lib/CodeGen/CGCall.c

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

2015-08-11 Thread Nuno Lopes via cfe-commits
nlopes added a subscriber: nlopes. Comment at: include/cstring:96 @@ +95,3 @@ +int strncmp(const char* __s1, const char* __s2, size_t __n) +{ return ::memcmp(__s1, __s2, __n); } + typo here. http://reviews.llvm.org/D11948 _