[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-08-25 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147163 >From 4e0cf4e00d4cfd837e9dfd9e6aed88aca1de295a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 6 Jul 2025 00:35:48 +0300 Subject: [PATCH 1/6] [Clang] fix crash in codegen caused by deferred asm

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-08-25 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147163 >From 4e0cf4e00d4cfd837e9dfd9e6aed88aca1de295a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 6 Jul 2025 00:35:48 +0300 Subject: [PATCH 1/6] [Clang] fix crash in codegen caused by deferred asm

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] Revert "[Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists" (PR #154369)

2025-08-19 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/154369 >From 68f6b7663bee98487f3a854c4bd386e098fef38c Mon Sep 17 00:00:00 2001 From: "Oleksandr T." Date: Tue, 19 Aug 2025 19:02:07 +0300 Subject: [PATCH] =?UTF-8?q?Revert=20"[Clang]=20improve=20-Wstring-concaten?=

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-19 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists (PR #154018)

2025-08-19 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @ilovepi @nathanchance @AaronBallman I’ve opened a PR to roll back the changes for now, to finalize the intended behavior of this flag. https://github.com/llvm/llvm-project/pull/154018 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] Revert "[Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists" (PR #154369)

2025-08-19 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/154369 Reverts llvm/llvm-project#154018 >From 68f6b7663bee98487f3a854c4bd386e098fef38c Mon Sep 17 00:00:00 2001 From: "Oleksandr T." Date: Tue, 19 Aug 2025 19:02:07 +0300 Subject: [PATCH] =?UTF-8?q?Revert=20"[Clang

[clang] [Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists (PR #154018)

2025-08-18 Thread Oleksandr T. via cfe-commits
@@ -168,3 +168,17 @@ const char *extra_parens_to_suppress_warning[] = { "promise"), "shared_future" }; + +const char *multiple_missing_commas[] = { +"1", +"2" // expected-note {{place parentheses around the string literal to silence warning}} +"3", // expe

[clang] [Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists (PR #154018)

2025-08-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/154018 >From d9cd8679c7594da4dc31ca736a439b113a1239d6 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 17 Aug 2025 16:00:48 +0300 Subject: [PATCH 1/2] [Clang] improve -Wstring-concatenation to warn on ev

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-17 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman I’ve moved the diagnostic under the `-Wattribute-preprocessor-tokens` warning flag and made it a `pedantic` diagnostic, which will be triggered in C++. Is that the behavior you were aiming for? @cor3ntin should `/` be disallowed as well, or are `#` and `/` the

[clang] [Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists (PR #154018)

2025-08-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/154018 Fixes #153745 --- This PR addresses a limitation in `-Wstring-concatenation`, where only the first missing comma in an initializer list was diagnosed. >From d9cd8679c7594da4dc31ca736a439b113a1239d6 Mon Sep

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] Fixed a crash when parsing #embed parameters with unmatched closing brackets (PR #152877)

2025-08-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/152877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed a crash when parsing #embed parameters with unmatched closing brackets (PR #152877)

2025-08-11 Thread Oleksandr T. via cfe-commits
@@ -94,6 +94,9 @@ char buffer[] = { #embed "embed_parsing_errors.c" prefix() // OK: tokens within parens are optional #embed "embed_parsing_errors.c" prefix) // expected-error@-1 {{expected '('}} +#embed "embed_parsing_errors.c" prefix()) // expected-error {{expected identifi

[clang] [Clang] Fixed a crash when parsing #embed parameters with unmatched closing brackets (PR #152877)

2025-08-11 Thread Oleksandr T. via cfe-commits
@@ -94,6 +94,9 @@ char buffer[] = { #embed "embed_parsing_errors.c" prefix() // OK: tokens within parens are optional #embed "embed_parsing_errors.c" prefix) // expected-error@-1 {{expected '('}} +#embed "embed_parsing_errors.c" prefix()) // expected-error {{expected identifi

[clang] [Clang] Fixed a crash when parsing #embed parameters with unmatched closing brackets (PR #152877)

2025-08-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/152877 Fixes #152829 --- This patch addresses the issue where the preprocessor could crash when parsing `#embed` parameters containing unmatched closing brackets ```cpp #embed "file" prefix(]) #embed "file" pref

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-05 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-04 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-04 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/8] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-08-04 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/7] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-31 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @erichkeane @AaronBallman Thanks — it seems the changes will need to be revisited based on further guidance from WG21. Would it make sense to close this PR for now? https://github.com/llvm/llvm-project/pull/147308 ___ cfe-commits m

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-30 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/6] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-30 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/5] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/5] [Clang] disallow operator in attribute argument list

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/9] [Analyzer] support parenthesized list initialization

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @steakhal should other test cases be removed? https://github.com/llvm/llvm-project/pull/148988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
@@ -4114,3 +4124,35 @@ void *ProgramStateTrait::GDMIndex() { } void ExprEngine::anchor() { } + +void ExprEngine::ConstructInitList(const Expr *E, ArrayRef Args, + bool IsTransparent, ExplodedNode *Pred, + Exp

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/8] [Analyzer] support parenthesized list initialization

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/7] [Analyzer] support parenthesized list initialization

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/7] [Analyzer] support parenthesized list initialization

[clang] [analyzer] Support parenthesized list initialization (CXXParenListInitExpr) (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/6] [Analyzer] support parenthesized list initialization

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/5] [Analyzer] support parenthesized list initialization

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1,13 +1,65 @@ -// RUN: %clang_analyze_cc1 -analyzer-checker=core.DivideZero -verify %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core.DivideZero -std=c++20 -verify %s -int fooPR10616 (int qX ) { +namespace GH10616 { +int foo(int qX) { int a, c, d; - d = (qX-1); -

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1,13 +1,65 @@ -// RUN: %clang_analyze_cc1 -analyzer-checker=core.DivideZero -verify %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core.DivideZero -std=c++20 -verify %s a-tarasyuk wrote: @necto Thanks. I've moved to a new file related to c++20 only https:

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/5] [Analyzer] support parenthesized list initialization

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1233,3 +1233,34 @@ void ExprEngine::VisitAttributedStmt(const AttributedStmt *A, getCheckerManager().runCheckersForPostStmt(Dst, EvalSet, A, *this); } + +void ExprEngine::VisitCXXParenListInitExpr(const CXXParenListInitExpr *E, +

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1233,3 +1233,34 @@ void ExprEngine::VisitAttributedStmt(const AttributedStmt *A, getCheckerManager().runCheckersForPostStmt(Dst, EvalSet, A, *this); } + +void ExprEngine::VisitCXXParenListInitExpr(const CXXParenListInitExpr *E, +

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1233,3 +1233,34 @@ void ExprEngine::VisitAttributedStmt(const AttributedStmt *A, getCheckerManager().runCheckersForPostStmt(Dst, EvalSet, A, *this); } + +void ExprEngine::VisitCXXParenListInitExpr(const CXXParenListInitExpr *E, +

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1233,3 +1233,34 @@ void ExprEngine::VisitAttributedStmt(const AttributedStmt *A, getCheckerManager().runCheckersForPostStmt(Dst, EvalSet, A, *this); } + +void ExprEngine::VisitCXXParenListInitExpr(const CXXParenListInitExpr *E, +

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/148988 >From 5db59d5b7f9b834762f86aa69040314e8faeb649 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 16 Jul 2025 02:09:37 +0300 Subject: [PATCH 1/3] [Analyzer] support parenthesized list initialization

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147163 >From 4e0cf4e00d4cfd837e9dfd9e6aed88aca1de295a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 6 Jul 2025 00:35:48 +0300 Subject: [PATCH 1/5] [Clang] fix crash in codegen caused by deferred asm

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-11 Thread Oleksandr T. via cfe-commits
@@ -2092,18 +2092,36 @@ Sema::SemaDiagnosticBuilder::~SemaDiagnosticBuilder() { } Sema::SemaDiagnosticBuilder -Sema::targetDiag(SourceLocation Loc, unsigned DiagID, const FunctionDecl *FD) { +Sema::targetDiag(SourceLocation Loc, unsigned DiagID, FunctionDecl *FD) { FD = FD

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147163 >From 4e0cf4e00d4cfd837e9dfd9e6aed88aca1de295a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 6 Jul 2025 00:35:48 +0300 Subject: [PATCH 1/4] [Clang] fix crash in codegen caused by deferred asm

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147163 >From 4e0cf4e00d4cfd837e9dfd9e6aed88aca1de295a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 6 Jul 2025 00:35:48 +0300 Subject: [PATCH 1/2] [Clang] fix crash in codegen caused by deferred asm

[clang] [Clang] fixed false positive redeclaration error for using enum in nested scopes (PR #147711)

2025-07-10 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/147711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fixed false positive redeclaration error for using enum in nested scopes (PR #147711)

2025-07-10 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147711 >From 20b9d9bb16f82120cee41bf6a59d3bfa34aa0d3b Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 9 Jul 2025 15:16:45 +0300 Subject: [PATCH] [Clang] fixed false positive redeclaration error for usin

[clang] [Clang] fixed false positive redeclaration error for using enum in nested scopes (PR #147711)

2025-07-10 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman could you review these changes? thanks https://github.com/llvm/llvm-project/pull/147711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147163 >From 4e0cf4e00d4cfd837e9dfd9e6aed88aca1de295a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 6 Jul 2025 00:35:48 +0300 Subject: [PATCH] [Clang] fix crash in codegen caused by deferred asm diag

[clang] [Clang] fixed false positive redeclaration error for using enum in nested scopes (PR #147711)

2025-07-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147711 >From 20b9d9bb16f82120cee41bf6a59d3bfa34aa0d3b Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Wed, 9 Jul 2025 15:16:45 +0300 Subject: [PATCH] [Clang] fixed false positive redeclaration error for usin

[clang] [Clang] fixed false positive redeclaration error for using enum in nested scopes (PR #147711)

2025-07-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/147711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fixed false positive redeclaration error for using enum in nested scopes (PR #147711)

2025-07-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/147711 Fixes #147495 --- This patch addresses the issue of false-positive redeclaration errors that occur for `using enum` declarations in nested class scopes ```cpp struct S { enum class E { A }; using enu

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/5] [Clang] disallow operator in attribute argument list

[clang-tools-extra] [clang-tidy] support ak_attr_info in diagnostic forwarding (PR #147503)

2025-07-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/147503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] support ak_attr_info in diagnostic forwarding (PR #147503)

2025-07-08 Thread Oleksandr T. via cfe-commits
@@ -544,6 +544,9 @@ void ClangTidyDiagnosticConsumer::forwardDiagnostic(const Diagnostic &Info) { case clang::DiagnosticsEngine::ak_attr: Builder << reinterpret_cast(Info.getRawArg(Index)); break; +case clang::DiagnosticsEngine::ak_attr_info: --

[clang-tools-extra] [clang-tidy] support ak_attr_info in diagnostic forwarding (PR #147503)

2025-07-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/147503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-07-08 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @mikaelholmen Thanks for pointing that out. I've opened PR https://github.com/llvm/llvm-project/pull/147503 to resolve this issue https://github.com/llvm/llvm-project/pull/144619 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang-tools-extra] [clang-tidy] support ak_attr_info in diagnostic forwarding (PR #147503)

2025-07-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/147503 This patch addresses missing support for forwarding `ak_attr_info` diagnostic arguments in `ClangTidyDiagnosticConsumer` >From 87401d6f985e85b50683027d1aa71dc326e7cf28 Mon Sep 17 00:00:00 2001 From: Oleksand

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/3] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/3] [Clang] disallow operator in attribute argument list

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-07 Thread Oleksandr T. via cfe-commits
@@ -830,6 +830,8 @@ def err_ms_property_expected_comma_or_rparen : Error< "expected ',' or ')' at end of property accessor list">; def err_ms_property_initializer : Error< "property declaration cannot have a default member initializer">; +def err_invalid_attribute_argument

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-07 Thread Oleksandr T. via cfe-commits
@@ -477,3 +477,8 @@ namespace P2361 { } alignas(int) struct AlignAsAttribute {}; // expected-error {{misplaced attributes; expected attributes here}} + +namespace GH147217 { + [[clang::annotate(#)]] void a(); // expected-error {{'#' is not allowed in attribute argument

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/3] [Clang] disallow operator in attribute argument list

[clang] [Clang] accept @tparam on variable template partial specializations (PR #147219)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/147219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] accept @tparam on variable template partial specializations (PR #147219)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147219 >From a5e5e795e2b31295f781d2398e41f46785c0f18b Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 02:52:01 +0300 Subject: [PATCH 1/2] [Clang] accept @tparam on variable template partial

[clang] [Clang] accept @tparam on variable template partial specializations (PR #147219)

2025-07-07 Thread Oleksandr T. via cfe-commits
@@ -291,6 +291,14 @@ void DeclInfo::fill() { TemplateParameters = CTPSD->getTemplateParameters(); break; } + case Decl::VarTemplatePartialSpecialization: { +const VarTemplatePartialSpecializationDecl *VTPSD = a-tarasyuk wrote: @AaronBallman than

[clang] [Clang] accept @tparam on variable template partial specializations (PR #147219)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147219 >From a5e5e795e2b31295f781d2398e41f46785c0f18b Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 02:52:01 +0300 Subject: [PATCH 1/2] [Clang] accept @tparam on variable template partial

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/147308 Fixes #147217 --- This PR addresses the parsing of attribute arguments by diagnosing and disallowing the `#` operator >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr

[clang] [Clang] accept @tparam on variable template partial specializations (PR #147219)

2025-07-06 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147219 >From a5e5e795e2b31295f781d2398e41f46785c0f18b Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 02:52:01 +0300 Subject: [PATCH] [Clang] accept @tparam on variable template partial spec

[clang] [Clang] accept @tparam on variable template partial specializations (PR #147219)

2025-07-06 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/147219 Fixes #144775 --- This patch addresses a false-positive `-Wdocumentation` warning on `@tparam` comments attached to _variable template partial specializations_ >From 2c44c8bd3c2a49ba0a2cecdcadf5d08c0e9e31

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-05 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/147163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-05 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/147163 Fixes #140375 --- This patch addresses a crash in clang’s _codegen_ stage triggered by invalid inline assembly statements under `-fopenmp`. The root cause was _deferred_ diagnostic emission (using `SemaDia

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-07-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk ready_for_review https://github.com/llvm/llvm-project/pull/144619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-06-27 Thread Oleksandr T. via cfe-commits
@@ -292,6 +297,45 @@ inline bool doesKeywordAttributeTakeArgs(tok::TokenKind Kind) { } } +inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB, + const AttributeCommonInfo &CI) { + DB.AddTaggedVal(reinterpre

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-06-27 Thread Oleksandr T. via cfe-commits
@@ -292,6 +297,45 @@ inline bool doesKeywordAttributeTakeArgs(tok::TokenKind Kind) { } } +inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB, + const AttributeCommonInfo &CI) { + DB.AddTaggedVal(reinterpre

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-06-27 Thread Oleksandr T. via cfe-commits
@@ -4694,9 +4695,9 @@ def note_protocol_decl : Note< "protocol is declared here">; def note_protocol_decl_undefined : Note< "protocol %0 has no definition">; -def err_attribute_preferred_name_arg_invalid : Error< - "argument %0 to 'preferred_name' attribute is not a typede

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-06-27 Thread Oleksandr T. via cfe-commits
@@ -1382,6 +1382,15 @@ bool SemaHLSL::handleResourceTypeAttr(QualType T, const ParsedAttr &AL) { return false; Attr *A = nullptr; + + AttributeCommonInfo ACI( a-tarasyuk wrote: I'll double-check to be sure, but my understanding is that `AttributeComm

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-06-27 Thread Oleksandr T. via cfe-commits
@@ -506,7 +506,15 @@ void clang::FormatASTNodeDiagnosticArgument( case DiagnosticsEngine::ak_attr: { const Attr *At = reinterpret_cast(Val); assert(At && "Received null Attr object!"); - OS << '\'' << At->getSpelling() << '\''; + + OS << '\''; + i

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-06-17 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/144619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix crash on invalid attribute in constexpr function (PR #144286)

2025-06-16 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +// issue144264 +constexpr void test() +{ +using TT = struct T[deprecated{}; a-tarasyuk wrote: nit: The simplified example: ```cpp namespace GH144264 { constexpr void f() { using A = struc

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/141305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/141305 >From 77641f88c5047c990df649658b6bd5fba0d395cd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sat, 31 May 2025 15:59:59 +0300 Subject: [PATCH 1/4] [Clang] add fix-it hints for unknown attributes ---

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/141305 >From 77641f88c5047c990df649658b6bd5fba0d395cd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sat, 31 May 2025 15:59:59 +0300 Subject: [PATCH 1/4] [Clang] add fix-it hints for unknown attributes ---

[clang] [Clang] use colon char instead of token name (PR #144068)

2025-06-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

2025-06-13 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @rkirsling, this test does not verify the fix https://github.com/llvm/llvm-project/pull/144069/files#diff-b87b117875d2e75dc1ef39535756591a688853bbeb7f83e5b4df6bafca111fa0R239-R241 [switch-recovery.cpp](https://github.com/llvm/llvm-project/blob/cf6ae065a042aae6324b28e99628c40bc

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/141305 >From 77641f88c5047c990df649658b6bd5fba0d395cd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sat, 31 May 2025 15:59:59 +0300 Subject: [PATCH 1/4] [Clang] add fix-it hints for unknown attributes ---

[clang] [Clang] use colon char instead of token name (PR #144068)

2025-06-13 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: > Ohh, you beat me by a minute. 😆 I suppose > https://github.com/llvm/llvm-project/pull/144069 could be closed then. You can copy the tests/changes from this PR into yours — I'll close this one. https://github.com/llvm/llvm-project/pull/144068

[clang] [Clang] use colon char instead of token name (PR #144068)

2025-06-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/144068 >From a83afe5aca4f192f378ef4b99477103b23991026 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Fri, 13 Jun 2025 15:28:20 +0300 Subject: [PATCH 1/2] [Clang] use colon char instead of token name --- c

[clang] [Clang] use colon char instead of token name (PR #144068)

2025-06-13 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: /cc @rkirsling https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

2025-06-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/144068 Fixes regression of https://github.com/llvm/llvm-project/pull/143460/files#r2144925614 >From a83afe5aca4f192f378ef4b99477103b23991026 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Fri, 13 Jun 2025

[clang] [Clang] fix missing source location for errors in macro-expanded (PR #143460)

2025-06-13 Thread Oleksandr T. via cfe-commits
@@ -832,10 +832,13 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext StmtCtx, << "'case'" << tok::colon << FixItHint::CreateReplacement(ColonLoc, ":"); } else { - SourceLocation ExpectedLoc = PP.getLocForEndOfToken(PrevTokLocation); +

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-12 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/141305 >From 77641f88c5047c990df649658b6bd5fba0d395cd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sat, 31 May 2025 15:59:59 +0300 Subject: [PATCH 1/4] [Clang] add fix-it hints for unknown attributes ---

[clang] [Clang] fix missing source location for errors in macro-expanded (PR #143460)

2025-06-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/143460 >From dd4953312066cb63ae1a3882270426c87b1f5b7a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Tue, 10 Jun 2025 02:47:51 +0300 Subject: [PATCH 1/5] [Clang] fix missing source location for ':' error in

[clang] [Clang] fix missing source location for errors in macro-expanded (PR #143460)

2025-06-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/143460 >From dd4953312066cb63ae1a3882270426c87b1f5b7a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Tue, 10 Jun 2025 02:47:51 +0300 Subject: [PATCH 1/4] [Clang] fix missing source location for ':' error in

[clang] [Clang] add fix-it hints for unknown attributes (PR #141305)

2025-06-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/141305 >From 77641f88c5047c990df649658b6bd5fba0d395cd Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sat, 31 May 2025 15:59:59 +0300 Subject: [PATCH 1/4] [Clang] add fix-it hints for unknown attributes ---

[clang] [Clang] fix missing source location for errors in macro-expanded (PR #143460)

2025-06-10 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/143460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-10 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/143460 >From dd4953312066cb63ae1a3882270426c87b1f5b7a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Tue, 10 Jun 2025 02:47:51 +0300 Subject: [PATCH 1/2] [Clang] fix missing source location for ':' error in

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-10 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/143460 >From dd4953312066cb63ae1a3882270426c87b1f5b7a Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Tue, 10 Jun 2025 02:47:51 +0300 Subject: [PATCH 1/2] [Clang] fix missing source location for ':' error in

  1   2   3   4   5   6   7   8   9   10   >