[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

2023-04-26 Thread Palmer Dabbelt via Phabricator via cfe-commits
palmer-dabbelt added a comment. IDK about the specifics here, but I think in general being more permissive on ISA string parsing is the way to go. The rules have changed so many times it's not really viable to follow them, so we're sort of just stuck with a bunch of historally-driven

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

2022-09-02 Thread Palmer Dabbelt via Phabricator via cfe-commits
palmer-dabbelt added a comment. I was talking to @reames about this. The spec has changed since I posted these patches: there's now two instructions (wrs.nto and wrs.sto) and there's no longer a register to encode the timeout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

2022-06-20 Thread Palmer Dabbelt via Phabricator via cfe-commits
palmer-dabbelt updated this revision to Diff 438515. palmer-dabbelt added a comment. Herald added a subscriber: jdoerfert. - Fix a whitespace issue - Fix the name of RISCVInstrInfoZawrs.td - Call the #define __riscv_zawrs instead of __riscv_wrs, to match the others - Add tests in

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

2022-06-20 Thread Palmer Dabbelt via Phabricator via cfe-commits
palmer-dabbelt added a comment. I've never touched LLVM before, so I have no idea if I'm even in the right place here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

2022-06-20 Thread Palmer Dabbelt via Phabricator via cfe-commits
palmer-dabbelt created this revision. palmer-dabbelt added reviewers: reames, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,