[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-06 Thread Patryk Wychowaniec via cfe-commits
Patryk27 wrote: > Rust normally uses a patched llvm and I am directly using this PR so that > could be the cause but I want to check that first. Yeah, I usually just cherry-pick my changes on top of Rust's fork of LLVM, to make sure I don't bring too many unrelated changes there 👀 https://g

[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
@@ -0,0 +1,56 @@ +//===- AVRTargetTransformInfo.h - AVR specific TTI -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 commented: It's a very nice catch! I think the code is good (modulo the comments already left by @benshi001) and it'd be nice to get this merged 🙂 https://github.com/llvm/llvm-project/pull/152028 ___ cfe-commits mailing li

[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
@@ -112,8 +112,8 @@ while.end:; preds = %while.body, %entry define void @store16predec(ptr %x, i16 %y) { ; CHECK-LABEL: store16predec: -; CHECK: st -{{[XYZ]}}, {{.*}} -; CHECK: st -{{[XYZ]}}, {{.*}} +; TODO: st -{{[XYZ]}}, {{.*}} --

[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 edited https://github.com/llvm/llvm-project/pull/152028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 edited https://github.com/llvm/llvm-project/pull/152028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Fix Avr indvar detection and strength reduction (missed optimization) (PR #152028)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
@@ -0,0 +1,56 @@ +//===- AVRTargetTransformInfo.h - AVR specific TTI -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-08-05 Thread Patryk Wychowaniec via cfe-commits
Patryk27 wrote: Sure, just wanted to note that LGTM, but feel free to leave it for another time. https://github.com/llvm/llvm-project/pull/146244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-08-04 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. https://github.com/llvm/llvm-project/pull/146244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-07-01 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 edited https://github.com/llvm/llvm-project/pull/146244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-07-01 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 edited https://github.com/llvm/llvm-project/pull/146244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-07-01 Thread Patryk Wychowaniec via cfe-commits
@@ -263,11 +263,17 @@ bool AVRAsmPrinter::doFinalization(Module &M) { auto *Section = cast(TLOF.SectionForGlobal(&GO, TM)); if (Section->getName().starts_with(".data")) NeedsCopyData = true; -else if (Section->getName().starts_with(".rodata") && SubTM->hasLPM(

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-07-01 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 edited https://github.com/llvm/llvm-project/pull/146244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-07-01 Thread Patryk Wychowaniec via cfe-commits
@@ -263,11 +263,17 @@ bool AVRAsmPrinter::doFinalization(Module &M) { auto *Section = cast(TLOF.SectionForGlobal(&GO, TM)); if (Section->getName().starts_with(".data")) NeedsCopyData = true; -else if (Section->getName().starts_with(".rodata") && SubTM->hasLPM(

[clang] [llvm] [AVR] Handle flash RO data mapped to data space for newer devices (PR #146244)

2025-07-01 Thread Patryk Wychowaniec via cfe-commits
@@ -263,11 +263,17 @@ bool AVRAsmPrinter::doFinalization(Module &M) { auto *Section = cast(TLOF.SectionForGlobal(&GO, TM)); if (Section->getName().starts_with(".data")) NeedsCopyData = true; -else if (Section->getName().starts_with(".rodata") && SubTM->hasLPM(

[clang] [llvm] [AVR] Add support for many new AVR mcus like AVR128DB28 (PR #143914)

2025-06-13 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. Looks good to me, cc @benshi001? https://github.com/llvm/llvm-project/pull/143914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. https://github.com/llvm/llvm-project/pull/136534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo (PR #131976)

2025-03-20 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. https://github.com/llvm/llvm-project/pull/131976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Emit warnings about incorrect AVR interrupt/signal handlers (PR #125997)

2025-02-06 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. https://github.com/llvm/llvm-project/pull/125997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Emit warnings on incorrect AVR interrupt/signal handlers (PR #125328)

2025-02-01 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. https://github.com/llvm/llvm-project/pull/125328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AVR] Fix basic type size/alignment values to match avr-gcc. (PR #111290)

2024-10-18 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. Looks good to me as well! https://github.com/llvm/llvm-project/pull/111290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits