[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa6e87cc5a21: [TableGen] [Clang] Clean up arm_mve.td file. (authored by Paul-C-Anagnostopoulos). Changed prior to commit:

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Sorry, I removed it but didn't update this review. All set now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Could I get an LGTM on this? I have removed the spurious comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:1532 // // So this foldl expression implements what you'd write in Python as // [srctype for srctype in T.All if srctype != desttype] simon_tatham wrote: > If

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos updated this revision to Diff 344810. Paul-C-Anagnostopoulos added a comment. One must amend the commit when one makes changes to the files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 Files:

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos updated this revision to Diff 344809. Paul-C-Anagnostopoulos added a comment. The arm_*.inc files do not change with this revision. I removed the commented-out code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); craig.topper wrote: > Did you intend to leave the old lines commented

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, jansvoboda11, craig.topper, dblaikie. Herald added subscribers: dmgreen, kristof.beyls. Paul-C-Anagnostopoulos requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd40a0b8af771: [TableGen] [Clang] Clean up Options.td and add asserts. (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos updated this revision to Diff 343100. Paul-C-Anagnostopoulos added a comment. Restored whitespace as requested by Jan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101766/new/ https://reviews.llvm.org/D101766 Files: clang/include/clang/Driver/Options.td

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Paul-C-Anagnostopoulos wrote: > > jansvoboda11 wrote: > > >

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Were you planning to refactor this too? You can't use the

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: jansvoboda11, dblaikie, craig.topper. Herald added a subscriber: dang. Paul-C-Anagnostopoulos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:191 +defvar suffix = s_p[1]; +defvar prototype = s_p[2]; + Well now, thanks for highlighting an inconsistency I did not know about. The

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:144 + // This builtin has a masked form. + bit HasMask = 1; + May I recommend that you use 'true' and 'false' for boolean literals. Comment

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92269: [TableGen] Eliminate the 'code' type

This revision was automatically updated to reflect the committed changes. Closed by commit rG415fab6f67b4: [TableGen] Eliminate the code type (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. I'm about to push this revision. I will be surprised if it does not break the build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos updated this revision to Diff 308711. Paul-C-Anagnostopoulos added a comment. Fixed some of the lint issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 Files: clang/utils/TableGen/ClangOptionDocEmitter.cpp

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. The TypeOf_xxx field is only used by the searchable tables backend. My trek through all the backends revealed it as the only one that needs to distinguish string and code, because it can emit the C++ initializer for any type of field. All the other

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. Yes, we could create !codeconcat instead, along with !codeinterleave, !codeeq, etc. We could also just extend the existing bang operators to work on the code type. I thought it was cleaner just to get rid of the distinction. I agree that !subst is a

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. The TypeOf_xxx feature of searchable tables already exists. I just co-opted it as the way to tell the searchable table backend to emit the code without quotes. If we go with this revision, we will always need it in certain cases, when the code is

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, madhur13490, asb. Herald added subscribers: llvm-commits, cfe-commits, teijeong, frasercrmck, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb,

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

Paul-C-Anagnostopoulos added a comment. I'll remember this, too. @dblaikie How did you happen to notice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___

[PATCH] D89814: [TableGen] Change !getop and !setop to !getdagop and !setdagop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876af264c118: [TableGen] Change !getop and !setop to !getdagop and !setdagop. (authored by Paul-C-Anagnostopoulos). Changed prior to commit:

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4b4543ff0c8: [Clang] [TableGen] Clean up !if(!eq(bool, 1) and related booleans (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, asl. Herald added subscribers: cfe-commits, dexonsmith, dmgreen. Herald added a project: clang. Paul-C-Anagnostopoulos requested review of this revision. This patch continues the cleanup of

[PATCH] D89814: [TableGen] Change !getop and !setop to !getdagop and !setdagop

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, rengolin, asl. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, dmgreen, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Paul-C-Anagnostopoulos requested review