[PATCH] D100968: Update shebang for clang-format-diff script to python3.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e80386d0fe: Update shebang for clang-format-diff script to python3. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

PaulkaToast added a comment. In D100968#2705598 , @MaskRay wrote: >> On newer Linux distributions > > Different distributions have different strategies migrating the > /usr/bin/python symlink. Debian and its derivatives provide python-is-python2 > and p

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

PaulkaToast created this revision. PaulkaToast added reviewers: MaskRay, DavidSpickett. PaulkaToast requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On newer Linux distributions that don't have python2, the clang-format-diff script and cons

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast updated this revision to Diff 260805. PaulkaToast marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:52-53 + + diag(FuncDecl->getLocation(), + "currently resolves to: ", clang::DiagnosticIDs::Note); +} aaron.ballman wrote: > PaulkaToast wrote: > >

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8683f5de5352: [clang-tidy] Add check callee-namespace. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.l

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:22-23 +const DeclContext *getOutermostNamespace(const DeclContext *Decl) { + if (Decl->isTranslationUnit()) +return Decl; + if (Decl->getParent() && Decl->getParent

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast updated this revision to Diff 260524. PaulkaToast marked 8 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast updated this revision to Diff 260218. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast created this revision. PaulkaToast added reviewers: aaron.ballman, njames93. PaulkaToast added projects: clang-tools-extra, libc-project. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This check will ensure that all calls to functions resolve

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00a57558978d: [clang-tidy] Add check llvmlibc-implementation-in-namespace. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/ImplementationInNamespaceCheck.cpp:21 + Finder->addMatcher( + decl(hasParent(translationUnitDecl()), unless(linkageSpecDecl())) + .bind("child_of_translation_unit"), -

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast updated this revision to Diff 255277. PaulkaToast marked 13 inline comments as done. PaulkaToast added a comment. Addressed njames's and aaron's comments. (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https://reviews.llvm.

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast updated this revision to Diff 254376. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https://reviews.llvm.org/D76818 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt clang-tools-extra/clang-tidy/llvmlibc/Implemen

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast added a comment. Friendly Ping @njames93 (: Any other changes needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https://reviews.llvm.org/D76818 ___ cfe-commits mailing list c

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast marked 3 inline comments as done. PaulkaToast added a comment. In D76818#1943781 , @njames93 wrote: > If you want to make it a general check, you should consider making the > default module options set the correct namespace > RequiredNamespace

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast updated this revision to Diff 253250. PaulkaToast added a comment. Updated to handle nested namespaces, exclude C linkages functions, and made check language specific. (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https:

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast marked 3 inline comments as done. PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/EntrypointNamespaceCheck.cpp:67 + if (Result.SourceManager->getFilename(MatchedDecl->getLocation()) + .endswith(".h")) +return; --

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast abandoned this revision. PaulkaToast added a comment. Abandoning for a more generalized check. D76818 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76744/new/ https://reviews.llvm.org/D76744 ___

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast created this revision. PaulkaToast added reviewers: alexfh, aaron.ballman, hokein, njames93. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. This check makes sure all llvm-libc implementat

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast created this revision. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76744 Files: clang-tools-extra/clang-tidy/llvmlib

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

PaulkaToast added a comment. This seems to be causing a failure in our buildbot , mind taking a look? (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76393/new/ https://reviews.llvm.org/D76393

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

This revision was automatically updated to reflect the committed changes. Closed by commit rG556b917fffcf: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers… (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast updated this revision to Diff 251713. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast updated this revision to Diff 251233. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt clang-tools-extra/clang-tidy/llvmlibc/Restrict

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

PaulkaToast created this revision. PaulkaToast added a reviewer: aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. Made llvmlibc::RestrictSystemLibcHeadersCheck a subclass of protability

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb41cc619866: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249802. PaulkaToast added a comment. Mocked the header files so that we don't experience failures due to differences in systems. Mind taking a quick look @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1736f7a2a66: [clang-tidy] Mock system headers for portability-restrict-system-includes tests. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D76015: [clang-tidy] Mock system headers for portability-restrict-system-includes tests.

PaulkaToast created this revision. PaulkaToast added reviewers: RKSimon, aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Didn't realize that headers such as stddef.h may not exist on all systems. This

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast added a comment. In D75786#1916714 , @aaron.ballman wrote: > In D75786#1916637 , @RKSimon wrote: > > > @PaulkaToast This patch appears to have caused a buildbot issue, please can > > you investigate/re

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249544. PaulkaToast added a comment. Addressed @Eugene.Zelenko comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMake

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:66-67 +const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + SmallString<128> CompilerIncudeDir = + StringRef(PP->getHeader

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249530. PaulkaToast marked 4 inline comments as done. PaulkaToast added a comment. Addressed @aaron.ballman comments (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D753

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

This revision was automatically updated to reflect the committed changes. PaulkaToast marked an inline comment as done. Closed by commit rGebdb98f254f6: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for… (authored by PaulkaToast). Changed prior to commit: https://rev

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast marked 2 inline comments as done. PaulkaToast added a comment. Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:48 + + A string containing a comma separated glob list of allowed include + filenames. Similar to the -

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast updated this revision to Diff 248900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75786/new/ https://reviews.llvm.org/D75786 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt clang-tools-extra/clang-tidy/fuchsia/FuchsiaTid

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast updated this revision to Diff 248882. PaulkaToast marked 5 inline comments as done. PaulkaToast added a comment. Thanks for the heads up phosek, I removed the check from fuchsia's directory. Also addressed Eurgene.Zelenko's comments. (: Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast created this revision. PaulkaToast added a reviewer: aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, phosek, xazax.hun, mgorny. Herald added a project: clang. Created a general check for restrict-system-includes under portability as

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248851. PaulkaToast added a comment. Thanks for the suggestions, the general check sounds like a great idea. I can see the use case for this as it can be used by anyone. I took the time to port out fuchsia's check and flesh out the user facing documentat

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248059. PaulkaToast marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-too

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added a comment. In D75332#1903570 , @MaskRay wrote: > > `RestrictSystemLibcHeadersCheck` > > As I commented previously, I think the checker name should be generalized, as > it does not need to be coupled with llvm-libc. Other projects may hav

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248044. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-too

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 247960. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-too

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added a comment. In D75332#1897487 , @njames93 wrote: > The test cases need fixing as they are causing the build to fail. Done. > Also would it be wise to add a .clang-tidy file to libc/ to enable this > module for that subdirectory? Yes,

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 247794. PaulkaToast marked 11 inline comments as done. Herald added subscribers: jfb, arphaman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-e

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast created this revision. PaulkaToast added a reviewer: sivachandra. PaulkaToast added projects: clang-tools-extra, libc-project. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. This adds a new module to enforce standards specific to the l