[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

2017-10-26 Thread Phil Camp via Phabricator via cfe-commits
FlameTop added a comment. Hello, I'm afraid this commit is failing on Windows. http://lab.llvm.org:8011/console?builder=llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast&builder=llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast FAIL: Clang-Unit :: Tooling/./ToolingTests.exe/StandaloneToolTest.SimpleAct

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

2018-12-21 Thread Phil Camp via Phabricator via cfe-commits
FlameTop added a comment. I'm afraid we are seeing a build failure here on our local Windows checking MSVC build. Unfortunately I cannot find a public buildbot that uses the exact configuration that causes the assertion. The assertion we are seeing is Assertion failed: isa(Val) && "cast() argum

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

2017-06-08 Thread Phil Camp via Phabricator via cfe-commits
FlameTop added inline comments. Comment at: test/clang-tidy/misc-noexcept-move-constructor.cpp:2 +// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -std=c++11 \ +// RUN: | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \ +// RUN: -implicit-check-not="{{warnin

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

2016-12-20 Thread Phil Camp via Phabricator via cfe-commits
FlameTop abandoned this revision. FlameTop added a comment. I must apologise to you all. The problem was reported in our out-of-tree version of the compiler and I must have hit finger problems when I confirmed it in tree. Repeating the test I can no longer reproduce the fault with the 3.9.0 pub

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

2016-12-05 Thread Phil Camp via Phabricator via cfe-commits
FlameTop created this revision. FlameTop added a reviewer: rsmith. FlameTop added a subscriber: cfe-commits. The provided test shows a case where enabling coverage instrumentation causes a link error during building. Normally the all the base class items (vtable, ctors and dtors) would be remove

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

2021-06-21 Thread Phil Camp via Phabricator via cfe-commits
FlameTop added a comment. This commit is failing the test on non-arm targets (e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/5932). I think the test needs a 'requires' line for aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10370