[clang] [clang-format] Correctly annotate token-pasted function decl names (PR #142337)

2025-06-02 Thread Pierre Jolivet via cfe-commits
prj- wrote: Unfortunately, we have many other use-cases for triggering regressions in our code (hence we are having this discussion in the first place 😅). https://github.com/llvm/llvm-project/pull/142337 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang-format] Correctly annotate token-pasted function decl names (PR #142337)

2025-06-02 Thread Pierre Jolivet via cfe-commits
prj- wrote: Looking forward to testing this out! https://github.com/llvm/llvm-project/pull/142337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle token-pasted function decl names (PR #142251)

2025-06-01 Thread Pierre Jolivet via cfe-commits
prj- wrote: @owenca, this introduced multiple regressions (or maybe they are all the same), I do believe. ```diff diff --git a/include/petsc/private/hashmap.h b/include/petsc/private/hashmap.h index c48d69d73ce..265a968a95c 100644 --- a/include/petsc/private/hashmap.h +++ b/include/petsc/private

[clang] [clang-format] Fix a bug in annotating binary operator && (PR #138633)

2025-05-10 Thread Pierre Jolivet via cfe-commits
prj- wrote: Done, cf. https://github.com/llvm/llvm-project/issues/139376. https://github.com/llvm/llvm-project/pull/138633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating binary operator && (PR #138633)

2025-05-09 Thread Pierre Jolivet via cfe-commits
prj- wrote: @owenca, I actually think that this introduced a regression that was previously fixed in the nightly snapshot of `clang-format-21`. With `clang-format-20`: ``` $ cat foo.cpp template using invoke_result_t = typename std::result_of::type; $ clang-format-20 foo.cpp template using inv

[clang] [clang-format] Correctly annotate braces in macro definition (PR #107352)

2024-09-05 Thread Pierre Jolivet via cfe-commits
prj- wrote: Could you please back-port this to `llvm:release/19.x` while reverting the previous fix? https://github.com/llvm/llvm-project/pull/107352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang-format] Fix a bug in annotating CastRParen (PR #102261)

2024-08-28 Thread Pierre Jolivet via cfe-commits
prj- wrote: What's your version? ``` $ clang-format-20 gh.txt void a() { double b = ((double)c(0)) * d / (double)0; } ``` https://github.com/llvm/llvm-project/pull/102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang-format] Fix a bug in annotating CastRParen (PR #102261)

2024-08-09 Thread Pierre Jolivet via cfe-commits
prj- wrote: Nevermind, this bug (not sure if it's a bug or not) is already present in clang-format 18. See https://github.com/llvm/llvm-project/issues/102727. https://github.com/llvm/llvm-project/pull/102261 ___ cfe-commits mailing list cfe-commits@li

[clang] [clang-format] Fix a bug in annotating CastRParen (PR #102261)

2024-08-09 Thread Pierre Jolivet via cfe-commits
prj- wrote: This introduced a regression though. ```diff - for (i = 0, k = 1; i < ((PetscInt)local_n0) * partial_dim; i++, k++) { + for (i = 0, k = 1; i < ((PetscInt)local_n0)*partial_dim; i++, k++) { ``` https://github.com/llvm/llvm-project/pull/102261

[clang] [clang-format] Fix a bug in annotating CastRParen (PR #102261)

2024-08-07 Thread Pierre Jolivet via cfe-commits
prj- wrote: Thank you very much. https://github.com/llvm/llvm-project/pull/102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating CastRParen (PR #102261)

2024-08-07 Thread Pierre Jolivet via cfe-commits
prj- wrote: I'm sorry I'm not familiar with LLVM release cycle, but is it too late for this to make it into the `release/19.x` branch? https://github.com/llvm/llvm-project/pull/102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang-format] Don't remove parentheses in macro definitions (PR #81444)

2024-02-11 Thread Pierre Jolivet via cfe-commits
prj- wrote: Any hope that this lands in 18.1? Thanks anyway! https://github.com/llvm/llvm-project/pull/81444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

2024-02-03 Thread Pierre Jolivet via cfe-commits
prj- wrote: @owenca, @HazardyKnusperkeks, I'm sorry I'm not very familiar with LLVM release cycle, but couldn't this be back-ported for version 18.1.0rc2? https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-26 Thread Pierre Jolivet via cfe-commits
prj- wrote: Pinging @owenca. https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits