[PATCH] D159528: [clang] Fix null dereference on return in lambda attribute statement expr

2023-09-18 Thread Piotr Fusik via Phabricator via cfe-commits
pfusik abandoned this revision. pfusik added a comment. Moved to https://github.com/llvm/llvm-project/pull/66643 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159528/new/ https://reviews.llvm.org/D159528

[PATCH] D159528: [clang] Fix null dereference on return in lambda attribute statement expr

2023-09-18 Thread Piotr Fusik via Phabricator via cfe-commits
pfusik created this revision. Herald added a project: All. pfusik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/48527 Repository: rG LLVM Github Monorepo

[PATCH] D142007: [NFC] Fix "form/from" typos

2023-01-22 Thread Piotr Fusik via Phabricator via cfe-commits
pfusik added a comment. In D142007#4072036 , @Mordante wrote: > Can you provide your name and email address to we can attribute the patch to > you? Piotr Fusik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142007: [NFC] Fix "form/from" typos

2023-01-22 Thread Piotr Fusik via Phabricator via cfe-commits
pfusik added a comment. @ldionne Can you check it in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142007/new/ https://reviews.llvm.org/D142007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142007: [NFC] Fix "form/from" typos

2023-01-18 Thread Piotr Fusik via Phabricator via cfe-commits
pfusik added a comment. In D142007#4062211 , @ldionne wrote: > LGTM, thanks! I don't think you need to wait for other owners to approve > before landing this, this is pretty clearly an improvement. I have no commit access, could you please commit this

[PATCH] D142007: [NFC] Fix "form/from" typos

2023-01-18 Thread Piotr Fusik via Phabricator via cfe-commits
pfusik created this revision. Herald added subscribers: Moerafaat, zero9178, steakhal, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik accepted this revision. PiotrFusik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commits mailing list

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-04 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik requested changes to this revision. PiotrFusik added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-01 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik added a comment. These specification for these extensions was edited by Ben Ashbaugh @Intel. I've asked him about this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

2020-06-04 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik marked 2 inline comments as done. PiotrFusik added inline comments. Comment at: clang/lib/Headers/opencl-c.h:15594 +int __ovld sub_group_elect(void); +int __ovld sub_group_non_uniform_all( int predicate ); +int __ovld sub_group_non_uniform_any( int

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

2020-06-03 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik marked 2 inline comments as done. PiotrFusik added a comment. > Great! Thanks! Feel free to go ahead and commit this! Thanks. Can someone commit this for me please? Also to 10.0 if possible? > Can you please add a link to the bug describing incorrect optimization to > this review