[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

plotfi added a comment. LGTM but waiting on Akira would be nice imho. Comment at: clang/lib/CodeGen/CGObjC.cpp:1192 // corresponding gcc code. -llvm::Value *cmd = - Builder.CreateLoad(GetAddrOfLocalVar(getterMethod->getCmdDecl()), "cmd"); +if (getterMethod->is

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

plotfi added a comment. @ahatanak how does this diff look to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135091/new/ https://reviews.llvm.org/D135091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3821183 , @plotfi wrote: > In D86049#3819109 , @mwyman wrote: > >> In D86049#3818981 , @plotfi wrote: >> >>> @ahatanak I can revive some of

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3819109 , @mwyman wrote: > In D86049#3818981 , @plotfi wrote: > >> @ahatanak I can revive some of what I was working on from >> https://reviews.llvm.org/D86049?id=285923 if we thin

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @ahatanak I can revive some of what I was working on from https://reviews.llvm.org/D86049?id=285923 if we think we need a thunk for the checks as @rjmccall mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a subscriber: kyulee1. plotfi added a comment. In D86049#3818923 , @ahatanak wrote: > In D86049#3818696 , @plotfi wrote: > >> In D86049#3818435 , @mwyman wrote:

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/lib/AST/Mangle.cpp:371 + OS << (MD->isInstanceMethod() ? '-' : '+'); + OS << (MD->hasMethodVisibilityDefault() ? '<' : '['); if (const auto *CID = MD->getCategory()) { ahatanak wrote: > Sorry, I might have miss

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3818435 , @mwyman wrote: > In D86049#3816006 , @plotfi wrote: > >> @dmaclach @ahatanak @mwyman How do things look from here? Do you want >> something for properties as well or woul

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 463064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/C

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @dmaclach @ahatanak @mwyman How do things look from here? Do you want something for properties as well or would it be ok if we did this in a later commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://rev

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 462999. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cpp clang/lib/AST/Mangle.cpp clang/lib/Cod

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 462944. plotfi added a comment. Updated based on @ahatanak's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clan

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3814111 , @ahatanak wrote: > In D86049#3812412 , @plotfi wrote: > >> In D86049#3812068 , @ahatanak wrote: >> >>> In D86049#3806898

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpts = [ObjC]; + let Documentation = [ObjCD

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3812068 , @ahatanak wrote: > In D86049#3806898 , @plotfi wrote: > >> 1. Do we change the existing visibility behavior of objc methods? Yes / No > > I don't think we want to change t

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3812068 , @ahatanak wrote: > In D86049#3806898 , @plotfi wrote: > >> 1. Do we change the existing visibility behavior of objc methods? Yes / No > > I don't think we want to change t

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @ahatanak @rjmccall I think the decision tree goes 1. Do we change the existing visibility behavior of objc methods? Yes / No 2. If we leave hidden as the default do we change the behavior for objc_direct? Yes / No 3. If we leave objc_direct as hidden by default do we

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a subscriber: ahatanak. plotfi added a comment. @ahatanak @mwyman @rjmccall @dmaclach I am going to work on a version of this patch where the visibility can be encoded into the objc_direct attribute. Does that seem reasonable to do from here? Repository: rG LLVM Github Monorepo

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. In D131424#3803190 , @mwyman wrote: > Hi Akira, > > I'd reached out to John offline and he'd mentioned you might be able to help > on some of these objc_direct reviews; if so, that would be wonderful! > > -Michael I would also be

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpt

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:35 + +@interface C +- (void)testMethod:(int)arg1 bar:(float)arg2 OBJC_DIRECT; dmaclach wrote: > I'd like to see a test for the protocol

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459268. plotfi added a comment. Adding a test case to cover @protocol methods not being allowed to contain direct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files:

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459267. plotfi added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:30 +#if ENABLE_VISIBLE_OBJC_DIRECT +#define OBJC_DIRECT __attribute((objc_direct)) __attribute__((objc_direct_visible)) +#else dmaclach wrote: > This is the case that mwyman d

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459261. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDoc

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpt

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459260. plotfi added a comment. Updated to use mangleObjCMethodName in clang/lib/AST/Mangle.cpp to set the `_+` direct method name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpts = [ObjC]; + let Documentation = [ObjCD

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 459257. plotfi added a comment. Updated with some of @mwyman's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h cl

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. Updated D86049 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commi

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 451041. plotfi added a comment. Herald added a reviewer: aaron.ballman. Updating implementation to use an objc_direct_visible attr to explicitly mark when we want objc_direct to be exposed outside of the link unit. Work on dropping the selector param has been

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:487 SmallVector argTys; SmallVector extParamInfos(2); argTys.push_back(Context.getCanonicalParamType(receiverType)); In order to fix the assert try this instead on line 487: ``` Sm

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. I tried running the following on some example code and got a stacktrace: // RUN: clang -cc1 -no-opaque-pointers -emit-llvm -fobjc-arc -triple x86_64-apple-darwin10 -o - %s -O0 @interface C - (int)getInt __attribute__((objc_direct)); @end @implementation C

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3663726 , @mwyman wrote: > Hi, I work with @dmaclach. I know this has been sitting around without much > activity for two years, but we believe there is a solid use-case for this on > our end and I'd like to help get the

[PATCH] D128249: Adding clone_attrs attribute.

plotfi added a comment. Thanks for the feedback on corner cases @aaron.ballman, this will give me more concrete things to think about here. At the moment I mainly thinking about a case: typedef int foo; enum : foo {} __attribute__((__clone_attrs_from__(foo))); This is mostly because of how

[PATCH] D128249: Adding clone_attrs attribute.

plotfi added a comment. This is pretty incomplete. Please ignore for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128249/new/ https://reviews.llvm.org/D128249 ___ cfe-commits mailing list cfe-commi

[PATCH] D128249: Adding clone_attrs attribute.

plotfi created this revision. plotfi added a reviewer: arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. plotfi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just experimental for the time being. Posti

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

plotfi added subscribers: rjmccall, plotfi. plotfi added a comment. @rjmccall would you be able to review this patch? What do you think of this approach? This change is to support C++-Interop on the Swift side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#2844766 , @dmaclach wrote: > Has anything happened with this at all or did it get dropped? I can work with you and @rjmccall to land a version of this. We can chat offline if you'd like too. Repository: rG LLVM Githu

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

plotfi added a comment. @jkorous thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

plotfi accepted this revision. plotfi added a comment. This revision is now accepted and ready to land. This makes sense to me. I approve. Can we move the 3/60 seconds number to a const int value set somewhere higher up in the file as a global with a comment explaining this as well? Repository

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

plotfi added a comment. Herald added a subscriber: wenlei. @vsk any update on this? Is there anything we can do to help in landing this patch in llvm-project/main? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

plotfi added a comment. Overall looks good. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:95 + CreateEvent(NULL, /*bManualReset=*/TRUE, /*bInitialState=*/FALSE, NULL); + assert(ovlIO.hEvent); + Can this be an assert with some

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#2253705 , @plotfi wrote: > I've updated the diff to reflect the alternate non-wrapper exposure. This way > requires the sanitizing of the exported objc_direct method name. @rjmccall Is there a process for discussing ABI

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 289616. plotfi added a comment. I've updated the diff to reflect the alternate non-wrapper exposure. This way requires the sanitizing of the exported objc_direct method name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. @YangZhihui landed at https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846 Thanks! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427 _

[PATCH] D86427: Fix some spelling errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22d27624b65: [NFC] Fix some spelling errors in clang Driver Options.td (authored by YangZhihui, committed by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. In D86427#2235630 , @YangZhihui wrote: > how can I add the Author property in the patch > Thanks Is your email `yangzh.f...@cn.fujitsu.com` associated with a github account? If it is, this is all I need. Repository: rG LLVM G

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. In D86427#2235574 , @YangZhihui wrote: > Thanks, but I don't have commit access I can commit it for you. Can you give me your github email? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D86427: Fix some spelling errors

plotfi accepted this revision. plotfi added a comment. This revision is now accepted and ready to land. LGTM. Go ahead and land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427 __

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @lanza I did it as a CodeGen option for now because we don't want anything like this to be the default until the ABI is fleshed out. I think one danger in altering the name of the function to some extent is you dont want to clash potentially with user defined C functions.

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#2225202 , @rjmccall wrote: > I think that, if we want to do this, we need to think carefully about what > exactly we want the ABI to be. I agree with this very much. Open to suggestions and ideas. Already started notici

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 286141. plotfi added a comment. change for clang-tidy and clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 285925. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen/C

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi created this revision. plotfi added reviewers: rjmccall, manmanren, MadCoder. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. plotfi requested review of this revision. Hi @rjmccall @MadCoder I'd like to preface this diff: I mostly want to discuss the prospects o

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

plotfi added a comment. In D57265#2205797 , @rjf wrote: > Would also really like to see this patch landed. Also, as of today > (8/10/2020), the patch cannot be cleanly applied into trunk without inducing > merge conflicts anymore. You might have some lu

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi updated this revision to Diff 278064. plotfi added a comment. Update for harbormaster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clan

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi added a subscriber: dexonsmith. plotfi added a comment. In D79730#2030530 , @rjmccall wrote: > I think it makes sense; if nothing else, we're trying to upstream all that > work. @rjmccall Should I still try to land this or should this stuff get p

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

plotfi added a comment. @pratlucas @ostannard @rjmccall I've posted a diff D82443 to address what I think could be a potential fix for the assert I was seeing on the provided reduced IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

plotfi added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:4106 +unsigned NumParts, MVT PartVT, Optional CC) const { + bool IsABIRegCopy = CC.hasValue(); + EVT ValueVT = Val.getValueType(); I'm not well versed in arm CCs, but I suspec

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

plotfi added a comment. @pratlucas @ostannard @rjmccall I have noticed this change break on the building of the Swift standard library in downstream apple/swift/master-next. I reduced the test case and found that the chain of bitcasts/extends in ARMTargetLowering::splitValueIntoRegisterParts e

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

plotfi added a comment. In D74166#2107831 , @plotfi wrote: > @rjmccall > > FYI this diff appears to be breaking a ptrauth test on > apple/swift/master-next > (clang/test/CodeGenCXX/ptrauth-static-destructors.cpp). > > Investigating this further. Looks

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

plotfi added subscribers: rjmccall, plotfi. plotfi added a comment. @rjmccall FYI this diff appears to be breaking a ptrauth test on apple/swift/master-next (clang/test/CodeGenCXX/ptrauth-static-destructors.cpp). Investigating this further. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a subscriber: echristo. plotfi added a comment. @pratlucas please reland once the bugzilla issue is resolved and the testsuite builds for aarch64. Thanks @echristo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://revie

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. Reduced crash case even further: void f() { signed char d[16]; __builtin_neon_vld1q_v(d, 32); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. After reducing the test case it looks the same as the bugzilla filing, running `clang --target=aarch64-unknown-linux-gnu -c` on the following does it: typedef signed char int8_t; typedef __attribute__((neon_vector_type(16))) int8_t int8x16_t; typedef struct int8x16x

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. @efriedma I am also seeing a similar crash in the llvm-test-suite for llvm-test-suite/SingleSource/UnitTests/Vector/NEON/simple.c I will try and reduce the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ htt

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. @rjmccall @mibintc I think the diagnostics-order.c test is still behaving correctly technically. The note lines are still printing with the associated error lines, it just happens that one of the warning lines prints at the end instead of in the middle. ie: error: inv

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. That was a good fix. I am pretty sure this does mean the diagnostics-order.c will fail on apple's bots. The same diagnostics lines print, but in the wrong order. I haven't root caused that yet. In D72841#2030099 , @mibintc wrote:

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi added a comment. In D79730#2030037 , @rjmccall wrote: > I don't think the reversion is necessary; it's being fixed to remove the > dependency. This is a good change, though. Should I still try to land this diff so that it matches the behavior on

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

plotfi added a comment. @mibintc Nice solution. I think this would work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79735/new/ https://reviews.llvm.org/D79735 ___ cfe-commits mailing list cfe-commit

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a subscriber: ab. plotfi added a comment. @ab @rjmccall @mibintc Posted D79730 for consideration. @mibintc can you produce a version of _this_ diff that works with D79730 applied. Currently the following fail, as t

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi created this revision. plotfi added reviewers: rjmccall, ab. Herald added a project: clang. Herald added a subscriber: cfe-commits. After speaking with @ab and @rjmccall on https://reviews.llvm.org/D72841#2027740 and https://github.com/apple/llvm-project/pull/1202. it sounds like code-ge

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. @rjmccall @mibintc Can we revert this patch for now then, and re-land when this patch is reworked? It would be good to get those bots passing. @rjmccall are the bots that you see failing on your end public? In D72841#2028834 , @rj

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. Hi @rjmccall, I am also seeing similar failures. It is failing on apple's master (and the swift branches as well) because ParseLangArgs and ParseCodeGenArgs are getting called in the opposite order in apple/master from the order they are called in llvm/master. I posted a

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa044ed088a: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. In D77233#1997294 , @erik.pilkington wrote: > LGTM, again :) Thanks for cleaning this up. Thank you Erik! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. @erik.pilkington @arphaman ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. In D77233#1977671 , @erik.pilkington wrote: > LGTM (after fixing those tests). Thanks for cleaning this up! Can this be a LGTM again @erik.pilkington @arphaman? I have managed to undo any unintended C API changes. Tests appear

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 257577. plotfi added a comment. Update for clang-format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h clang/incl

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 257550. plotfi added a comment. Adding a kind_ prefix to avoid any keywords being used in the ObjCPropertyAttribute enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:915 HANDLE_DW_APPLE_PROPERTY(0x2000, null_resettable) HANDLE_DW_APPLE_PROPERTY(0x4000, class) I have some concerns here too. How would

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 257431. plotfi added a comment. Removing unintended change to Clang C API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h c

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind;

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 257207. plotfi added a comment. adding fixes for class -> classattr change for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang-c/Index

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind;

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind; @erik.pilkington Do you think w

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 256931. plotfi added a comment. Move ObjCPropertyAttributeKind to namespace ObjCPropertyAttribute { enum Kind { ... }} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 F

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, eri

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, plo

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, com

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 254297. plotfi added a comment. Applying clang-format suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h clang/in

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 254259. plotfi added a comment. Herald added a subscriber: jfb.  Clipboard gave me junk the first submit. Sorry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files:

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi created this revision. plotfi added reviewers: compnerd, manmanren. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. plotfi edited the summary of this revision. plotfi updated this revision to Diff 254259. plotfi added a comment. Herald added a subscriber: jfb.

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe3033c0ce551: [llvm][clang][IFS] Enhancing the llvm-ifs yaml format for symbol lists. (authored by plotfi). Repository:

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 254080. plotfi added a comment. Trying to fix precommit / clang tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/include/clang/Frontend/Fronte

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 254075. plotfi added a comment. Updating to change im about to land, to see what precommit changes show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/i

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253367. plotfi added a comment. fixing linter errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Front

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

plotfi updated this revision to Diff 253369. plotfi added a comment. Adding a better test to check the deprecated v1 format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76979/new/ https://reviews.llvm.org/D76979 Files: clang/lib/Frontend/Compi

  1   2   3   4   >