[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added a comment. In D116283#3218118 , @HazardyKnusperkeks wrote: > Thanks for adding the parse checks. Not an issue :) In D116283#3218101 , @curdeius wrote: > LGTM. > If you need help landing this

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai updated this revision to Diff 397112. rajatbajpai added a comment. Incorporated review comments. Updated release note and example scenario. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 Fil

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added a comment. In D116283#3216235 , @MyDeveloperDay wrote: > LGTM, could you add a release note into docs/ReleaseNotes.rst? Sure, will do. Comment at: clang/docs/ClangFormatStyleOptions.rst:3760 + true:

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai updated this revision to Diff 396922. rajatbajpai added a comment. Incorporated review comments. 1. Added Check Parse test case for //SpaceBeforeParensOptions//. 2. Renamed the option to //AfterOverloadedOperator//. 3. Added operator overloading instantiation scenario in the unit test

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); HazardyKnusperkeks wrote: > rajatbajpai w

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); MyDeveloperDay wrote: > There should be a

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added a comment. In D116283#3211590 , @HazardyKnusperkeks wrote: > Does it affect calling code? `a.operator++(5);` Should it? But please add > tests for that. Yes, it does affect the calling code as well. However, I am not sure if we shoul

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

rajatbajpai updated this revision to Diff 396314. rajatbajpai added a comment. Fixed the patch file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 Files: clang/docs/ClangFormatStyleOptions.rst clang

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

rajatbajpai updated this revision to Diff 396302. rajatbajpai added a comment. Incorporated review comments. Changelog: 1. Using unit test case instead of lit test case. 2. Placed the option according to alphabetical order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

rajatbajpai created this revision. rajatbajpai added a reviewer: MyDeveloperDay. rajatbajpai added a project: clang-format. rajatbajpai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds an option AfterOperatorOverloading in S