[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

tambre added a comment. I've now run into a snag with this. Having `clang++.cfg` with `-std=c++2b` makes `/usr/bin/clang++ -E -dM -` fail with `error: invalid argument '-std=c++2b' not allowed with 'C'`. This is invoked by Meson during its configuration process and causes it to fail. Am I doing

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

tambre added a comment. A Clang 16 release note for this would be nice. I didn't immediately notice and got a bit broken by this change. 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133375/new/ https://reviews.llvm.org/D133375

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

tambre added a comment. In D129362#3638896 , @aaron.ballman wrote: > In D129362#3638485 , @tambre wrote: > >> Makes sense to me, thanks! > > Thanks! Would you mind handling the libc++ side like last time, or do y

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

tambre accepted this revision. tambre added a comment. This revision is now accepted and ready to land. Makes sense to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129362/new/ https://reviews.llvm.org/D129362 _

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

tambre added a comment. In D127379#3581009 , @tschuett wrote: > Do you believe an entry in the ReleaseNotes would get this achievement more > visibility? I second that this would be worthy of a release note. Seems like quite a big improvement. I wonde

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

tambre added inline comments. Comment at: clang/docs/ReleaseNotes.rst:95-96 +- The builtin function __builtin_dump_struct would crash clang when the target + struct have bitfield. Now it fixed, and __builtin_dump_struct support dump + the bitwidth of bitfields. + This fixes `

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195955 , @ldionne wrote: > @tambre Any appetite for a libc++ patch? :) > > Otherwise, let me know and I'll put it in my list of things to fix up. Sure, I can take it up during the weekend. CHANGES SINCE LAST ACTION

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195506 , @ldionne wrote: > Sorry, I seemed to have missed this entirely. > > Since this is touching only `` and not libc++'s ``, I > think it would actually be OK not to make any changes at all inside libc++. > Nothin

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb5aef90d4656: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964) (authored by ricejasonf, committed by tambre). R

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. In D108482#3108013 , @ricejasonf wrote: > In D108482#3105889 , @tambre wrote: > >> I presume you lack the permissions to push this to the main repo yourself. >> Would you like me to do th

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. I presume you lack the permissions to push this to the main repo yourself. Would you like me to do that for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 __

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. In D103395#3105668 , @sepavloff wrote: > Strange, I see that it cannot be compiled neither by gcc nor by clang: > https://godbolt.org/z/1dY9Gs6zM. Do I miss something? Sorry, should've been more specific. Try in C++20 mode: http

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. This breaks the following code: struct sub { char data; }; struct main { constexpr main() { member = {}; } sub member; }; constexpr main a{}; With: fmt.cpp:16:16: error: constexpr variable '

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added inline comments. Comment at: clang/test/CodeGenCXX/pr45964-decomp-transform.cpp:1 +// RUN: %clang_cc1 -std=c++1z -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s + I'd prefer `-std=c++17` since the standard and flag have been finalized.

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. In D108482#3041127 , @ricejasonf wrote: > I rebased onto `main` and made one small style fix. I don't think the rebase > changes anything. > > I do not understand why random things are failing in the CI. Even on my own > build m

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#3038277 , @ychen wrote: > In D77491#3038204 , @tambre wrote: > >> Abandoning since I don't think there's any further review/actions to be done >> here. >> D58531

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre abandoned this revision. tambre added a comment. Abandoning since I don't think there's any further review/actions to be done here. D58531 would be the solution for the raised `pthread_create()` issue. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

tambre added a comment. Thank you for your quick turnaround. I can confirm that this works for me on Debian Unstable with my vendored LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110596/new/ https://reviews.llvm.org/D110596 ___

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tambre added a comment. In D108247#3025238 , @tra wrote: > So, what's the current state of affairs regarding CUDA SDK layout in debian? `/usr/bin`: most executables , `nvcc` and `

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tambre added a comment. This unfortunately breaks using Debian distribution CUDA. The Debian/Ubuntu special case

[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

tambre requested changes to this revision. tambre added a comment. This revision now requires changes to proceed. Please: - Add a test case based on the one in the bug. Hopefully you'll be able to reduce it further now that you understand the bug. - Use imperative style for the commit message, i

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2870291 , @jdoerfert wrote: > First: > Do I assume right this this feature was simply disabled without any plan to: > > - inform the authors (me) > - update the documentation > - re-enable support eventually or provide alt

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

tambre added inline comments. Comment at: clang/test/SemaCXX/cxx2a-lambda-decltype-this.cpp:1-4 +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -emit-llvm-only %s +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -fdelayed-template-parsing %s +// RUN: %clang_cc1 -std=c

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added a comment. Summary also looks good. 👍 You probably don't need to wait for more approvals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new/ https://reviews.llvm.org/D100046 ___ cfe-c

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre accepted this revision. tambre added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Probably worth mentioning what I had in my comment in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:10953-10967 if (unsigned BuiltinID = NewFD->getBuiltinID()) { ASTContext::GetBuiltinTypeError Error; LookupNecessaryTypesForBuiltin(S, BuiltinID); QualType T = Context.GetBuiltinType(B

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added a comment. In D100046#2674311 , @sdesmalen wrote: > The fact that Clang chooses to (explicitly) forget about a builtin in > SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't > fully understand how the builtin mechani

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://review

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list cfe-co

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre updated this revision to Diff 315847. tambre added a comment. Don't modify third-party checked-in libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 Files: clang/CMakeLists.txt compiler-r

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added inline comments. Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - ldionne wrote: > I don't think we want to change this. It's a third-party project (which is > inconvenientl

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre added a reviewer: ldionne. tambre added a comment. ldionne: for libc++ review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, lebedev.ri,

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2421249 , @aaronpuchert wrote: > In D86308#2421237 , @tambre wrote: > >> This has already been backported to 11.0.1: >> https://github.com/llvm/llvm-project/commit/03565ffd5da8370

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2421228 , @aaronpuchert wrote: > @tstellar, can we have this in 11.0.1? I've already ported it back in > openSUSE because we were having problems with the CMake 3.19 update. This has already been backported to 11.0.1:

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

tambre added a comment. I echo @tra's concerns. Having an option for a vendor to append/prepend a toolkit search location seems useful, but currently this seems more like a workaround for an explicit CUDA toolkit path not being passed to the testsuite. Shortcomings in the testrunner don't seem l

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

tambre added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88518/new/ https://reviews.llvm.org/D88518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2299938 , @rsmith wrote: > We've hit a fairly subtle miscompile caused by this patch. > > glibc's setjmp.h looks like this (irrelevant parts removed): > > struct __jmp_buf_tag { /*...*/ }; > extern int __sigsetjmp(stru

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

tambre added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:924 +void Sema::LookupNecessaryTypesForBuiltin(Scope *S, unsigned ID) { + if (getLangOpts().ObjC && ID == Builtin::BIobjc_msgSendSuper) +LookupPredefedObjCSuperType(*this, S); rjmccall w

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

This revision was automatically updated to reflect the committed changes. tambre marked an inline comment as done. Closed by commit rGf91f28c350df: [Sema] Split special builtin type lookups into a separate function (authored by tambre). Changed prior to commit: https://reviews.llvm.org/D87983?v

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

tambre created this revision. tambre added reviewers: rsmith, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre requested review of this revision. In case further such cases appear in the future we've got a generic function to add them to. Additionally change

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9674 ASTContext::GetBuiltinTypeError Error; +LookupPredefedObjCSuperType(*this, S, NewFD->getIdentifier()); QualType BuiltinType = Context.GetBuiltinType(BuiltinID, Error);

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa1aa330b202f: [Sema] Handle objc_super special lookup when checking builtin compatibility (authored by tambre). Repositor

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre added a comment. I'll go ahead and commit this, as it's affecting an user and the fix is simple and obvious. Hopefully post-commit review is acceptable per my understanding of the rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87917/n

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2282219 , @tambre wrote: > In D77491#2282166 , @dmajor wrote: > >> This commit broke Firefox builds on Mac with an error in the SDK headers. >> Could you please revert if a fix is

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre requested review of this revision. objc_super is special and needs LookupPredefedObjCSuperType() called before performing builtin type comparisons. This fix

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2282166 , @dmajor wrote: > This commit broke Firefox builds on Mac with an error in the SDK headers. > Could you please revert if a fix is not readily available? > > Reproducer: > > struct objc_super {}; > extern "C"

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe09107ab80dc: [Sema] Introduce BuiltinAttr, per-declaration builti

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. If there are no further comments I'll commit this in a few days. Comment at: clang/lib/Sema/SemaDecl.cpp:2088 + + if (Error || R.isNull()) +return nullptr; aaron.ballman wrote: > Should we do this check *before* we create the C link

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 291778. tambre marked 2 inline comments as done. tambre added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include/clang/B

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

tambre abandoned this revision. tambre added a comment. In D86877#2262448 , @phosek wrote: > It's not clear why couldn't we support per-target runtime directory? It uses > the standard multiarch layout, so in you'd end up using a directory like > `[path/

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86bd8f82cc74: [CMake] Remove dead FindPythonInterp code (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

tambre added a comment. phosek: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. Thanks for the review. All tests still pass, should be good for another round. Comment at: clang/lib/Sema/SemaDecl.cpp:9672-9673 + if (unsigned BuiltinID = II->getBuiltinID()) { +const auto *LinkageDecl = +dyn_cast(NewFD->getDecl

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 290232. tambre marked an inline comment as done. tambre added a comment. Remove now obsolete FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/includ

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 290229. tambre marked 3 inline comments as done. tambre added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include/

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

tambre created this revision. tambre added reviewers: compnerd, phosek. Herald added subscribers: llvm-commits, libcxx-commits, Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers, libc++, LLVM. Herald added a reviewer: libc++. tambre requested review of this revision. LLVM

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2254967 , @rjmccall wrote: > I didn't see the specific example, sorry. I agree that my description is > more applicable to builtins in the `__builtin` namespace, which describes > most of the builtins with custom typech

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 289986. tambre added a comment. Improve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2254065 , @rjmccall wrote: > The builtins with custom type-checking are all true intrinsics like > `__builtin_operator_new` and so on. They really can't be validly declared by > the user program. The thing that seems m

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. Thanks for the review! I believe I've managed to address your comments. In D77491#2248454 , @rsmith wrote: > What happens for builtins with the "t" (custom typechecking) flag, for which > the signature is intended to have no meani

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 289631. tambre marked 6 inline comments as done. tambre added a comment. Remove __inline__ and static from all builtins in intrin.h. Remove ASTReader/ASTWriter placeholders. During builtin recognition: - Use ASTContext::GetBuiltinType() instead of creating a n

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

tambre added a comment. @phosek Please review again. I've overhauled the patch as I realized that per-target runtime directories don't make sense for the bare-metal target, since the runtime is only distinguished by the //specific// architecture and nothing else. As a result I've simply changed

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre updated this revision to Diff 289161. tambre added a comment. Rework patch to simply cleanup runtime handling in the bare-metal toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 Files: cla

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre added a comment. In D86877#2248064 , @phosek wrote: > This was discussed when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` was introduced > and there was a pushback against changing the driver behavior depending on > the value of that option, so if we're

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre updated this revision to Diff 289085. tambre added a comment. Remove define to change driver behaviour, use ToolChain::getCompilerRTArgString() instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D8687

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre updated this revision to Diff 288956. tambre added a comment. Add missing dash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/ToolChains/

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. tambre requested review of this revision. When LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is set to ON the clang_rt.builtins will not have an architecture prefix and

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:231 return ObjCOrBuiltinID == tok::NUM_OBJC_KEYWORDS; } rjmccall wrote: > Do we need to support reverting builtins anymore? We don't. It'd be possible to set the built

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 288911. tambre marked 2 inline comments as done. tambre added a comment. Remove builtin reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. FYI: PR45410, which this fixes, has been marked as a release blocker for 11.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-c

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. Please review. I would like to get this in a mergeable state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 288792. tambre added a comment. Herald added subscribers: danielkiss, jfb. Rebase, fix new MS builtins and other tests, XFAIL pthread_create() test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https:

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45344cf7ac5b: [CMake][compiler-rt][libunwind] Compile assembly fil

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre updated this revision to Diff 288292. tambre added a comment. Rebase, just in case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86308/new/ https://reviews.llvm.org/D86308 Files: clang/runtime/CMakeLists.txt compiler-rt/cmake/Modules/Ad

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2233934 , @teemperor wrote: > In D86308#2229936 , @tambre wrote: > >> In D86308#2229901 , @teemperor >> wrote: >> >>> Sorry, just got aroun

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre updated this revision to Diff 287421. tambre added a comment. Gate Apple workaround behind CMake version 3.19 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86308/new/ https://reviews.llvm.org/D86308 Files: clang/runtime/CMakeLists.txt c

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2229901 , @teemperor wrote: > Sorry, just got around to check this out. With the new workaround this seems > to work on macOS (the initial patch did produce the same error). Many thanks! I've submitted an upstream CMake

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2229199 , @mstorsjo wrote: > Just FWIW, a similar change was made in libunwind earlier > (c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 > ), which > then r

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

tambre updated this revision to Diff 286957. tambre added a comment. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. Add workaround for Apple, and for MinGW prior to CMake 3.17. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway. @teemperor Could you give this a try? If this doesn't work, could you upload the Ninja file for me to investiga

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

tambre created this revision. tambre added reviewers: phosek, teemperor. Herald added subscribers: Sanitizers, cfe-commits, dexonsmith, kristof.beyls, mgorny, dberris. Herald added projects: clang, Sanitizers. tambre requested review of this revision. It isn't very wise to pass an assembly file t

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/new/ https://reviews.llvm.org/D85706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

tambre added a comment. For reference, I've been using this + D75960 in my employer's Clang build for almost two months. We have been using `std::bit_cast` in our codebase quite a bit and haven't encountered any issues with these two changes. It would be nice t

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. In D85706#2214009 , @phosek wrote: > One concern I have with this change is that we may not always consistently > update CMAKE_ASM_FLAGS or set CMAKE_ASM_COMPILER. This wouldn't make a > difference before, but it'll with this chan

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre updated this revision to Diff 285692. tambre added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass CMAKE_ASM_COMPILER to compiler-rt in runtime build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/n

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 267450. tambre marked 4 inline comments as done. tambre added a comment. Fix some intrinsics not being marked as builtin due to being static in the headers. Make some code easier to read, fix test for sigsetjmp in Sema/implicit-builtin-decl.c to reflect the o

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre marked an inline comment as done. tambre added inline comments. Comment at: clang/lib/AST/Decl.cpp:3169-3175 } else { -if (!getIdentifier()) +const auto *Attr = getAttr(); + +if (!Attr) return 0; +BuiltinID = Attr->getID(); aaro

[PATCH] D79800: [Sema] Implement DR2233

tambre abandoned this revision. tambre added a comment. In D79800#2058985 , @rsmith wrote: > Unfortunately, I think this approach basically can't work, because we need to > consider inheriting default arguments from a previous (or subsequent!) > declarat

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8880 + } +} + rjmccall wrote: > tambre wrote: > > rjmccall wrote: > > > Hmm. I'm concerned about not doing any sort of semantic compatibility > > > check here before we assign the fu

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 265871. tambre marked 6 inline comments as done. tambre added a comment. Weakened noexcept checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/inclu

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 265872. tambre marked 4 inline comments as done. tambre added a comment. Remove memcpy overload tests from warn-fortify-source.c, which relied on identifier-based builtin identification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

tambre updated this revision to Diff 265850. tambre marked 5 inline comments as done. tambre added a comment. Handle multiple parameter packs interleaved with default values. Mark DR777 as superseded by DR2233. Mark DR2233 as resolved. Moved tests from dr7xx.cpp to dr22xx.cpp. Added note in dr7xx.

[PATCH] D79800: [Sema] Implement DR2233

tambre updated this revision to Diff 265855. tambre marked an inline comment as done. tambre added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 Files: clang/lib/Sema/SemaTemp

[PATCH] D79800: [Sema] Implement DR2233

tambre added a comment. Thanks for the reviews! I believe this now handles all cases and with this we're standards-conforming in regard to DR777 and DR2233. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1987 + +if (Function->getNumParams() >= NumTemplatedParam

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre marked 4 inline comments as done. tambre added a comment. Thanks for the reviews and design pointers, John! There are still a few tests failing, but I'd rather not dive in before the general approach is considered acceptable. Comment at: clang/lib/Sema/SemaDecl.cpp:888

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 264497. tambre marked an inline comment as not done. tambre added a comment. Semantic compatibility checking for C++ builtin redeclarations. Remove some now unnecessary logic from getBuiltinID(). Update more tests. 4 tests still failing. Repository: rG LLVM

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 264447. tambre marked 3 inline comments as done. tambre added a comment. Fix adding BuiltinAttr in C++ mode. Update one test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77

  1   2   >