ravikandhadai accepted this revision.
ravikandhadai added a comment.
This revision is now accepted and ready to land.
Thanks Akira.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156576/new/
https://reviews.llvm.org/D156576
ravikandhadai accepted this revision.
ravikandhadai added a comment.
This revision is now accepted and ready to land.
Thanks Akira. LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155012/new/
https://reviews.llvm.org/D155012
__
ravikandhadai added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:623
+def err_drv_darwin_sdk_missing_arclite : Error<
+ "SDK does not contain 'libarclite' at the path '%0'. This likely means you
need to increase your minimum deployment target"
ravikandhadai accepted this revision.
ravikandhadai added a comment.
This revision is now accepted and ready to land.
Thanks Akira.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131714/new/
https://reviews.llvm.org/D131714
ravikandhadai accepted this revision.
ravikandhadai added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks Alex.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118875/new/
https://reviews.llvm.org/D118875
___
cfe-commit
ravikandhadai accepted this revision.
ravikandhadai added a comment.
This revision is now accepted and ready to land.
Looks good to me! Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109402/new/
https://reviews.llvm.org/D109402
___
cfe
ravikandhadai added inline comments.
Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:889
+
+ /// Return true if th analyzed function is actually a default implementation
+ /// of the method that has to be overriden.
typo: th -> the
Repository:
rG LLVM Gi