[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

2019-08-04 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. Just chiming in to confirm that the requested change is correct for musl. musl does not support use/mixing of compiler-provided std headers with its headers, and intentionally has no mechanism for communicating with such headers as to which types have already been define

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

2019-08-05 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. It's not just infeasible; it's impossible by design. musl's headers do not support any contract with compiler-provided versions of the std headers, and won't. Attempting to use them in place of the libc ones is unsupported usage and will periodically break. Repository:

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

2019-09-09 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. That's a separate issue of clang having a slight types-ABI mismatch with some 32-bit archs whose original ABIs used `long` instead of `int` for `wchar_t`. The wrong header order makes it quickly apparent, but these are independent; wrong header order is still wrong and w

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. I don't understand the motivation of trying to match musl's definition here. musl explicitly **does not support** using a compiler-provided `stddef.h` or other standard headers. If it's getting included, this is a symption of an include order problem that needs to be fix

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. Please report what you're actually trying to do that's breaking rather than sending patches to align definitions that are not intended to be aligned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-03 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. musl targets **already** have the libc header path before the compiler header path in a BSD-like configuration (the BSDs also have this order on GCC and I would assume on clang as well), so if the compiler-provided `stddef.h` is getting seen at all, there's either a bug

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-05 Thread Rich Felker via Phabricator via cfe-commits
dalias added a comment. To be clear, musl does not support this regardless of whether `#include_next` is being used "right" or not. The only supported thing is not mixing headers at all. If Emscripten and wasi are using musl-based headers, it probably makes sense for these targets to do the sa