richard.barton.arm added a comment.
Hi all
I am uncomfortable with this patch for a number of reasons. These macros seem
to me to be defined by the ACLE as describing the behaviour of the combination
of library and compiler. For example, the __STDC_IEC_599__ macro would need
some standards com
richard.barton.arm added a comment.
Yes - I would be interested in knowing the rationale behind the original
AArch64 setting of __ARM_FP_FPENV_ROUNDING.
I also question whether our pre-conditions for __ARM_FP_FAST are sufficient.
There are many -f... options relating to maths operations, are th
richard.barton.arm added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1711
@@ -1710,1 +1710,3 @@
Args.hasArg(OPT_cl_fast_relaxed_math);
+ Opts.UnsafeFPMath = Args.hasArg(OPT_menable_unsafe_fp_math) ||
+ Args.hasArg(OPT_cl_unsafe_mat
richard.barton.arm added a comment.
In the overall approach, whilst this is the pragmatic approach to get the job
done, it clearly takes liberties with the definition of LangOpt as this your
new flag is most certainly a CodeGenOpt rather than a LangOpt. I'd like to see
what the others say as I
richard.barton.arm added a comment.
What do you think about this Renato? Although Alexandros has added a LangOption
which is strictly speaking to do with CodeGen rather than Lang, I think this is
the only pragmatica way to do this without needing re-engineering work to
expose the codegen option
richard.barton.arm abandoned this revision.
richard.barton.arm added a comment.
Adandoning and starting again with cfe-commits as subscriber.
http://reviews.llvm.org/D13497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
richard.barton.arm created this revision.
richard.barton.arm added reviewers: ddunbar, rafael.
richard.barton.arm added a subscriber: cfe-commits.
Clang's lit.cfg checks for the presence of a few test binaries, including the
clang-interpreter. This binary is only built if building the clang examp
richard.barton.arm created this revision.
richard.barton.arm added a reviewer: ABataev.
richard.barton.arm added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This test takes input from a file rather than from stdin and then goes on to
check for a label "bar". This could match s
richard.barton.arm abandoned this revision.
richard.barton.arm added a comment.
Abandoning as I forgot to add cfe-commits.
http://reviews.llvm.org/D13496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
richard.barton.arm created this revision.
richard.barton.arm added a reviewer: rafael.
richard.barton.arm added a subscriber: cfe-commits.
There are two asserts that can trigger if the number of diagnostic messages in a
kind overflows the number of available enums values. The one that fires if you
richard.barton.arm abandoned this revision.
richard.barton.arm added a comment.
Abandoning as cfe-commits was not on subscribers
http://reviews.llvm.org/D13495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: rbarton
Date: Wed Oct 7 05:33:36 2015
New Revision: 249535
URL: http://llvm.org/viewvc/llvm-project?rev=249535&view=rev
Log:
Make the test take input from stdin to prevent matching characters in a file
path
Modified:
cfe/trunk/test/OpenMP/for_simd_codegen.cpp
Modified: cfe/trunk/te
Author: rbarton
Date: Wed Oct 7 06:14:25 2015
New Revision: 249538
URL: http://llvm.org/viewvc/llvm-project?rev=249538&view=rev
Log:
Silence warning about not being able to find clang-interpreter
This binary is only built with the examples project, so only require it then.
Modified:
cfe/tru
richard.barton.arm added a subscriber: richard.barton.arm.
richard.barton.arm added a comment.
Hi Bradley
This matches the GCC targeting options:
https://sourceware.org/ml/binutils/2015-12/msg00295.html
https://sourceware.org/ml/binutils/2015-12/msg00296.html
The code changes LGTM. I think as th
richard.barton.arm created this revision.
richard.barton.arm added reviewers: EricWF, jamesr.
richard.barton.arm added a subscriber: cfe-commits.
Although not testing the annotations feature, the test still needs guarding for
thread-safety otherwise it will not compile at all.
http://reviews.llv
richard.barton.arm updated this revision to Diff 51316.
richard.barton.arm added a comment.
Sorry - not sure what happened there. That looks better for me.
http://reviews.llvm.org/D18347
Files:
test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp
Index:
test/libcxx
richard.barton.arm added a comment.
Hi Eric
Sorry for the delay - I originally detected the failure while not running in a
totally clean environment with clean sources, but I can reproduce on clean code.
I can reproduce by building with clean clang and libcxx sources:
cmake -DLLVM_PATH=/work/ri
richard.barton.arm added a comment.
Thanks for the help Eric. I'm just running a new patch now will put the new
patch up when I get back in to office tomorrow.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
richard.barton.arm updated this revision to Diff 51409.
richard.barton.arm added a comment.
My local run with no threads works with this updated patch.
http://reviews.llvm.org/D18347
Files:
test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp
test/libcxx/thread/thr
Author: rbarton
Date: Wed Mar 23 16:04:11 2016
New Revision: 264191
URL: http://llvm.org/viewvc/llvm-project?rev=264191&view=rev
Log:
Guard a number of tests relying on threads support when built in
single-threaded mode.
Differential Revision: http://reviews.llvm.org/D14731
Modified:
libcx
richard.barton.arm added a comment.
Hi Eric - no problem at all, you practically wrote it for me after all ;-)
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: rbarton
Date: Fri Oct 16 15:15:29 2015
New Revision: 250546
URL: http://llvm.org/viewvc/llvm-project?rev=250546&view=rev
Log:
Further increase helfulness of assert message
If you increase the number of diags of a particular type by one more than the
number available you get the nice asser
Author: rbarton
Date: Fri Oct 16 15:15:33 2015
New Revision: 250547
URL: http://llvm.org/viewvc/llvm-project?rev=250547&view=rev
Log:
Once again fix this test to read from stdin rather than an input file
Modified:
cfe/trunk/test/OpenMP/for_simd_codegen.cpp
Modified: cfe/trunk/test/OpenMP/for
richard.barton.arm closed this revision.
richard.barton.arm added a comment.
Committed as r250546 with the suggested change.
http://reviews.llvm.org/D13500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
richard.barton.arm created this revision.
richard.barton.arm added reviewers: labrinea, rengolin.
richard.barton.arm added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
The logic for parsing FP capabilities to set __ARM_FP was mistakenly removing
the Half-Precision capab
Author: rbarton
Date: Wed Oct 21 05:03:55 2015
New Revision: 250888
URL: http://llvm.org/viewvc/llvm-project?rev=250888&view=rev
Log:
Fix __ARM_FP value for sp-only FPUs with Half-precision
The logic for parsing FP capabilities to set __ARM_FP was mistakenly removing
the Half-Precision capability
richard.barton.arm closed this revision.
richard.barton.arm added a comment.
Committed as r250888
http://reviews.llvm.org/D13930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
richard.barton.arm added a subscriber: richard.barton.arm.
richard.barton.arm added a comment.
Hi all
At first glance I thought this would be something that is in the ACLE, so was
going to give an opinion. On second look, this is not actually an ACLE macro,
and seems to be a clang special - my
28 matches
Mail list logo
