DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232440, @beanz wrote:
> After line 18 in this file you could do something like:
>
> if(WITH_POLLY)
> list(APPEND LLVM_LINK_COMPONENTS Polly)
> endif()
>
>
> Then you can get rid of the `target_link_libraries` call.
It
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232440, @beanz wrote:
> After line 18 in this file you could do something like:
>
> if(WITH_POLLY)
> list(APPEND LLVM_LINK_COMPONENTS Polly)
> endif()
>
>
> Then you can get rid of the `target_link_libraries` call.
Ah,
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232419, @DiamondLovesYou wrote:
> In https://reviews.llvm.org/D51986#1232320, @beanz wrote:
>
> > I don’t think this is the right solution. The build system knows what
> > components are in the dylib and should remove them
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232320, @beanz wrote:
> I don’t think this is the right solution. The build system knows what
> components are in the dylib and should remove them from the list of libraries
> linked individually. You should be able to make
DiamondLovesYou updated this revision to Diff 165090.
DiamondLovesYou added a comment.
- Fix cmake warning
Repository:
rC Clang
https://reviews.llvm.org/D51986
Files:
tools/driver/CMakeLists.txt
Index: tools/driver/CMakeLists.txt
DiamondLovesYou created this revision.
DiamondLovesYou added a reviewer: beanz.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: bollu.
clang doesn't need to link Polly when built with `LLVM_LINK_LLVM_DYLIB`.
Repository:
rC Clang
https://reviews.llvm.org/D51986
Files:
