https://github.com/rmaz created https://github.com/llvm/llvm-project/pull/156108
Clang modules sort the umbrella dir headers by name before adding to the
module's includes to ensure deterministic output across different file systems.
This is insufficient however, as the header search table is als
https://github.com/rmaz approved this pull request.
https://github.com/llvm/llvm-project/pull/109375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rmaz approved this pull request.
https://github.com/llvm/llvm-project/pull/70661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rmaz closed https://github.com/llvm/llvm-project/pull/68023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From cf4ae971c3fd30f705fa79b8b918288649766d14 Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] add module builtin headers relative to resource dir
When inc
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From 87bbfac1ea77b9ff528f05f9eab0e380a5d85cbb Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] add module builtin headers relative to resource dir
When inc
rmaz wrote:
Thanks for the detailed reviews all, will get this rebased and landed.
https://github.com/llvm/llvm-project/pull/68023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From 5e3c6319c6a98a07dab6571f65ad1320815d76bf Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] add module builtin headers relative to resource dir
When inc
@@ -180,8 +180,9 @@ static void appendSubframeworkPaths(Module *Mod,
OptionalFileEntryRef ModuleMap::findHeader(
Module *M, const Module::UnresolvedHeaderDirective &Header,
SmallVectorImpl &RelativePathName, bool &NeedsFramework) {
- // Search for the header file withi
rmaz wrote:
@jansvoboda11 still good with this change, or is there a less invasive way to
get this done?
https://github.com/llvm/llvm-project/pull/68023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
rmaz wrote:
How about the updated approach? This will use a different include dir based on
if the header is a builtin header name or not, which also solves the issue of
having to pass the extra include path to the frontend.
https://github.com/llvm/llvm-project/pull/68023
__
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From 9d5ae4b53558614bdf9681bbefd02cf04aeb107b Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] add module builtin headers relative to resource dir
When inc
https://github.com/rmaz edited https://github.com/llvm/llvm-project/pull/68023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From d824f3839d34b0d043469c95cff4c146124b3666 Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] add module builtin headers relative to resource dir
When inc
rmaz wrote:
I had a go at this approach this morning, it mostly works but fails for the
case where we have a module with a textual header with the same name as a
builtin header. When using relative paths for the builtin headers we now prefer
the module's textual header instead of the builtin h
rmaz wrote:
> I thought you're trying to fix the situation where your resource dir is in
> the CWD, so that's the context I'm assuming. Is that correct?
Yes.
> I was considering your test case, where we'd previously store
> "resource-dir/include/float.h" into Header::PathRelativeToRootModuleD
rmaz wrote:
> Wouldn't this always have been the case? I'll check shortly with a resource
> dir picked up via toolchain bundle layout.
Looks like yes:
```
Process 77520 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
frame #0: 0x000109b568fd
clang`cla
rmaz wrote:
> Maybe prepending #pragma before #include of each builtin header?
Could you expand on this? Not sure I get the idea.
https://github.com/llvm/llvm-project/pull/68023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
rmaz wrote:
> This is now always storing an absolute path into
> Header::PathRelativeToRootModuleDirectory for built-in headers
Wouldn't this always have been the case? I'll check shortly with a resource dir
picked up via toolchain bundle layout.
> My bigger concern is that we now generate ab
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From 3617539eecb4bfcb9f2a20a1ae1cff71b298 Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] use absolute path for builtin headers during module
compilat
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From a44aa3a04dd6391cf4660cefe451ac1d53aa429d Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] use absolute path for builtin headers during module
compilat
https://github.com/rmaz created https://github.com/llvm/llvm-project/pull/68023
When including builtin headers as part of a system module, ensure we use
absolute paths to those headers. Otherwise the module will fail to compile when
specifying relative resource directories.
>From 6803c872fad25
https://github.com/rmaz closed https://github.com/llvm/llvm-project/pull/67744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rmaz created https://github.com/llvm/llvm-project/pull/67744
This change sets the debug compilation directory when generating debug
information for PCH object containers. This allows for overriding the
compilation directory in debug information in precompiled pcm files.
>Fro
rmaz wrote:
LGTM, possible to come up with some test case with multiple virtual entries to
the same file that would now be serialized once?
https://github.com/llvm/llvm-project/pull/67383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
Author: Richard Howell
Date: 2023-04-05T07:19:48-07:00
New Revision: 8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1
URL:
https://github.com/llvm/llvm-project/commit/8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1
DIFF:
https://github.com/llvm/llvm-project/commit/8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1.diff
Author: Richard Howell
Date: 2023-01-20T07:23:11-08:00
New Revision: 75fbb5d2238f1824f03d205b699061a115d5effc
URL:
https://github.com/llvm/llvm-project/commit/75fbb5d2238f1824f03d205b699061a115d5effc
DIFF:
https://github.com/llvm/llvm-project/commit/75fbb5d2238f1824f03d205b699061a115d5effc.diff
Author: Richard Howell
Date: 2022-09-26T09:48:54-07:00
New Revision: 1f451a8bd6f32465b6ff26c30ba7fb6fc7e0e689
URL:
https://github.com/llvm/llvm-project/commit/1f451a8bd6f32465b6ff26c30ba7fb6fc7e0e689
DIFF:
https://github.com/llvm/llvm-project/commit/1f451a8bd6f32465b6ff26c30ba7fb6fc7e0e689.diff
Author: Richard Howell
Date: 2022-09-12T12:00:43-07:00
New Revision: 3c1b42347b3a0666c93948ade2f420a20e060c1a
URL:
https://github.com/llvm/llvm-project/commit/3c1b42347b3a0666c93948ade2f420a20e060c1a
DIFF:
https://github.com/llvm/llvm-project/commit/3c1b42347b3a0666c93948ade2f420a20e060c1a.diff
Author: Richard Howell
Date: 2022-05-12T07:31:19-07:00
New Revision: ee51e9795a31e1280e30179215c27e09927230e2
URL:
https://github.com/llvm/llvm-project/commit/ee51e9795a31e1280e30179215c27e09927230e2
DIFF:
https://github.com/llvm/llvm-project/commit/ee51e9795a31e1280e30179215c27e09927230e2.diff
Author: Richard Howell
Date: 2022-05-12T07:29:37-07:00
New Revision: f11056943e56a32d81bb36d11fb5ce8d2b2ce79b
URL:
https://github.com/llvm/llvm-project/commit/f11056943e56a32d81bb36d11fb5ce8d2b2ce79b
DIFF:
https://github.com/llvm/llvm-project/commit/f11056943e56a32d81bb36d11fb5ce8d2b2ce79b.diff
Author: Richard Howell
Date: 2022-05-12T07:27:47-07:00
New Revision: 646e502de0d854cb3ecaca90ab52bebfe59a40cd
URL:
https://github.com/llvm/llvm-project/commit/646e502de0d854cb3ecaca90ab52bebfe59a40cd
DIFF:
https://github.com/llvm/llvm-project/commit/646e502de0d854cb3ecaca90ab52bebfe59a40cd.diff
32 matches
Mail list logo
